RPCS3/discord-bot
1
0
Fork 0
mirror of https://github.com/RPCS3/discord-bot.git synced 2024-11-30 13:40:30 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

current dice scoring implementation is incorrect :(

Browse Source 
but it's still much faster and works good enough for our purposes
This commit is contained in:
13xforever 2021-03-03 02:25:18 +05:00
parent 671f15cd31
commit 39105a9d60
3 changed files with 61 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
CompatBot/Utils/Extensions/DiceCoefficientOptimized.cs
View File

@ -9,7 +9,7 @@
/// <param name="input"></param>
/// <param name="comparedTo"></param>
/// <returns></returns>
public static double DiceCoefficient(this string input, string comparedTo)
public static double DiceIshCoefficientIsh(this string input, string comparedTo)
{
var bgCount1 = input.Length - 1;
var bgCount2 = comparedTo.Length - 1;

4
CompatBot/Utils/Extensions/StringUtils.cs
View File

@ -421,8 +421,8 @@ namespace CompatBot.Utils
private static double GetScoreWithAcronym(this string strA, string strB)
{
var fullMatch = strA.DiceCoefficient(strB);
var acronymMatch = strA.DiceCoefficient(strB.GetAcronym().ToLowerInvariant());
var fullMatch = strA.DiceIshCoefficientIsh(strB);
var acronymMatch = strA.DiceIshCoefficientIsh(strB.GetAcronym().ToLowerInvariant());
return Math.Max(fullMatch, acronymMatch);
}

71
Tests/StringUtilTests.cs
View File

@ -1,4 +1,6 @@
using System.Linq;
using System;
using System.Collections.Generic;
using System.Linq;
using CompatBot.EventHandlers;
using CompatBot.Utils;
using CompatBot.Utils.Extensions;
@ -67,36 +69,79 @@ namespace Tests
[TestCase("minesweeeper", "minesweeper")]
[TestCase("minesweeeeeeeeeeeeeeeeeeper", "minesweeper")]
[TestCase("ee", "eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee")]
[TestCase("eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee", "ee")]
[TestCase("aaaaaaaaa", "aaaaaaaaa")]
[TestCase("South Fort Union", "West Fort Union")]
public void DiceCoefficientRangeTest(string strA, string strB)
{
var coef = DiceCoefficient(strA, strB);
Assert.That(coef, Is.GreaterThanOrEqualTo(0.0).And.LessThanOrEqualTo(1.0));
Assert.That(DiceCoefficientExtensions.DiceCoefficient(strA, strB), Is.EqualTo(coef));
Assert.That(DiceCoefficientOptimized.DiceCoefficient(strA, strB), Is.LessThanOrEqualTo(coef));
//Assert.That(DiceCoefficientOptimized.DiceCoefficient(strA, strB), Is.EqualTo(coef));
//Assert.That(DiceCoefficientExtensions.DiceCoefficient(strA, strB), Is.EqualTo(coef));
var tmp = strA;
strA = strB;
strB = tmp;
(strB, strA) = (strA, strB);
var coefB = DiceCoefficient(strA, strB);
Assert.That(coefB, Is.EqualTo(coef));
Assert.That(DiceCoefficientExtensions.DiceCoefficient(strA, strB), Is.EqualTo(coef));
Assert.That(DiceCoefficientOptimized.DiceCoefficient(strA, strB), Is.LessThanOrEqualTo(coef));
//Assert.That(DiceCoefficientOptimized.DiceCoefficient(strA, strB), Is.EqualTo(coef));
//Assert.That(DiceCoefficientExtensions.DiceCoefficient(strA, strB), Is.EqualTo(coef));
}
[Test]
public void DistanceTest()
{
var strA = @"
""Beware of the man who works hard to learn something, learns it, and finds
himself no wiser than before,"" Bokonon tells us. ""He is full of murderous
resentment of people who are ignorant without having come by their
ignorance the hard way.""
― Kurt Vonnegut, ""Cat's Cradle""
".Trim();
var strB = @"
""Beware of the man who works hard to learn something, learns it, and finds himself no wiser than before,"" Bokonon tells us. ""He is full of murderous resentment of people who are ignorant without having come by their ignorance the hard way.""
-- Kurt Vonnegut, ""Cat's Cradle""
".Trim();
var coef = DiceCoefficientOptimized.DiceIshCoefficientIsh(strA, strB);
Assert.That(coef, Is.GreaterThan(0.95), "Dice Coefficient");
var distance = strA.LevenshteinDistance(strB);
Assert.That(distance, Is.LessThan(0.05));
}
public static double DiceCoefficient(string input, string comparedTo)
{
var ngrams = input.ToBiGrams();
var compareToNgrams = comparedTo.ToBiGrams();
var ngrams = input.ToBiGrams()[1..^1];
var compareToNgrams = comparedTo.ToBiGrams()[1..^1];
return DiceCoefficient(ngrams, compareToNgrams);
}
public static double DiceCoefficient(string[] nGrams, string[] compareToNGrams)
{
var matches = nGrams.Intersect(compareToNGrams).Count();
if (matches == 0)
var nGramMap = new Dictionary<string, int>(nGrams.Length);
var compareToNGramMap = new Dictionary<string, int>(compareToNGrams.Length);
var nGramSet = new HashSet<string>();
var compareToNGramSet = new HashSet<string>();
foreach (var nGram in nGrams)
{
if (nGramSet.Add(nGram))
nGramMap[nGram] = 1;
else
nGramMap[nGram]++;
}
foreach (var nGram in compareToNGrams)
{
if (compareToNGramSet.Add(nGram))
compareToNGramMap[nGram] = 1;
else
compareToNGramMap[nGram]++;
}
nGramSet.IntersectWith(compareToNGramSet);
if (nGramSet.Count == 0)
return 0.0d;
var matches = 0;
foreach (var nGram in nGramSet)
matches += Math.Min(nGramMap[nGram], compareToNGramMap[nGram]);
double totalBigrams = nGrams.Length + compareToNGrams.Length;
return (2 * matches) / totalBigrams;
}