RPCS3/discord-bot
1
0
Fork 0
mirror of https://github.com/RPCS3/discord-bot.git synced 2025-02-20 18:00:37 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix async texture streaming check and add note for 470 series on nvidia

Browse Source
This commit is contained in:
13xforever 2021-06-23 21:07:24 +05:00
parent 969f2631b6
commit fbf0d310b3
3 changed files with 22 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
CompatBot/EventHandlers/LogParsing/LogParser.LogSections.cs
View File

@ -130,7 +130,7 @@ namespace CompatBot.EventHandlers.LogParsing
["12:"] = new(@"(D3D12|DirectX 12):\s*\r?\n\s*Adapter: (?<d3d_gpu>.*?)\r?$", DefaultOptions),
["Vulkan:"] = new(@"Vulkan:\s*\r?\n\s*Adapter: (?<vulkan_gpu>.*?)\r?$", DefaultOptions),
["Force FIFO present mode:"] = new(@"Force FIFO present mode: (?<force_fifo_present>.*?)\r?$", DefaultOptions),
["Asynchronous Texture Streaming:"] = new(@"Asynchronous Texture Streaming: (?<async_texture_streaming>.*?)\r?$", DefaultOptions),
["Asynchronous Texture Streaming"] = new(@"Asynchronous Texture Streaming( 2)?: (?<async_texture_streaming>.*?)\r?$", DefaultOptions),
["Asynchronous Queue Scheduler:"] = new(@"Asynchronous Queue Scheduler: (?<async_queue_scheduler>.*?)\r?$", DefaultOptions),
},
EndTrigger = new[] {"Audio:"},

17
CompatBot/Utils/ResultFormatters/LogParserResultFormatter.GeneralNotesSection.cs
View File

@ -137,9 +137,7 @@ namespace CompatBot.Utils.ResultFormatters
}
var category = items["game_category"];
if (category == "PE"
|| category == "PP"
|| serial.StartsWith('U') && ProductCodeLookup.ProductCode.IsMatch(serial))
if (category is "PE" or "PP" || serial.StartsWith('U') && ProductCodeLookup.ProductCode.IsMatch(serial))
{
builder.Color = Config.Colors.CompatStatusNothing;
notes.Add("❌ PSP software is not supported");
@ -149,7 +147,7 @@ namespace CompatBot.Utils.ResultFormatters
builder.Color = Config.Colors.CompatStatusNothing;
notes.Add("❌ Minis are not supported");
}
if (category == "2G" || category == "2P" || category == "2D")
if (category is "2G" or "2P" or "2D")
{
builder.Color = Config.Colors.CompatStatusNothing;
notes.Add("❌ PS2 software is not supported");
@ -256,14 +254,14 @@ namespace CompatBot.Utils.ResultFormatters
var gpuInfo = items["gpu_info"] ?? items["discrete_gpu_info"];
if (supportedGpu && !string.IsNullOrEmpty(gpuInfo))
{
if (IntelGpuModel.Match(gpuInfo) is Match {Success: true} intelMatch)
if (IntelGpuModel.Match(gpuInfo) is {Success: true} intelMatch)
{
var family = intelMatch.Groups["gpu_family"].Value.TrimEnd();
var modelNumber = intelMatch.Groups["gpu_model_number"].Value;
if (!string.IsNullOrEmpty(modelNumber) && modelNumber.StartsWith('P'))
modelNumber = modelNumber[1..];
_ = int.TryParse(modelNumber, out var modelNumberInt);
if (family == "UHD" || family == "Iris Plus" || family == "Iris Xe" || modelNumberInt > 500 && modelNumberInt < 1000)
if (family is "UHD" or "Iris Plus" or "Iris Xe" || modelNumberInt is > 500 and < 1000)
notes.Add("⚠ Intel iGPUs are not officially supported; visual glitches are to be expected");
else
{
@ -279,6 +277,7 @@ namespace CompatBot.Utils.ResultFormatters
if (Version.TryParse(driverVersionString, out var driverVersion)
&& Version.TryParse(items["build_full_version"], out var buildVersion))
{
items["driver_version_parsed"] = driverVersion.ToString();
if (IsNvidia(gpuInfo))
{
var isWindows = items["os_type"] is string os && os != "Linux";
@ -369,7 +368,7 @@ namespace CompatBot.Utils.ResultFormatters
if (items["game_category"] == "GD")
notes.Add($"❔ Game was booted through the Game Data");
*/
if (category == "DG" || category == "GD") // only disc games should install game data
if (category is "DG" or "GD") // only disc games should install game data
{
discInsideGame |= !string.IsNullOrEmpty(items["ldr_disc"]) && !(items["serial"]?.StartsWith("NP", StringComparison.InvariantCultureIgnoreCase) ?? false);
discAsPkg |= items["serial"]?.StartsWith("NP", StringComparison.InvariantCultureIgnoreCase) ?? false;
@ -399,9 +398,7 @@ namespace CompatBot.Utils.ResultFormatters
var updateInfo = await CheckForUpdateAsync(items).ConfigureAwait(false);
var buildBranch = items["build_branch"]?.ToLowerInvariant();
if (updateInfo != null
&& (buildBranch == "head"
|| buildBranch == "spu_perf"
|| string.IsNullOrEmpty(buildBranch) && updateInfo.CurrentBuild != null))
&& (buildBranch is "head" or "spu_perf" || string.IsNullOrEmpty(buildBranch) && updateInfo.CurrentBuild != null))
{
string prefix = "⚠";
string timeDeltaStr;

17
CompatBot/Utils/ResultFormatters/LogParserResultFormatter.WeirdSettingsSection.cs
View File

@ -246,9 +246,20 @@ namespace CompatBot.Utils.ResultFormatters
}
if (items["async_texture_streaming"] == EnabledMark)
{
if (items["async_queue_scheduler"] == "Device")
notes.Add("⚠ If you experience visual artifacts, try setting `Async Queue Scheduler` to use `Host`");
notes.Add("⚠ If you experience visual artifacts, try disabling `Async Texture Streaming`");
if (items["gpu_info"] is string gpuInfo2
&& IsNvidia(gpuInfo2)
&& items["driver_version_parsed"] is string driverVersionString
&& Version.TryParse(driverVersionString, out var driverVersion)
&& driverVersion.Major >= 470)
{
notes.Add("❌ Please disable `Async Texture Streaming` for 470 series NVidia drivers");
}
else
{
if (items["async_queue_scheduler"] == "Device")
notes.Add("⚠ If you experience visual artifacts, try setting `Async Queue Scheduler` to use `Host`");
notes.Add("⚠ If you experience visual artifacts, try disabling `Async Texture Streaming`");
}
}
if (items["ppu_decoder"] is string ppuDecoder)