RPCS3/discord-bot
1
0
Fork 0
mirror of https://github.com/RPCS3/discord-bot.git synced 2026-07-19 13:54:44 -04:00
Code Issues 20 Packages Projects Releases Wiki Activity

[PR #1019] [MERGED] Rusty code cleanup #1020

New Issue
Closed
opened 2026-06-05 16:14:38 -04:00 by yindo · 0 comments
yindo commented 2026-06-05 16:14:38 -04:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/RPCS3/discord-bot/pull/1019
Author: @13xforever
Created: 3/12/2026
Status: ✅ Merged
Merged: 3/12/2026
Merged by: @13xforever

Base: master ← Head: vnext

📝 Commits (3)

  • dcbd8ef upgrade packages
  • 59853b1 remove azure client and fix some issues with .net 10 compiler changes
  • 230dfd4 update code to use ArgumentNullException.ThrowIfNull()

📊 Changes

25 files changed (+55 additions, -423 deletions)

View changed files

📝 Clients/CirrusCiClient/CirrusCiClient.csproj (+3 -3)
📝 Clients/CompatApiClient/CompatApiClient.csproj (+1 -1)
📝 Clients/CompatApiClient/Formatters/NamingStyles.cs (+2 -4)
📝 Clients/GithubClient/GithubClient.csproj (+1 -1)
📝 Clients/IrdLibraryClient/IrdFormat/IrdParser.cs (+1 -2)
📝 Clients/IrdLibraryClient/IrdLibraryClient.csproj (+2 -2)
📝 Clients/PsnClient/PsnClient.csproj (+1 -1)
📝 CompatBot/Commands/BotStatus.cs (+0 -1)
📝 CompatBot/Commands/CompatList.Latest.cs (+7 -22)
📝 CompatBot/Commands/Pr.cs (+2 -2)
📝 CompatBot/CompatBot.csproj (+9 -10)
📝 CompatBot/Config.cs (+1 -22)
📝 CompatBot/Database/NamingConventionConverter.cs (+1 -2)
📝 CompatBot/EventHandlers/AntiSpamMessageHandler.cs (+0 -1)
📝 CompatBot/EventHandlers/GlobalMessageCache.cs (+1 -1)
📝 CompatBot/EventHandlers/NewBuildsMonitor.cs (+2 -2)
📝 CompatBot/Program.cs (+0 -1)
📝 CompatBot/Utils/AsciiTable.cs (+3 -6)
📝 CompatBot/Utils/BufferCopyStream.cs (+1 -2)
➖ CompatBot/Utils/Extensions/AzureDevOpsClientExtensions.cs (+0 -326)

...and 5 more files

📄 Description

  • removed azure client references
  • fixed some extension method issues with the new compiler changes
  • updated some code to use newer language features and library methods
  • updated packages

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/RPCS3/discord-bot/pull/1019 **Author:** [@13xforever](https://github.com/13xforever) **Created:** 3/12/2026 **Status:** ✅ Merged **Merged:** 3/12/2026 **Merged by:** [@13xforever](https://github.com/13xforever) **Base:** `master` ← **Head:** `vnext` --- ### 📝 Commits (3) - [`dcbd8ef`](https://github.com/RPCS3/discord-bot/commit/dcbd8ef9f1b2ab202a4fc619397d80ee5c05153b) upgrade packages - [`59853b1`](https://github.com/RPCS3/discord-bot/commit/59853b19076a3dd95a32629e91e49f2bfffb4132) remove azure client and fix some issues with .net 10 compiler changes - [`230dfd4`](https://github.com/RPCS3/discord-bot/commit/230dfd44903eb4f36713b1c8576048f15b144521) update code to use ArgumentNullException.ThrowIfNull() ### 📊 Changes **25 files changed** (+55 additions, -423 deletions) <details> <summary>View changed files</summary> 📝 `Clients/CirrusCiClient/CirrusCiClient.csproj` (+3 -3) 📝 `Clients/CompatApiClient/CompatApiClient.csproj` (+1 -1) 📝 `Clients/CompatApiClient/Formatters/NamingStyles.cs` (+2 -4) 📝 `Clients/GithubClient/GithubClient.csproj` (+1 -1) 📝 `Clients/IrdLibraryClient/IrdFormat/IrdParser.cs` (+1 -2) 📝 `Clients/IrdLibraryClient/IrdLibraryClient.csproj` (+2 -2) 📝 `Clients/PsnClient/PsnClient.csproj` (+1 -1) 📝 `CompatBot/Commands/BotStatus.cs` (+0 -1) 📝 `CompatBot/Commands/CompatList.Latest.cs` (+7 -22) 📝 `CompatBot/Commands/Pr.cs` (+2 -2) 📝 `CompatBot/CompatBot.csproj` (+9 -10) 📝 `CompatBot/Config.cs` (+1 -22) 📝 `CompatBot/Database/NamingConventionConverter.cs` (+1 -2) 📝 `CompatBot/EventHandlers/AntiSpamMessageHandler.cs` (+0 -1) 📝 `CompatBot/EventHandlers/GlobalMessageCache.cs` (+1 -1) 📝 `CompatBot/EventHandlers/NewBuildsMonitor.cs` (+2 -2) 📝 `CompatBot/Program.cs` (+0 -1) 📝 `CompatBot/Utils/AsciiTable.cs` (+3 -6) 📝 `CompatBot/Utils/BufferCopyStream.cs` (+1 -2) ➖ `CompatBot/Utils/Extensions/AzureDevOpsClientExtensions.cs` (+0 -326) _...and 5 more files_ </details> ### 📄 Description * removed azure client references * fixed some extension method issues with the new compiler changes * updated some code to use newer language features and library methods * updated packages --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-06-05 16:14:38 -04:00
yindo closed this issue 2026-06-05 16:14:38 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Hacktoberfest
Hacktoberfest
bug
enhancement
enhancement
enhancement
fun stuff
good first issue
good first issue
help wanted
high priority
invalid
log analyzer
pull-request
Mirrored from GitHub Pull Request
 questionable
questionable
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: RPCS3/discord-bot#1020
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?