[PR #85] [MERGED] Implement logging #204

Closed
opened 2026-02-15 15:55:19 -05:00 by yindo · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/RPCS3/discord-bot/pull/85
Author: @13xforever
Created: 10/5/2018
Status: Merged
Merged: 10/6/2018
Merged by: @Nicba1010

Base: masterHead: feature/logging


📝 Commits (9)

  • 69288ff Swallow all exceptions in async void methods
  • ca3e5ab Change !explain list message a bit to reduce spam from noobs
  • 6486681 update packages
  • 8dff5eb implemented persistent logging
  • 30c309b Add a note for games that have multiple update pkgs
  • d3e1220 ignore logs dir
  • b7ef00f Bump min log level to INFO for release configuration
  • a5f8c77 Change default log location to the project root after testing
  • b65a743 Don't use internal discord client logging now that we have a proper solution

📊 Changes

37 files changed (+285 additions, -217 deletions)

View changed files

📝 .gitignore (+2 -0)
📝 CompatApiClient/ApiConfig.cs (+5 -3)
📝 CompatApiClient/Client.cs (+5 -5)
📝 CompatApiClient/CompatApiClient.csproj (+1 -0)
📝 CompatApiClient/Utils/ConsoleLogger.cs (+13 -14)
📝 CompatBot/Commands/Attributes/CheckBaseAttributeWithReactions.cs (+1 -3)
📝 CompatBot/Commands/CompatList.cs (+3 -3)
📝 CompatBot/Commands/Explain.cs (+2 -2)
📝 CompatBot/Commands/Misc.cs (+2 -2)
📝 CompatBot/Commands/Moderation.Audit.cs (+10 -1)
📝 CompatBot/Commands/Psn.Check.cs (+2 -0)
📝 CompatBot/Commands/Psn.cs (+2 -2)
📝 CompatBot/Commands/Sudo.Bot.Commands.cs (+2 -2)
📝 CompatBot/Commands/Sudo.Fix.cs (+2 -2)
📝 CompatBot/Commands/Warnings.cs (+2 -3)
📝 CompatBot/CompatBot.csproj (+7 -6)
📝 CompatBot/Config.cs (+36 -0)
📝 CompatBot/Database/DbImporter.cs (+6 -15)
📝 CompatBot/Database/Providers/AmdDriverVersionProvider.cs (+1 -1)
📝 CompatBot/Database/Providers/ThumbnailProvider.cs (+1 -1)

...and 17 more files

📄 Description

By default config parameter LogPath is set to <project_root>logs/bot.log.
Relative paths computed from the assembly location, not from current directory.
Logs are rotated daily.
Also fixed some small issues with background task processing.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/RPCS3/discord-bot/pull/85 **Author:** [@13xforever](https://github.com/13xforever) **Created:** 10/5/2018 **Status:** ✅ Merged **Merged:** 10/6/2018 **Merged by:** [@Nicba1010](https://github.com/Nicba1010) **Base:** `master` ← **Head:** `feature/logging` --- ### 📝 Commits (9) - [`69288ff`](https://github.com/RPCS3/discord-bot/commit/69288ff5b412fa4a9b8c3d0e366851a9d18f4472) Swallow all exceptions in async void methods - [`ca3e5ab`](https://github.com/RPCS3/discord-bot/commit/ca3e5abde33932387730de4f436a79bc8176e64e) Change !explain list message a bit to reduce spam from noobs - [`6486681`](https://github.com/RPCS3/discord-bot/commit/6486681355e4065c9c755fdbb881b8ba087bb2d7) update packages - [`8dff5eb`](https://github.com/RPCS3/discord-bot/commit/8dff5eb13a2b6da9474e78d110269d90b7a9e527) implemented persistent logging - [`30c309b`](https://github.com/RPCS3/discord-bot/commit/30c309bd7bec9c64e0effd2fee57a6afe9940e2d) Add a note for games that have multiple update pkgs - [`d3e1220`](https://github.com/RPCS3/discord-bot/commit/d3e12200c7bb24547f89b5e902a0bd0c11f6fe12) ignore logs dir - [`b7ef00f`](https://github.com/RPCS3/discord-bot/commit/b7ef00f8356eadaf2b09e8025f57e9d03dc56bb7) Bump min log level to INFO for release configuration - [`a5f8c77`](https://github.com/RPCS3/discord-bot/commit/a5f8c7711e01d52a945a2a4562de92fe8601aa5c) Change default log location to the project root after testing - [`b65a743`](https://github.com/RPCS3/discord-bot/commit/b65a7438699e7a1abca8a40ebbbd6b66ec2feef2) Don't use internal discord client logging now that we have a proper solution ### 📊 Changes **37 files changed** (+285 additions, -217 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+2 -0) 📝 `CompatApiClient/ApiConfig.cs` (+5 -3) 📝 `CompatApiClient/Client.cs` (+5 -5) 📝 `CompatApiClient/CompatApiClient.csproj` (+1 -0) 📝 `CompatApiClient/Utils/ConsoleLogger.cs` (+13 -14) 📝 `CompatBot/Commands/Attributes/CheckBaseAttributeWithReactions.cs` (+1 -3) 📝 `CompatBot/Commands/CompatList.cs` (+3 -3) 📝 `CompatBot/Commands/Explain.cs` (+2 -2) 📝 `CompatBot/Commands/Misc.cs` (+2 -2) 📝 `CompatBot/Commands/Moderation.Audit.cs` (+10 -1) 📝 `CompatBot/Commands/Psn.Check.cs` (+2 -0) 📝 `CompatBot/Commands/Psn.cs` (+2 -2) 📝 `CompatBot/Commands/Sudo.Bot.Commands.cs` (+2 -2) 📝 `CompatBot/Commands/Sudo.Fix.cs` (+2 -2) 📝 `CompatBot/Commands/Warnings.cs` (+2 -3) 📝 `CompatBot/CompatBot.csproj` (+7 -6) 📝 `CompatBot/Config.cs` (+36 -0) 📝 `CompatBot/Database/DbImporter.cs` (+6 -15) 📝 `CompatBot/Database/Providers/AmdDriverVersionProvider.cs` (+1 -1) 📝 `CompatBot/Database/Providers/ThumbnailProvider.cs` (+1 -1) _...and 17 more files_ </details> ### 📄 Description By default config parameter `LogPath` is set to `<project_root>logs/bot.log`. Relative paths computed from the _assembly_ location, not from current directory. Logs are rotated daily. Also fixed some small issues with background task processing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-15 15:55:19 -05:00
yindo closed this issue 2026-02-15 15:55:19 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: RPCS3/discord-bot#204