[PR #229] [MERGED] Fix even more bugs in the log parser #309

New Issue

2026-02-15T15:55:37-05:00

yindo commented

2026-02-15 15:55:37 -05:00

📋 Pull Request Information

Original PR: https://github.com/RPCS3/discord-bot/pull/229
Author: @13xforever
Created: 2/23/2019
Status: ✅ Merged
Merged: 2/23/2019
Merged by: @13xforever

Base: master ← Head: vnext

📝 Commits (2)

8971423 fix double log upload prompt with the changes to fw detection in logs
cc37ac8 fix the actually stupid part where an empty value could overwrite the valid one

📊 Changes

4 files changed (+19 additions, -11 deletions)

View changed files

📝 CompatBot/EventHandlers/LogParsing/LogParser.LogSections.cs (+2 -2)
📝 CompatBot/EventHandlers/LogParsing/LogParser.StateMachineGenerator.cs (+8 -2)
📝 CompatBot/Utils/ResultFormatters/LogParserResultFormatter.CurrentSettingsSections.cs (+3 -1)
📝 CompatBot/Utils/ResultFormatters/LogParserResultFormatter.GeneralNotesSection.cs (+6 -6)

📄 Description

Sometimes found values could've been replaced with an empty string from a no-match :(

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/RPCS3/discord-bot/pull/229 **Author:** [@13xforever](https://github.com/13xforever) **Created:** 2/23/2019 **Status:** ✅ Merged **Merged:** 2/23/2019 **Merged by:** [@13xforever](https://github.com/13xforever) **Base:** `master` ← **Head:** `vnext` --- ### 📝 Commits (2) - [`8971423`](https://github.com/RPCS3/discord-bot/commit/897142388ce6b7c30a4ae863ae380c5326f7b5da) fix double log upload prompt with the changes to fw detection in logs - [`cc37ac8`](https://github.com/RPCS3/discord-bot/commit/cc37ac833a2477c54d55c1e1be71e61bf32e850b) fix the actually stupid part where an empty value could overwrite the valid one ### 📊 Changes **4 files changed** (+19 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `CompatBot/EventHandlers/LogParsing/LogParser.LogSections.cs` (+2 -2) 📝 `CompatBot/EventHandlers/LogParsing/LogParser.StateMachineGenerator.cs` (+8 -2) 📝 `CompatBot/Utils/ResultFormatters/LogParserResultFormatter.CurrentSettingsSections.cs` (+3 -1) 📝 `CompatBot/Utils/ResultFormatters/LogParserResultFormatter.GeneralNotesSection.cs` (+6 -6) </details> ### 📄 Description Sometimes found values could've been replaced with an empty string from a no-match :( --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

yindo added the pull-request label 2026-02-15 15:55:37 -05:00

yindo closed this issue

2026-02-15 15:55:37 -05:00

yindo referenced this issue

2026-02-15 15:55:49 -05:00

[PR #309] [MERGED] More log notes #385

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: RPCS3/discord-bot#309