[PR #246] [MERGED] Small fixes #324

Closed
opened 2026-02-15 15:55:40 -05:00 by yindo · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/RPCS3/discord-bot/pull/246
Author: @13xforever
Created: 3/6/2019
Status: Merged
Merged: 3/6/2019
Merged by: @13xforever

Base: masterHead: vnext


📝 Commits (7)

  • b557b36 add diagnostics to the stats saving
  • fb4c704 better moons
  • f151658 still no idea why it fails sometimes
  • ae33b04 so apparently you need to do this in two separate transactions, ugh
  • cda0558 oh, I am stupid
  • 993cc54 return first game if filtering by score didn't work out
  • 58984da fix some invalid results

📊 Changes

4 files changed (+65 additions, -22 deletions)

View changed files

📝 CompatBot/Commands/Misc.cs (+5 -1)
📝 CompatBot/Commands/Psn.cs (+21 -8)
📝 CompatBot/Database/Providers/StatsStorage.cs (+22 -6)
📝 CompatBot/Utils/StringUtils.cs (+17 -7)

📄 Description

  • fix saving bot stats (properly this time)
  • fix searching for games returning invalid results in rare cases

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/RPCS3/discord-bot/pull/246 **Author:** [@13xforever](https://github.com/13xforever) **Created:** 3/6/2019 **Status:** ✅ Merged **Merged:** 3/6/2019 **Merged by:** [@13xforever](https://github.com/13xforever) **Base:** `master` ← **Head:** `vnext` --- ### 📝 Commits (7) - [`b557b36`](https://github.com/RPCS3/discord-bot/commit/b557b3642c799ac3fa242b8bee978f612524805c) add diagnostics to the stats saving - [`fb4c704`](https://github.com/RPCS3/discord-bot/commit/fb4c7046749f7d0f843cc92ea7073dadbb04cbac) better moons - [`f151658`](https://github.com/RPCS3/discord-bot/commit/f1516583e63aafed579c79eac3c32b4eef6868ab) still no idea why it fails sometimes - [`ae33b04`](https://github.com/RPCS3/discord-bot/commit/ae33b04edc6b7bd3a26addd11758b662b5d05a2f) so apparently you need to do this in two separate transactions, ugh - [`cda0558`](https://github.com/RPCS3/discord-bot/commit/cda055882ad3264719f0628a164801579a918773) oh, I _am_ stupid - [`993cc54`](https://github.com/RPCS3/discord-bot/commit/993cc54c980a10324ef59fb9c2a1a9c5b3d6dbe2) return first game if filtering by score didn't work out - [`58984da`](https://github.com/RPCS3/discord-bot/commit/58984da69f019b70cf8116c3dc9880eed8ed0800) fix some invalid results ### 📊 Changes **4 files changed** (+65 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `CompatBot/Commands/Misc.cs` (+5 -1) 📝 `CompatBot/Commands/Psn.cs` (+21 -8) 📝 `CompatBot/Database/Providers/StatsStorage.cs` (+22 -6) 📝 `CompatBot/Utils/StringUtils.cs` (+17 -7) </details> ### 📄 Description * fix saving bot stats (properly this time) * fix searching for games returning invalid results in rare cases --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-15 15:55:40 -05:00
yindo closed this issue 2026-02-15 15:55:40 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: RPCS3/discord-bot#324