[PR #295] [MERGED] Small fixes #371

Closed
opened 2026-02-15 15:55:47 -05:00 by yindo · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/RPCS3/discord-bot/pull/295
Author: @13xforever
Created: 4/22/2019
Status: Merged
Merged: 4/22/2019
Merged by: @13xforever

Base: masterHead: vnext


📝 Commits (2)

  • 9bf2517 wait for section extractors to finish before marking it as finished
  • 1a42b68 ignore commands in !psn check updates when called with invalid code first

📊 Changes

2 files changed (+10 additions, -3 deletions)

View changed files

📝 CompatBot/Commands/Psn.Check.cs (+9 -3)
📝 CompatBot/EventHandlers/LogParsing/LogParser.PipeReader.cs (+1 -0)

📄 Description

  • fixed log parser where some extracted data could've been lost if it was near the end of the last log section
  • implemented workaround for users who refuse to read interactive prompts when supplying incorrect values to the command

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/RPCS3/discord-bot/pull/295 **Author:** [@13xforever](https://github.com/13xforever) **Created:** 4/22/2019 **Status:** ✅ Merged **Merged:** 4/22/2019 **Merged by:** [@13xforever](https://github.com/13xforever) **Base:** `master` ← **Head:** `vnext` --- ### 📝 Commits (2) - [`9bf2517`](https://github.com/RPCS3/discord-bot/commit/9bf2517f9da2279e81b0b72a8951ae7c44005f5a) wait for section extractors to finish before marking it as finished - [`1a42b68`](https://github.com/RPCS3/discord-bot/commit/1a42b68d329daa7d05d287a14d450a8e84ee5685) ignore commands in !psn check updates when called with invalid code first ### 📊 Changes **2 files changed** (+10 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `CompatBot/Commands/Psn.Check.cs` (+9 -3) 📝 `CompatBot/EventHandlers/LogParsing/LogParser.PipeReader.cs` (+1 -0) </details> ### 📄 Description * fixed log parser where some extracted data could've been lost if it was near the end of the last log section * implemented workaround for users who refuse to read interactive prompts when supplying incorrect values to the command --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-15 15:55:47 -05:00
yindo closed this issue 2026-02-15 15:55:47 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: RPCS3/discord-bot#371