[GH-ISSUE #182] Regrouping a few commands #38

New Issue

2026-02-15T15:54:46-05:00

yindo commented

2026-02-15 15:54:46 -05:00

Originally created by @dio-gh on GitHub (Jan 18, 2019).
Original GitHub issue: https://github.com/RPCS3/discord-bot/issues/182

As I was writing #180, I noticed that !psn check updates XXXXYYYYY is terribly long. There are a few ways of going about this, but first and foremost I think regrouping the psn subcommands should be the way to go.

The current hierarchy looks like this:

psn => { psn check | psn fix | psn rescan } => { psn check updates | psn check content }

As you can see, at the third level the commands are pretty damn long, and this isn't even with the parameters they recieve. There's numerous ways, as always, you can regroup this, but here's mine:

First, I don't think specifying psn really adds that much of a meaning to check updates or check content. In the former case, you really don't care about where the update list is coming from, and in the latter, it doesn't even directly come from PSN but from our mirror. So, while it is important to specify psn in the cases of fix and rescan, for check it just isn't.

Therefore, it can be removed, or more accurately saying, the check subgroup can be moved out from the psn supergroup into its own, without breaking any readability considerations.

Take then the following grouping:

psn => { psn fix | psn rescan }
check => { check updates | check content }

The commands are suddenly much shorter, but still hold the same meaning, while also retaining their sentence-like feel.

Whilst thinking about more reasons to recreate the check token as a standalone command group, my attention turned towards the !ird command. You for sure check for an .ird, and it is pretty fitting all things considered. And so while we're at it, I also recommend moving the ird command group below the check group as follows:

psn => { psn fix | psn rescan }
check => { check updates | check content | check ird }

This will need all the related help and explain commands to be updated too, of course.

Originally created by @dio-gh on GitHub (Jan 18, 2019). Original GitHub issue: https://github.com/RPCS3/discord-bot/issues/182 As I was writing #180, I noticed that `!psn check updates XXXXYYYYY` is terribly long. There are a few ways of going about this, but first and foremost I think regrouping the `psn` subcommands should be the way to go. The current hierarchy looks like this: `psn` => `{ psn check | psn fix | psn rescan }` => `{ psn check updates | psn check content }` As you can see, at the third level the commands are pretty damn long, and this isn't even with the parameters they recieve. There's numerous ways, as always, you can regroup this, but here's mine: First, I don't think specifying `psn` really adds that much of a meaning to `check updates` or `check content`. In the former case, you really don't care about where the update list is coming from, and in the latter, it doesn't even directly come from PSN but from our mirror. So, while it *is* important to specify `psn` in the cases of `fix` and `rescan`, for `check` it just isn't. Therefore, it can be removed, or more accurately saying, the `check` subgroup can be moved out from the `psn` supergroup into its own, without breaking any readability considerations. Take then the following grouping: `psn` => `{ psn fix | psn rescan }` `check` => `{ check updates | check content }` The commands are suddenly much shorter, but still hold the same meaning, while also retaining their sentence-like feel. Whilst thinking about more reasons to recreate the `check` token as a standalone command group, my attention turned towards the `!ird` command. You for sure *check* for an `.ird`, and it is pretty fitting all things considered. And so while we're at it, I also recommend moving the `ird` command group below the `check` group as follows: `psn` => `{ psn fix | psn rescan }` `check` => `{ check updates | check content | check ird }` This will need all the related `help` and `explain` commands to be updated too, of course.

yindo added the questionable label 2026-02-15 15:54:46 -05:00

yindo closed this issue

2026-02-15 15:54:46 -05:00

yindo commented

2026-02-15 15:54:46 -05:00

@dio-gh commented on GitHub (Oct 3, 2021):

Slash commands take care of the command names being too long, and I disagree with the laid out schema by now.

@dio-gh commented on GitHub (Oct 3, 2021): Slash commands take care of the command names being too long, and I disagree with the laid out schema by now.

yindo referenced this issue

2026-02-15 15:55:12 -05:00

[PR #38] [MERGED] Implement auto delete in #media and #bot-spam by reacting with coffee… #157

yindo changed title from ~~Regrouping a few commands~~ to [GH-ISSUE #182] Regrouping a few commands

2026-06-05 15:25:00 -04:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: RPCS3/discord-bot#38