mirror of
https://github.com/RPCS3/discord-bot.git
synced 2026-07-19 13:54:44 -04:00
[GH-ISSUE #193] Issues with bot reaction matching #41
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @JohnHolmesII on GitHub (Jan 29, 2019).
Original GitHub issue: https://github.com/RPCS3/discord-bot/issues/193
Some fuzzy matching rules seem to be applied to areas that really don't need it, leading to oddities. In particular, the bot will assume it is being discussed if anyone uses any word beginning with "bot", regardless of the word itself, including "bothered" or even "botasdf".
Test case "great botasdf"
In any case, this really just highlights that there should only be a subset of keywords to which fuzzy matching is applied. Cheers m8.
@13xforever commented on GitHub (Jan 30, 2019):
there's no fuzzy matching in that handler, only some tentative substring lookups, and it works as intended most of the time
even when it sometimes reacts unintentionally, it's still fine as bot just thinks you were nice, and everyone likes when bot likes them
I'm not sure making it perfect would be better from the fun side
@JohnHolmesII commented on GitHub (Jan 30, 2019):
Good to hear it's not fuzzy matching. That makes the whole thing much simpler. Just add a space or punctuation to the search string.
It's not about making it perfect at all, it's just that the 2 paragraphs I posted had nothing even remotely to do with the bot. It wasn't fun, it was just odd.
Importantly, nothing is stopping the bot from using its negative reactions either, which would be far more confusing.
Remember, this collision happened in reality, and confused the people who saw it happen. Not everything comes across as a charming accident.
Issues with bot reaction matchingto [GH-ISSUE #193] Issues with bot reaction matching