RPCS3/discord-bot
1
0
Fork 0
mirror of https://github.com/RPCS3/discord-bot.git synced 2026-07-19 13:54:44 -04:00
Code Issues 20 Packages Projects Releases Wiki Activity

[PR #356] [MERGED] Some quality of life updates #431

New Issue
Closed
opened 2026-02-15 15:55:56 -05:00 by yindo · 0 comments
yindo commented 2026-02-15 15:55:56 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/RPCS3/discord-bot/pull/356
Author: @13xforever
Created: 7/28/2019
Status: ✅ Merged
Merged: 7/28/2019
Merged by: @13xforever

Base: master ← Head: vnext

📝 Commits (9)

  • 1ed3912 Actually it worked, and was cleaner
  • a7a02b2 add a note for spu loop detection for p5
  • 9657596 check for header magic numbers instead of just file extensions
  • 737a7d4 remove reconnect on high ping, as it never happens in real life
  • faa766e allow duplicate triggers in filters
  • b448986 fix filter editor and migration script
  • dd0f85c update log parser to support new filter actions
  • 29a99c5 do not warn about disabled approximate xfloat for p5
  • 655f8e3 note about gow ascension

📊 Changes

26 files changed (+589 additions, -111 deletions)

View changed files

📝 Clients/CompatApiClient/Utils/Utils.cs (+3 -0)
📝 CompatBot/Commands/Antipiracy.cs (+33 -17)
📝 CompatBot/Database/BotDb.cs (+1 -1)
➕ CompatBot/Database/Migrations/BotDb/20190728111050_AllowDuplicateTriggers.Designer.cs (+289 -0)
➕ CompatBot/Database/Migrations/BotDb/20190728111050_AllowDuplicateTriggers.cs (+32 -0)
📝 CompatBot/Database/Migrations/BotDb/BotDbModelSnapshot.cs (+0 -1)
📝 CompatBot/Database/Providers/ContentFilter.cs (+32 -4)
📝 CompatBot/EventHandlers/LogParsing/ArchiveHandlers/GzipHandler.cs (+12 -3)
📝 CompatBot/EventHandlers/LogParsing/ArchiveHandlers/IArchiveHandler.cs (+1 -1)
📝 CompatBot/EventHandlers/LogParsing/ArchiveHandlers/PlainText.cs (+6 -5)
📝 CompatBot/EventHandlers/LogParsing/ArchiveHandlers/RarHandler.cs (+16 -7)
📝 CompatBot/EventHandlers/LogParsing/ArchiveHandlers/SevenZipHandler.cs (+12 -6)
📝 CompatBot/EventHandlers/LogParsing/ArchiveHandlers/ZipHandler.cs (+17 -7)
📝 CompatBot/EventHandlers/LogParsing/LogParser.LogSections.cs (+11 -3)
📝 CompatBot/EventHandlers/LogParsing/POCOs/LogParseState.cs (+6 -4)
📝 CompatBot/EventHandlers/LogParsing/SourceHandlers/BaseSourceHandler.cs (+1 -1)
📝 CompatBot/EventHandlers/LogParsing/SourceHandlers/DiscordAttachmentHandler.cs (+9 -4)
📝 CompatBot/EventHandlers/LogParsing/SourceHandlers/DropboxHandler.cs (+11 -6)
📝 CompatBot/EventHandlers/LogParsing/SourceHandlers/GoogleDriveHandler.cs (+13 -8)
📝 CompatBot/EventHandlers/LogParsing/SourceHandlers/ISourceHandler.cs (+1 -1)

...and 6 more files

📄 Description

  • Allow multiple filters with the same trigger
    • It is still required to be unique per filter context
  • Detect log archive format through the magic bytes in the header whenever possible
  • Multiple log note updates

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/RPCS3/discord-bot/pull/356 **Author:** [@13xforever](https://github.com/13xforever) **Created:** 7/28/2019 **Status:** ✅ Merged **Merged:** 7/28/2019 **Merged by:** [@13xforever](https://github.com/13xforever) **Base:** `master` ← **Head:** `vnext` --- ### 📝 Commits (9) - [`1ed3912`](https://github.com/RPCS3/discord-bot/commit/1ed3912b5830d70f1ae5ef9704e618d93ac96d19) Actually it worked, and was cleaner - [`a7a02b2`](https://github.com/RPCS3/discord-bot/commit/a7a02b2083cf4b41fbcbb526843cc2f13d713b20) add a note for spu loop detection for p5 - [`9657596`](https://github.com/RPCS3/discord-bot/commit/96575962369715035fa486908e0bd4d1e3b27945) check for header magic numbers instead of just file extensions - [`737a7d4`](https://github.com/RPCS3/discord-bot/commit/737a7d4869bbfeb4e2c2447f1253a7c3ee96f6f4) remove reconnect on high ping, as it never happens in real life - [`faa766e`](https://github.com/RPCS3/discord-bot/commit/faa766eb72994c20182d325101a6a6d34f7e0e16) allow duplicate triggers in filters - [`b448986`](https://github.com/RPCS3/discord-bot/commit/b448986415ff12505035167ff29e461ee4bd6db9) fix filter editor and migration script - [`dd0f85c`](https://github.com/RPCS3/discord-bot/commit/dd0f85cdb696182a7624064570502f1c7749c022) update log parser to support new filter actions - [`29a99c5`](https://github.com/RPCS3/discord-bot/commit/29a99c561975adbab08802bfc2ded5fa5f5d3a9f) do not warn about disabled approximate xfloat for p5 - [`655f8e3`](https://github.com/RPCS3/discord-bot/commit/655f8e388d1ed5946fa92f559937efbdbdbc2902) note about gow ascension ### 📊 Changes **26 files changed** (+589 additions, -111 deletions) <details> <summary>View changed files</summary> 📝 `Clients/CompatApiClient/Utils/Utils.cs` (+3 -0) 📝 `CompatBot/Commands/Antipiracy.cs` (+33 -17) 📝 `CompatBot/Database/BotDb.cs` (+1 -1) ➕ `CompatBot/Database/Migrations/BotDb/20190728111050_AllowDuplicateTriggers.Designer.cs` (+289 -0) ➕ `CompatBot/Database/Migrations/BotDb/20190728111050_AllowDuplicateTriggers.cs` (+32 -0) 📝 `CompatBot/Database/Migrations/BotDb/BotDbModelSnapshot.cs` (+0 -1) 📝 `CompatBot/Database/Providers/ContentFilter.cs` (+32 -4) 📝 `CompatBot/EventHandlers/LogParsing/ArchiveHandlers/GzipHandler.cs` (+12 -3) 📝 `CompatBot/EventHandlers/LogParsing/ArchiveHandlers/IArchiveHandler.cs` (+1 -1) 📝 `CompatBot/EventHandlers/LogParsing/ArchiveHandlers/PlainText.cs` (+6 -5) 📝 `CompatBot/EventHandlers/LogParsing/ArchiveHandlers/RarHandler.cs` (+16 -7) 📝 `CompatBot/EventHandlers/LogParsing/ArchiveHandlers/SevenZipHandler.cs` (+12 -6) 📝 `CompatBot/EventHandlers/LogParsing/ArchiveHandlers/ZipHandler.cs` (+17 -7) 📝 `CompatBot/EventHandlers/LogParsing/LogParser.LogSections.cs` (+11 -3) 📝 `CompatBot/EventHandlers/LogParsing/POCOs/LogParseState.cs` (+6 -4) 📝 `CompatBot/EventHandlers/LogParsing/SourceHandlers/BaseSourceHandler.cs` (+1 -1) 📝 `CompatBot/EventHandlers/LogParsing/SourceHandlers/DiscordAttachmentHandler.cs` (+9 -4) 📝 `CompatBot/EventHandlers/LogParsing/SourceHandlers/DropboxHandler.cs` (+11 -6) 📝 `CompatBot/EventHandlers/LogParsing/SourceHandlers/GoogleDriveHandler.cs` (+13 -8) 📝 `CompatBot/EventHandlers/LogParsing/SourceHandlers/ISourceHandler.cs` (+1 -1) _...and 6 more files_ </details> ### 📄 Description * Allow multiple filters with the same trigger * It is still required to be unique per filter context * Detect log archive format through the magic bytes in the header whenever possible * Multiple log note updates --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-15 15:55:56 -05:00
yindo closed this issue 2026-02-15 15:55:56 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Hacktoberfest
Hacktoberfest
bug
enhancement
enhancement
enhancement
fun stuff
good first issue
good first issue
help wanted
high priority
invalid
log analyzer
pull-request
Mirrored from GitHub Pull Request
 questionable
questionable
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: RPCS3/discord-bot#431
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?