[PR #396] [MERGED] Changes to "JoJo's Bizarre Adventure: All Star Battle" recommended settings #470

Closed
opened 2026-02-15 15:56:02 -05:00 by yindo · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/RPCS3/discord-bot/pull/396
Author: @mosamadeeb
Created: 8/29/2019
Status: Merged
Merged: 8/29/2019
Merged by: @13xforever

Base: masterHead: jojo


📝 Commits (8)

  • 59278c4 Remove "Missing health bars are random".
  • 566ba53 Add new LogParser item: "audio_buffer_duration".
  • 974bc36 Change recommended audio settings to "Enable Buffering" and "20ms" Buffer Duration.
  • ee96066 revert broken command line changes
  • d477c25 Add new LogParser item: "audio_buffer_duration"
  • 0fe5e5f Change recommended audio settings
  • c17f27d Change recommended audio settings
  • 605b934 Update audio buffering check, as suggested

📊 Changes

3 files changed (+14 additions, -7 deletions)

View changed files

📝 CompatBot/EventHandlers/LogParsing/LogParser.LogSections.cs (+2 -1)
📝 CompatBot/Utils/ResultFormatters/LogParserResultFormatter.GeneralNotesSection.cs (+0 -2)
📝 CompatBot/Utils/ResultFormatters/LogParserResultFormatter.WeirdSettingsSection.cs (+12 -4)

📄 Description

Removed the message about missing health bars, fixed in rpcs3 PR #6415. Changed audio preference to buffering enabled with duration set to 20ms; had to add an "audio_buffer_duration" item to the log parser.

Please ignore the duplicated commits, notepad++ broke my formatting.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/RPCS3/discord-bot/pull/396 **Author:** [@mosamadeeb](https://github.com/mosamadeeb) **Created:** 8/29/2019 **Status:** ✅ Merged **Merged:** 8/29/2019 **Merged by:** [@13xforever](https://github.com/13xforever) **Base:** `master` ← **Head:** `jojo` --- ### 📝 Commits (8) - [`59278c4`](https://github.com/RPCS3/discord-bot/commit/59278c491318b6226015cc814bf250e34c5c99de) Remove "Missing health bars are random". - [`566ba53`](https://github.com/RPCS3/discord-bot/commit/566ba53efea31b2bf0049b27b628c0ddcfef497f) Add new LogParser item: "audio_buffer_duration". - [`974bc36`](https://github.com/RPCS3/discord-bot/commit/974bc36573361b60312793b170d18f99cfa86c05) Change recommended audio settings to "Enable Buffering" and "20ms" Buffer Duration. - [`ee96066`](https://github.com/RPCS3/discord-bot/commit/ee96066be17ec6a0c99146e65b20ee9aabc70eb4) revert broken command line changes - [`d477c25`](https://github.com/RPCS3/discord-bot/commit/d477c25b2f03c8fcf397fc2242cc40e1c0035e9f) Add new LogParser item: "audio_buffer_duration" - [`0fe5e5f`](https://github.com/RPCS3/discord-bot/commit/0fe5e5fbc291608d99eb937e243f94fd74f2cbe6) Change recommended audio settings - [`c17f27d`](https://github.com/RPCS3/discord-bot/commit/c17f27d840e721b0121f888369d686780f5bd808) Change recommended audio settings - [`605b934`](https://github.com/RPCS3/discord-bot/commit/605b9340a216dfd41657f97c31467a509240a095) Update audio buffering check, as suggested ### 📊 Changes **3 files changed** (+14 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `CompatBot/EventHandlers/LogParsing/LogParser.LogSections.cs` (+2 -1) 📝 `CompatBot/Utils/ResultFormatters/LogParserResultFormatter.GeneralNotesSection.cs` (+0 -2) 📝 `CompatBot/Utils/ResultFormatters/LogParserResultFormatter.WeirdSettingsSection.cs` (+12 -4) </details> ### 📄 Description Removed the message about missing health bars, fixed in rpcs3 PR #6415. Changed audio preference to buffering enabled with duration set to 20ms; had to add an "audio_buffer_duration" item to the log parser. Please ignore the duplicated commits, notepad++ broke my formatting. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-15 15:56:02 -05:00
yindo closed this issue 2026-02-15 15:56:02 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: RPCS3/discord-bot#470