mirror of
https://github.com/RPCS3/discord-bot.git
synced 2026-07-19 13:54:44 -04:00
[PR #396] [MERGED] Changes to "JoJo's Bizarre Adventure: All Star Battle" recommended settings #470
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/RPCS3/discord-bot/pull/396
Author: @mosamadeeb
Created: 8/29/2019
Status: ✅ Merged
Merged: 8/29/2019
Merged by: @13xforever
Base:
master← Head:jojo📝 Commits (8)
59278c4Remove "Missing health bars are random".566ba53Add new LogParser item: "audio_buffer_duration".974bc36Change recommended audio settings to "Enable Buffering" and "20ms" Buffer Duration.ee96066revert broken command line changesd477c25Add new LogParser item: "audio_buffer_duration"0fe5e5fChange recommended audio settingsc17f27dChange recommended audio settings605b934Update audio buffering check, as suggested📊 Changes
3 files changed (+14 additions, -7 deletions)
View changed files
📝
CompatBot/EventHandlers/LogParsing/LogParser.LogSections.cs(+2 -1)📝
CompatBot/Utils/ResultFormatters/LogParserResultFormatter.GeneralNotesSection.cs(+0 -2)📝
CompatBot/Utils/ResultFormatters/LogParserResultFormatter.WeirdSettingsSection.cs(+12 -4)📄 Description
Removed the message about missing health bars, fixed in rpcs3 PR #6415. Changed audio preference to buffering enabled with duration set to 20ms; had to add an "audio_buffer_duration" item to the log parser.
Please ignore the duplicated commits, notepad++ broke my formatting.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.