[GH-ISSUE #420] Replace custom GitHub client with official GraphQL one #50

New Issue

2026-02-15T15:54:48-05:00

yindo commented

2026-02-15 15:54:48 -05:00

Originally created by @13xforever on GitHub (Oct 5, 2019).
Original GitHub issue: https://github.com/RPCS3/discord-bot/issues/420

Originally assigned to: @grantwinney on GitHub.

Right now we're using a tiny custom-built client that is using older REST API version. It would be nice to migrate to a properly supported official client. This would also help in the future if we'll have to use authentication for increased request limits.

Originally created by @13xforever on GitHub (Oct 5, 2019). Original GitHub issue: https://github.com/RPCS3/discord-bot/issues/420 Originally assigned to: @grantwinney on GitHub. Right now we're using a tiny custom-built client that is using older REST API version. It would be nice to migrate to a properly supported official client. This would also help in the future if we'll have to use authentication for increased request limits.

yindo added the questionable label 2026-02-15 15:54:48 -05:00

yindo closed this issue

2026-02-15 15:54:48 -05:00

yindo commented

2026-02-15 15:54:48 -05:00

@grantwinney commented on GitHub (Oct 10, 2019):

I'd like to have a go at this. There's the official octokit.net library, which seems fairly established and I imagine is built on REST. Then there's the official octokit.graphql.net package, which should be great one day, but...

This software is currently beta. There are few things left, and there might be bugs - be warned!

Would you like someone to look into migrating to one of these, or did you have something else in mind?

@grantwinney commented on GitHub (Oct 10, 2019): I'd like to have a go at this. There's the official [octokit.net](https://github.com/octokit/octokit.net) library, which seems fairly established and I imagine is built on REST. Then there's the official [octokit.graphql.net](https://github.com/octokit/octokit.graphql.net) package, which should be great one day, but... > This software is currently beta. There are few things left, and there might be bugs - be warned! Would you like someone to look into migrating to one of these, or did you have something else in mind?

yindo commented

2026-02-15 15:54:48 -05:00

@grantwinney commented on GitHub (Oct 10, 2019):

If you decide to go with the octokit.net library, would you want to use the PullRequest class (for example) that they define, or translate it into your existing PrInfo class?

@grantwinney commented on GitHub (Oct 10, 2019): If you decide to go with the octokit.net library, would you want to use the `PullRequest` class (for example) that they define, or translate it into your existing `PrInfo` class?

yindo commented

2026-02-15 15:54:48 -05:00

@grantwinney commented on GitHub (Oct 11, 2019):

I made a PR, which at least can be a discussion point. It could technically be merged, but there are issues that should probably be addressed first. Let me know what you think, and I'll understand if it's not the direction you want to go.

I'm in the process of trying to learn more about GraphQL in general, and GitHub's in particular since it seems they've got the most mature and well documented implementation around, but it's unfortunate their .NET client is still beta.

@grantwinney commented on GitHub (Oct 11, 2019): I made a PR, which at least can be a discussion point. It could _technically_ be merged, but there are issues that should probably be addressed first. Let me know what you think, and I'll understand if it's not the direction you want to go. I'm in the process of trying to learn more about GraphQL in general, and GitHub's in particular since it seems they've got the most mature and well documented implementation around, but it's unfortunate their .NET client is still beta.

yindo commented

2026-02-15 15:54:48 -05:00

@13xforever commented on GitHub (Oct 11, 2019):

I'd prefer to migrate to official GraphQL client, even if it's in beta (half of the libraries we use are beta anyway).
There's no point in keeping our custom pocos, there shouldn't be too many places that would require to change the code (but that could be discussed if converting is easier).

I'll look at the pr in a few hours.

@13xforever commented on GitHub (Oct 11, 2019): I'd prefer to migrate to official GraphQL client, even if it's in beta (half of the libraries we use are beta anyway). There's no point in keeping our custom pocos, there shouldn't be too many places that would require to change the code (but that could be discussed if converting is easier). I'll look at the pr in a few hours.

yindo commented

2026-02-15 15:54:48 -05:00

@grantwinney commented on GitHub (Oct 22, 2019):

I'm still here btw. I have some of the replacement done, but I'm not sure their GraphQL NuGet package can replace everything. Maybe I'll submit a draft PR in the next day or two so at least you'll have something to look at.

@grantwinney commented on GitHub (Oct 22, 2019): I'm still here btw. I have _some_ of the replacement done, but I'm not sure their GraphQL NuGet package can replace everything. Maybe I'll submit a draft PR in the next day or two so at least you'll have something to look at.

yindo referenced this issue

2026-06-05 15:24:49 -04:00

[GH-ISSUE #50] [Feature Request] Let compatbot highlight if the user uses an outdated build #1

yindo changed title from ~~Replace custom GitHub client with official GraphQL one~~ to [GH-ISSUE #420] Replace custom GitHub client with official GraphQL one

2026-06-05 15:25:04 -04:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: RPCS3/discord-bot#50