[PR #437] [CLOSED] Implementing GraphQL API for accessing GitHub data #507

Closed
opened 2026-02-15 15:56:09 -05:00 by yindo · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/RPCS3/discord-bot/pull/437
Author: @grantwinney
Created: 10/24/2019
Status: Closed

Base: masterHead: refactor_to_use_graphql


📝 Commits (1)

  • 9b38fb8 begin work on using graphql for accessing github

📊 Changes

7 files changed (+163 additions, -219 deletions)

View changed files

📝 Clients/GithubClient/Client.cs (+65 -121)
📝 Clients/GithubClient/GithubClient.csproj (+1 -0)
📝 Clients/GithubClient/POCOs/PrInfo.cs (+43 -43)
📝 Clients/GithubClient/POCOs/StatusInfo.cs (+9 -9)
📝 CompatBot/Commands/Pr.cs (+10 -11)
📝 CompatBot/Utils/ResultFormatters/PrInfoFormatter.cs (+24 -24)
📝 CompatBot/Utils/ResultFormatters/UpdateInfoFormatter.cs (+11 -11)

📄 Description

I wanted to get this "out there" so others could look at it. It's not a complete solution yet, but at least it's a start for addressing https://github.com/RPCS3/discord-bot/issues/420:

  • I haven't fully refactored GetStatusesAsync in Client.cs or LinkPrBuild in Pr.cs yet. I'm not quite sure where to get the necessary info from or whether there's a official GitHub object to match the StatusInfo class.
  • I think the GraphQL API requires an OAUTH token now, whereas the queries were anonymous before. If that's true, then it'll be possible to make a greater amount of queries, but I'm not sure what the best way is to get an OAUTH token into the program.
  • For now, I've simply commented out the built-in POCOs like PrInfo, IssueInfo, etc.
  • This won't compile as-is, so the build and tests will fail. It's really just to get feedback about what's been done so far.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/RPCS3/discord-bot/pull/437 **Author:** [@grantwinney](https://github.com/grantwinney) **Created:** 10/24/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `refactor_to_use_graphql` --- ### 📝 Commits (1) - [`9b38fb8`](https://github.com/RPCS3/discord-bot/commit/9b38fb8a903663fa29c715fa9e11c6a790ca1b9b) begin work on using graphql for accessing github ### 📊 Changes **7 files changed** (+163 additions, -219 deletions) <details> <summary>View changed files</summary> 📝 `Clients/GithubClient/Client.cs` (+65 -121) 📝 `Clients/GithubClient/GithubClient.csproj` (+1 -0) 📝 `Clients/GithubClient/POCOs/PrInfo.cs` (+43 -43) 📝 `Clients/GithubClient/POCOs/StatusInfo.cs` (+9 -9) 📝 `CompatBot/Commands/Pr.cs` (+10 -11) 📝 `CompatBot/Utils/ResultFormatters/PrInfoFormatter.cs` (+24 -24) 📝 `CompatBot/Utils/ResultFormatters/UpdateInfoFormatter.cs` (+11 -11) </details> ### 📄 Description I wanted to get this "out there" so others could look at it. It's not a complete solution yet, but at least it's a start for addressing https://github.com/RPCS3/discord-bot/issues/420: - I haven't fully refactored `GetStatusesAsync` in Client.cs or `LinkPrBuild` in Pr.cs yet. I'm not quite sure where to get the necessary info from or whether there's a official GitHub object to match the `StatusInfo` class. - I _think_ the GraphQL API requires an OAUTH token now, whereas the queries were anonymous before. If that's true, then it'll be possible to make a greater amount of queries, but I'm not sure what the best way is to get an OAUTH token into the program. - For now, I've simply commented out the built-in POCOs like `PrInfo`, `IssueInfo`, etc. - This won't compile as-is, so the build and tests will fail. It's really just to get feedback about what's been done so far. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-15 15:56:09 -05:00
yindo closed this issue 2026-02-15 15:56:09 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: RPCS3/discord-bot#507