[GH-ISSUE #753] Add compile-time check for CheckBaseAttributes being used with GroupCommandAttribute #67

New Issue

2026-02-15T15:54:51-05:00

yindo commented

2026-02-15 15:54:51 -05:00

Originally created by @13xforever on GitHub (Apr 30, 2021).
Original GitHub issue: https://github.com/RPCS3/discord-bot/issues/753

Originally assigned to: @13xforever on GitHub.

Unlike CommandAttribute, GroupCommandAttribute does not preserve check attributes when building the command list, so all checks will be siltently ignored. This is a big issue for security checks.

We already have source generators hooked up, just need to write a roslyn analyzer and throw an error to prevent this happenning in the future.

Originally created by @13xforever on GitHub (Apr 30, 2021). Original GitHub issue: https://github.com/RPCS3/discord-bot/issues/753 Originally assigned to: @13xforever on GitHub. Unlike `CommandAttribute`, `GroupCommandAttribute` does not preserve check attributes when building the command list, so all checks will be siltently ignored. This is a big issue for security checks. We already have source generators hooked up, just need to write a roslyn analyzer and throw an error to prevent this happenning in the future.

yindo added the enhancement help wanted labels 2026-02-15 15:54:51 -05:00

yindo closed this issue

2026-02-15 15:54:51 -05:00

yindo referenced this issue

2026-02-15 15:55:16 -05:00

[PR #67] [MERGED] A new round of fixes #183

yindo changed title from ~~Add compile-time check for CheckBaseAttributes being used with GroupCommandAttribute~~ to [GH-ISSUE #753] Add compile-time check for CheckBaseAttributes being used with GroupCommandAttribute

2026-06-05 15:25:09 -04:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: RPCS3/discord-bot#67