RPCS3/discord-bot
1
0
Fork 0
mirror of https://github.com/RPCS3/discord-bot.git synced 2026-07-19 03:15:42 -04:00
Code Issues 20 Packages Projects Releases Wiki Activity

[PR #672] [MERGED] Migrate to .NET 5 #736

New Issue
Closed
opened 2026-02-15 15:56:45 -05:00 by yindo · 0 comments
yindo commented 2026-02-15 15:56:45 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/RPCS3/discord-bot/pull/672
Author: @13xforever
Created: 11/10/2020
Status: ✅ Merged
Merged: 11/15/2020
Merged by: @13xforever

Base: master ← Head: dotnet5

📝 Commits (10+)

  • de9f0f4 add argument validation to !ird
  • c8cf1d3 fix compilation warnings
  • 65b56c3 switch to net5 target
  • ce4af4d update CI and docker scripts
  • ea879c8 fix some unicode-related issues after migration
  • 133eb1f fix another compiler warning
  • a0a7c3a fix global suppression for an update signature
  • dbe868f ugh docker images were moved for .net 5
  • 11f8261 apparently netstandard target is no more, just like netcore
  • 158cf18 fix more compiler complaints

📊 Changes

198 files changed (+3703 additions, -3479 deletions)

View changed files

📝 Clients/CompatApiClient/ApiConfig.cs (+13 -9)
📝 Clients/CompatApiClient/Client.cs (+23 -18)
📝 Clients/CompatApiClient/CompatApiClient.csproj (+3 -3)
📝 Clients/CompatApiClient/Compression/CompressedContent.cs (+6 -18)
📝 Clients/CompatApiClient/Compression/CompressionMessageHandler.cs (+24 -37)
📝 Clients/CompatApiClient/Compression/Compressor.cs (+6 -6)
📝 Clients/CompatApiClient/Compression/DecompressedContent.cs (+6 -18)
📝 Clients/CompatApiClient/Compression/DeflateCompressor.cs (+4 -8)
📝 Clients/CompatApiClient/Compression/GZipCompressor.cs (+4 -8)
➕ Clients/CompatApiClient/Formatters/DashedNamingPolicy.cs (+9 -0)
➖ Clients/CompatApiClient/Formatters/JsonContractResolver.cs (+0 -32)
📝 Clients/CompatApiClient/Formatters/NamingStyles.cs (+1 -1)
➕ Clients/CompatApiClient/Formatters/SnakeCaseNamingPolicy.cs (+9 -0)
➕ Clients/CompatApiClient/Formatters/SpecialJsonNamingPolicy.cs (+8 -0)
📝 Clients/CompatApiClient/POCOs/CompatResult.cs (+11 -7)
📝 Clients/CompatApiClient/POCOs/UpdateInfo.cs (+4 -0)
📝 Clients/CompatApiClient/RequestBuilder.cs (+9 -90)
📝 Clients/CompatApiClient/Utils/ConsoleLogger.cs (+2 -2)
📝 Clients/CompatApiClient/Utils/UriExtensions.cs (+12 -9)
📝 Clients/CompatApiClient/Utils/Utils.cs (+5 -7)

...and 80 more files

📄 Description

  • retarget all projects to net5.0
  • update dotnet libraries to 5.0.0
  • migrate from json.net to System.Text.Json
  • enable nullable reference types on all projects
  • update pattern matching and other language constructs with C# 9 where appropriate
  • general code cleanup to fix compiler, new roslyn analyzer, and resharper warnings and suggestions

Here's log parsing improvement from the new regex engine in .net 5 (times in seconds):
Log parsing performance tests

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/RPCS3/discord-bot/pull/672 **Author:** [@13xforever](https://github.com/13xforever) **Created:** 11/10/2020 **Status:** ✅ Merged **Merged:** 11/15/2020 **Merged by:** [@13xforever](https://github.com/13xforever) **Base:** `master` ← **Head:** `dotnet5` --- ### 📝 Commits (10+) - [`de9f0f4`](https://github.com/RPCS3/discord-bot/commit/de9f0f4a12679f8945a0c9209f194ac898d36c5a) add argument validation to !ird - [`c8cf1d3`](https://github.com/RPCS3/discord-bot/commit/c8cf1d3a8541997d2ac7d664db3226f26004bd9d) fix compilation warnings - [`65b56c3`](https://github.com/RPCS3/discord-bot/commit/65b56c3f3bd2ad984ba32a51322a37a36d64ba5e) switch to net5 target - [`ce4af4d`](https://github.com/RPCS3/discord-bot/commit/ce4af4da300abbab41c31dcee0b482a52f76c005) update CI and docker scripts - [`ea879c8`](https://github.com/RPCS3/discord-bot/commit/ea879c8653ad9d1e4f16f0b081da32c25a7d224b) fix some unicode-related issues after migration - [`133eb1f`](https://github.com/RPCS3/discord-bot/commit/133eb1f9c10ddc8a526aa9361797dfedadea04a4) fix another compiler warning - [`a0a7c3a`](https://github.com/RPCS3/discord-bot/commit/a0a7c3a46ff0ac973a579471b2d47b8de6b52d80) fix global suppression for an update signature - [`dbe868f`](https://github.com/RPCS3/discord-bot/commit/dbe868f31dc50015dc41c778c8a8c686fb9631ab) ugh docker images were moved for .net 5 - [`11f8261`](https://github.com/RPCS3/discord-bot/commit/11f826122fd11ee7882ce6c07a2efe4627f120d6) apparently netstandard target is no more, just like netcore - [`158cf18`](https://github.com/RPCS3/discord-bot/commit/158cf18bd1bff7f919b7b2fb99250ac7df2afc26) fix more compiler complaints ### 📊 Changes **198 files changed** (+3703 additions, -3479 deletions) <details> <summary>View changed files</summary> 📝 `Clients/CompatApiClient/ApiConfig.cs` (+13 -9) 📝 `Clients/CompatApiClient/Client.cs` (+23 -18) 📝 `Clients/CompatApiClient/CompatApiClient.csproj` (+3 -3) 📝 `Clients/CompatApiClient/Compression/CompressedContent.cs` (+6 -18) 📝 `Clients/CompatApiClient/Compression/CompressionMessageHandler.cs` (+24 -37) 📝 `Clients/CompatApiClient/Compression/Compressor.cs` (+6 -6) 📝 `Clients/CompatApiClient/Compression/DecompressedContent.cs` (+6 -18) 📝 `Clients/CompatApiClient/Compression/DeflateCompressor.cs` (+4 -8) 📝 `Clients/CompatApiClient/Compression/GZipCompressor.cs` (+4 -8) ➕ `Clients/CompatApiClient/Formatters/DashedNamingPolicy.cs` (+9 -0) ➖ `Clients/CompatApiClient/Formatters/JsonContractResolver.cs` (+0 -32) 📝 `Clients/CompatApiClient/Formatters/NamingStyles.cs` (+1 -1) ➕ `Clients/CompatApiClient/Formatters/SnakeCaseNamingPolicy.cs` (+9 -0) ➕ `Clients/CompatApiClient/Formatters/SpecialJsonNamingPolicy.cs` (+8 -0) 📝 `Clients/CompatApiClient/POCOs/CompatResult.cs` (+11 -7) 📝 `Clients/CompatApiClient/POCOs/UpdateInfo.cs` (+4 -0) 📝 `Clients/CompatApiClient/RequestBuilder.cs` (+9 -90) 📝 `Clients/CompatApiClient/Utils/ConsoleLogger.cs` (+2 -2) 📝 `Clients/CompatApiClient/Utils/UriExtensions.cs` (+12 -9) 📝 `Clients/CompatApiClient/Utils/Utils.cs` (+5 -7) _...and 80 more files_ </details> ### 📄 Description * retarget all projects to `net5.0` * update dotnet libraries to 5.0.0 * migrate from json.net to `System.Text.Json` * enable nullable reference types on all projects * update pattern matching and other language constructs with C# 9 where appropriate * general code cleanup to fix compiler, new roslyn analyzer, and resharper warnings and suggestions Here's log parsing improvement from the new regex engine in .net 5 (times in seconds): ![Log parsing performance tests](https://user-images.githubusercontent.com/36445/99088339-bdfec780-25ed-11eb-9365-594a26c12d34.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-15 15:56:45 -05:00
yindo closed this issue 2026-02-15 15:56:45 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Hacktoberfest
Hacktoberfest
bug
enhancement
enhancement
enhancement
fun stuff
good first issue
good first issue
help wanted
high priority
invalid
log analyzer
pull-request
Mirrored from GitHub Pull Request
 questionable
questionable
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: RPCS3/discord-bot#736
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?