[PR #675] [MERGED] Workaround the bug that was unmasked after moving to new json serializer #737

New Issue

2026-02-15T15:56:45-05:00

yindo commented

2026-02-15 15:56:45 -05:00

📋 Pull Request Information

Original PR: https://github.com/RPCS3/discord-bot/pull/675
Author: @13xforever
Created: 11/17/2020
Status: ✅ Merged
Merged: 11/17/2020
Merged by: @13xforever

Base: master ← Head: vnext

📝 Commits (1)

3f5f2ed add workaround for invalid json value type in commit hash

📊 Changes

3 files changed (+30 additions, -2 deletions)

View changed files

📝 Clients/CompatApiClient/Client.cs (+1 -0)
➕ Clients/CompatApiClient/Formatters/CompatApiCommitHashConverter.cs (+26 -0)
📝 CompatBot/EventHandlers/ProductCodeLookup.cs (+3 -2)

📄 Description

and try to show cached data when there's an error communicating with compat api

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/RPCS3/discord-bot/pull/675 **Author:** [@13xforever](https://github.com/13xforever) **Created:** 11/17/2020 **Status:** ✅ Merged **Merged:** 11/17/2020 **Merged by:** [@13xforever](https://github.com/13xforever) **Base:** `master` ← **Head:** `vnext` --- ### 📝 Commits (1) - [`3f5f2ed`](https://github.com/RPCS3/discord-bot/commit/3f5f2ed2edbd1d3c64372b03b83dc99ac7062240) add workaround for invalid json value type in commit hash ### 📊 Changes **3 files changed** (+30 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `Clients/CompatApiClient/Client.cs` (+1 -0) ➕ `Clients/CompatApiClient/Formatters/CompatApiCommitHashConverter.cs` (+26 -0) 📝 `CompatBot/EventHandlers/ProductCodeLookup.cs` (+3 -2) </details> ### 📄 Description and try to show cached data when there's an error communicating with compat api --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

yindo added the pull-request label 2026-02-15 15:56:45 -05:00

yindo closed this issue

2026-02-15 15:56:45 -05:00

yindo referenced this issue

2026-02-15 15:56:53 -05:00

[PR #737] [MERGED] Maintenance #791

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: RPCS3/discord-bot#737