mirror of
https://github.com/RPCS3/discord-bot.git
synced 2026-07-19 13:54:44 -04:00
[GH-ISSUE #860] Linking/Referencing merged PR's should link to old master build when the PR merged rather than latest #91
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Asinin3 on GitHub (May 5, 2022).
Original GitHub issue: https://github.com/RPCS3/discord-bot/issues/860
Currently, when you mention a old PR via URL or

#PRNumberthe download links go to the latest master build of RPCS3, instead of the master build when the PR merged.I would like this to change to instead link to the build when the PR merged, and have a warning about how it is an older build. To improve upon this, there could be a link to the master build directly BEFORE the mentioned PR merged. So you could link e.g #11607 and get a link to when the Surface Cache PR merged, and the build directly before it. Saving tons of time searching the build history page.
Closes #814
@Darkhost1999 commented on GitHub (Jul 28, 2022):
Still an annoying issue that created problems in help too. I remember this linking to https://api.cirrus-ci.com/v1/artifact/task/4562251708366848/Artifact/rpcs3-v0.0.23-13cec72b_win64.7z or the applicable PR in the past. Maybe thats just me though confusing merged and unmerged PRs
@13xforever commented on GitHub (Dec 6, 2022):
Binaries were always linked to the current master build
@13xforever commented on GitHub (Dec 6, 2022):
I don't want randoms looking for old pr numbers to get old builds, so default behavior will stay as it is now.
But in case someone wants to link old build on purpose, I've implemented
!pr link XXXcommand that will link old build.Linking/Referencing merged PR's should link to old master build when the PR merged rather than latestto [GH-ISSUE #860] Linking/Referencing merged PR's should link to old master build when the PR merged rather than latest