[PR #929] [MERGED] Code cleanup #949

New Issue

2026-02-15T15:57:18-05:00

yindo commented

2026-02-15 15:57:18 -05:00

📋 Pull Request Information

Original PR: https://github.com/RPCS3/discord-bot/pull/929
Author: @13xforever
Created: 4/20/2023
Status: ✅ Merged
Merged: 4/21/2023
Merged by: @clienthax

Base: master ← Head: vnext

📝 Commits (6)

4d261df silence new roslyn warning
0d99046 increase default attachment size to 25 MB
d957936 update code with new language and api features
ec31006 update piracy warning text
055a35d fix some commands to be usable in DMs
fd76899 update 3rd party deps

📊 Changes

102 files changed (+737 additions, -775 deletions)

View changed files

📝 Clients/CirrusCiClient/CirrusCi.cs (+1 -2)
📝 Clients/CompatApiClient/ApiConfig.cs (+2 -2)
📝 Clients/CompatApiClient/Compression/CompressionMessageHandler.cs (+1 -2)
📝 Clients/CompatApiClient/Formatters/CompatApiCommitHashConverter.cs (+5 -10)
📝 Clients/CompatApiClient/Formatters/NamingStyles.cs (+2 -9)
📝 Clients/CompatApiClient/Utils/Statistics.cs (+4 -3)
📝 Clients/CompatApiClient/Utils/UriExtensions.cs (+6 -12)
📝 Clients/CompatApiClient/Utils/Utils.cs (+7 -9)
📝 Clients/GithubClient/Client.cs (+34 -55)
📝 Clients/IrdLibraryClient/IrdClient.cs (+4 -5)
📝 Clients/PsnClient/PsnClient.cs (+13 -12)
📝 Clients/YandexDiskClient/Client.cs (+2 -2)
📝 CompatBot/Commands/Attributes/LimitedToSpamChannel.cs (+1 -2)
📝 CompatBot/Commands/Attributes/RequiresBotModRole.cs (+1 -3)
📝 CompatBot/Commands/Attributes/RequiresNotMedia.cs (+1 -3)
📝 CompatBot/Commands/Attributes/RequiresSupporterRole.cs (+1 -3)
📝 CompatBot/Commands/Attributes/RequiresWhitelistedRole.cs (+1 -3)
📝 CompatBot/Commands/Attributes/TriggersTyping.cs (+1 -3)
📝 CompatBot/Commands/BaseApplicationCommandModuleCustom.cs (+1 -2)
📝 CompatBot/Commands/BotMath.cs (+5 -2)

...and 80 more files

📄 Description

changed some bot messages to use markdown now that it's supported
updated some parts to use newer syntax and pattern matching
updated default settings for attachment size
increased the number of RAM tiers in !hw stats
added external annotations for resharper/rider to help with bot commands analysis

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/RPCS3/discord-bot/pull/929 **Author:** [@13xforever](https://github.com/13xforever) **Created:** 4/20/2023 **Status:** ✅ Merged **Merged:** 4/21/2023 **Merged by:** [@clienthax](https://github.com/clienthax) **Base:** `master` ← **Head:** `vnext` --- ### 📝 Commits (6) - [`4d261df`](https://github.com/RPCS3/discord-bot/commit/4d261df3a385e1a4776d79a6244aa76e84f7b17b) silence new roslyn warning - [`0d99046`](https://github.com/RPCS3/discord-bot/commit/0d99046a0b58fcecd8ff1dc5befb2dbaff10267b) increase default attachment size to 25 MB - [`d957936`](https://github.com/RPCS3/discord-bot/commit/d957936edea056d0d9bcb448d5bbf2a72b76b528) update code with new language and api features - [`ec31006`](https://github.com/RPCS3/discord-bot/commit/ec3100679cd19b7a5c66c63e6d981ae8979dbec8) update piracy warning text - [`055a35d`](https://github.com/RPCS3/discord-bot/commit/055a35d211b949b551f291aeaa2deb0cd07523fe) fix some commands to be usable in DMs - [`fd76899`](https://github.com/RPCS3/discord-bot/commit/fd7689968797da31d275b0fc74fc8f8e86419999) update 3rd party deps ### 📊 Changes **102 files changed** (+737 additions, -775 deletions) <details> <summary>View changed files</summary> 📝 `Clients/CirrusCiClient/CirrusCi.cs` (+1 -2) 📝 `Clients/CompatApiClient/ApiConfig.cs` (+2 -2) 📝 `Clients/CompatApiClient/Compression/CompressionMessageHandler.cs` (+1 -2) 📝 `Clients/CompatApiClient/Formatters/CompatApiCommitHashConverter.cs` (+5 -10) 📝 `Clients/CompatApiClient/Formatters/NamingStyles.cs` (+2 -9) 📝 `Clients/CompatApiClient/Utils/Statistics.cs` (+4 -3) 📝 `Clients/CompatApiClient/Utils/UriExtensions.cs` (+6 -12) 📝 `Clients/CompatApiClient/Utils/Utils.cs` (+7 -9) 📝 `Clients/GithubClient/Client.cs` (+34 -55) 📝 `Clients/IrdLibraryClient/IrdClient.cs` (+4 -5) 📝 `Clients/PsnClient/PsnClient.cs` (+13 -12) 📝 `Clients/YandexDiskClient/Client.cs` (+2 -2) 📝 `CompatBot/Commands/Attributes/LimitedToSpamChannel.cs` (+1 -2) 📝 `CompatBot/Commands/Attributes/RequiresBotModRole.cs` (+1 -3) 📝 `CompatBot/Commands/Attributes/RequiresNotMedia.cs` (+1 -3) 📝 `CompatBot/Commands/Attributes/RequiresSupporterRole.cs` (+1 -3) 📝 `CompatBot/Commands/Attributes/RequiresWhitelistedRole.cs` (+1 -3) 📝 `CompatBot/Commands/Attributes/TriggersTyping.cs` (+1 -3) 📝 `CompatBot/Commands/BaseApplicationCommandModuleCustom.cs` (+1 -2) 📝 `CompatBot/Commands/BotMath.cs` (+5 -2) _...and 80 more files_ </details> ### 📄 Description * changed some bot messages to use markdown now that it's supported * updated some parts to use newer syntax and pattern matching * updated default settings for attachment size * increased the number of RAM tiers in `!hw` stats * added external annotations for resharper/rider to help with bot commands analysis --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

yindo added the pull-request label 2026-02-15 15:57:18 -05:00

yindo closed this issue

2026-02-15 15:57:19 -05:00

yindo referenced this issue

2026-02-15 15:57:20 -05:00

[PR #949] [MERGED] Maintenance #960

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: RPCS3/discord-bot#949