[PR #955] [MERGED] Some performance and code optimizations #964

Closed
opened 2026-02-15 15:57:21 -05:00 by yindo · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/RPCS3/discord-bot/pull/955
Author: @13xforever
Created: 5/18/2024
Status: Merged
Merged: 5/18/2024
Merged by: @clienthax

Base: masterHead: vnext


📝 Commits (8)

  • f5c0e87 upgrade deps, remove wrong ppu hashes
  • 1302e84 upgrade compiler packages
  • ebb0543 replace Regex with compiler-generated versions
  • 94014be use new collection initialization syntax
  • 4a05fc8 configure global defaults for regex
  • a55e64d bump min amd driver version
  • f572886 add macos version check
  • 4f39a05 fix #954 (!sudo log date)

📊 Changes

83 files changed (+1058 additions, -640 deletions)

View changed files

📝 Clients/CirrusCiClient/CirrusCiClient.csproj (+1 -1)
📝 Clients/CompatApiClient/ApiConfig.cs (+5 -5)
📝 Clients/CompatApiClient/CompatApiClient.csproj (+1 -1)
📝 Clients/CompatApiClient/Compression/CompressionMessageHandler.cs (+1 -1)
📝 Clients/GithubClient/GithubClient.csproj (+1 -1)
📝 Clients/IrdLibraryClient/IrdClient.cs (+0 -1)
📝 Clients/IrdLibraryClient/IrdLibraryClient.csproj (+1 -1)
📝 Clients/MediafireClient/Client.cs (+4 -3)
📝 Clients/PsnClient/PsnClient.cs (+16 -12)
📝 Clients/PsnClient/Utils/TmdbHasher.cs (+1 -1)
📝 CompatBot/Commands/BotStats.cs (+3 -3)
📝 CompatBot/Commands/CompatList.cs (+10 -10)
📝 CompatBot/Commands/ContentFilters.cs (+14 -5)
📝 CompatBot/Commands/Converters/TextOnlyDiscordChannelConverter.cs (+5 -4)
📝 CompatBot/Commands/EventsBaseCommand.cs (+5 -4)
📝 CompatBot/Commands/Explain.cs (+2 -1)
📝 CompatBot/Commands/ForcedNicknames.cs (+2 -2)
📝 CompatBot/Commands/Minesweeper.cs (+3 -3)
📝 CompatBot/Commands/Misc.cs (+28 -26)
📝 CompatBot/Commands/Psn.Check.cs (+5 -4)

...and 63 more files

📄 Description

  • Replaced most Regex usages to compile-time generated implementation to improve startup and runtime performance
  • Replaced collection initialization with new C# syntax (compile-time initialization optimizations)
  • Added global Regex configuration for pattern cache size to improve content filters performance
  • Fixed some issues and upgraded 3rd party packages

Will require fresh container pull after build if using Docker.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/RPCS3/discord-bot/pull/955 **Author:** [@13xforever](https://github.com/13xforever) **Created:** 5/18/2024 **Status:** ✅ Merged **Merged:** 5/18/2024 **Merged by:** [@clienthax](https://github.com/clienthax) **Base:** `master` ← **Head:** `vnext` --- ### 📝 Commits (8) - [`f5c0e87`](https://github.com/RPCS3/discord-bot/commit/f5c0e8784506c5a7bbf83e65a3898470432edd38) upgrade deps, remove wrong ppu hashes - [`1302e84`](https://github.com/RPCS3/discord-bot/commit/1302e84508fd634cae06b57a571223cc5a8dcbb7) upgrade compiler packages - [`ebb0543`](https://github.com/RPCS3/discord-bot/commit/ebb05438ddcabaffd1e2d96730850f8f8ae5840c) replace Regex with compiler-generated versions - [`94014be`](https://github.com/RPCS3/discord-bot/commit/94014bebf3277cff3cb2fec2b4c7654053d212f9) use new collection initialization syntax - [`4a05fc8`](https://github.com/RPCS3/discord-bot/commit/4a05fc8a1267449e6ff59ce78e65ed57365190e7) configure global defaults for regex - [`a55e64d`](https://github.com/RPCS3/discord-bot/commit/a55e64db0cf4d1cddadd353ca1cb409ef724bd56) bump min amd driver version - [`f572886`](https://github.com/RPCS3/discord-bot/commit/f572886b46ee20984170813c68542ae074c07824) add macos version check - [`4f39a05`](https://github.com/RPCS3/discord-bot/commit/4f39a059ffd8b4c491602a026b137140941641e3) fix #954 (!sudo log date) ### 📊 Changes **83 files changed** (+1058 additions, -640 deletions) <details> <summary>View changed files</summary> 📝 `Clients/CirrusCiClient/CirrusCiClient.csproj` (+1 -1) 📝 `Clients/CompatApiClient/ApiConfig.cs` (+5 -5) 📝 `Clients/CompatApiClient/CompatApiClient.csproj` (+1 -1) 📝 `Clients/CompatApiClient/Compression/CompressionMessageHandler.cs` (+1 -1) 📝 `Clients/GithubClient/GithubClient.csproj` (+1 -1) 📝 `Clients/IrdLibraryClient/IrdClient.cs` (+0 -1) 📝 `Clients/IrdLibraryClient/IrdLibraryClient.csproj` (+1 -1) 📝 `Clients/MediafireClient/Client.cs` (+4 -3) 📝 `Clients/PsnClient/PsnClient.cs` (+16 -12) 📝 `Clients/PsnClient/Utils/TmdbHasher.cs` (+1 -1) 📝 `CompatBot/Commands/BotStats.cs` (+3 -3) 📝 `CompatBot/Commands/CompatList.cs` (+10 -10) 📝 `CompatBot/Commands/ContentFilters.cs` (+14 -5) 📝 `CompatBot/Commands/Converters/TextOnlyDiscordChannelConverter.cs` (+5 -4) 📝 `CompatBot/Commands/EventsBaseCommand.cs` (+5 -4) 📝 `CompatBot/Commands/Explain.cs` (+2 -1) 📝 `CompatBot/Commands/ForcedNicknames.cs` (+2 -2) 📝 `CompatBot/Commands/Minesweeper.cs` (+3 -3) 📝 `CompatBot/Commands/Misc.cs` (+28 -26) 📝 `CompatBot/Commands/Psn.Check.cs` (+5 -4) _...and 63 more files_ </details> ### 📄 Description * Replaced most Regex usages to compile-time generated implementation to improve startup and runtime performance * Replaced collection initialization with new C# syntax (compile-time initialization optimizations) * Added global Regex configuration for pattern cache size to improve content filters performance * Fixed some issues and upgraded 3rd party packages Will require fresh container pull after build if using Docker. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-15 15:57:21 -05:00
yindo closed this issue 2026-02-15 15:57:21 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: RPCS3/discord-bot#964