[PR #970] [MERGED] Properly escape ird download links without corrupting relative paths #977

New Issue

2026-02-15T15:57:23-05:00

yindo commented

2026-02-15 15:57:23 -05:00

📋 Pull Request Information

Original PR: https://github.com/RPCS3/discord-bot/pull/970
Author: @13xforever
Created: 2/7/2025
Status: ✅ Merged
Merged: 2/7/2025
Merged by: @clienthax

Base: master ← Head: vnext

📝 Commits (1)

ff880f6 properly escape ird download links without corrupting relative paths

📊 Changes

3 files changed (+34 additions, -5 deletions)

View changed files

📝 Clients/IrdLibraryClient/IrdClient.cs (+9 -4)
📝 CompatBot/Utils/ResultFormatters/IrdSearchResultFormatter.cs (+1 -1)
➕ Tests/UriFormattingTests.cs (+24 -0)

📄 Description

Initial implementation was breaking discord link formatting, and the attempted fix broke links with relative paths.
This version should fix both cases, and comes with some tests for known issues.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/RPCS3/discord-bot/pull/970 **Author:** [@13xforever](https://github.com/13xforever) **Created:** 2/7/2025 **Status:** ✅ Merged **Merged:** 2/7/2025 **Merged by:** [@clienthax](https://github.com/clienthax) **Base:** `master` ← **Head:** `vnext` --- ### 📝 Commits (1) - [`ff880f6`](https://github.com/RPCS3/discord-bot/commit/ff880f60017f63136bf55b24f6686f46e60d14d6) properly escape ird download links without corrupting relative paths ### 📊 Changes **3 files changed** (+34 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `Clients/IrdLibraryClient/IrdClient.cs` (+9 -4) 📝 `CompatBot/Utils/ResultFormatters/IrdSearchResultFormatter.cs` (+1 -1) ➕ `Tests/UriFormattingTests.cs` (+24 -0) </details> ### 📄 Description Initial implementation was breaking discord link formatting, and the attempted fix broke links with relative paths. This version should fix both cases, and comes with some tests for known issues. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

yindo added the pull-request label 2026-02-15 15:57:23 -05:00

yindo closed this issue

2026-02-15 15:57:23 -05:00

yindo referenced this issue

2026-02-15 15:57:24 -05:00

[PR #977] [MERGED] Try to fix dead bot issue in one new case #982

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: RPCS3/discord-bot#977