RPCS3/discord-bot
1
0
Fork 0
mirror of https://github.com/RPCS3/discord-bot.git synced 2026-07-19 13:54:44 -04:00
Code Issues 20 Packages Projects Releases Wiki Activity

[PR #989] [MERGED] Another batch of fixes and improvements #996

New Issue
Closed
opened 2026-02-15 15:57:26 -05:00 by yindo · 0 comments
yindo commented 2026-02-15 15:57:26 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/RPCS3/discord-bot/pull/989
Author: @13xforever
Created: 3/29/2025
Status: ✅ Merged
Merged: 3/29/2025
Merged by: @13xforever

Base: master ← Head: vnext

📝 Commits (6)

  • 67398ce more ValueTask updates
  • 48fb3fc fix all the places where database is actually open for modification
  • de504ea add db open logs to debug build
  • d5683f3 fix potential issues with overlapping database scopes
  • 4f8e4c4 replace windows-only dependencies with imagesharp code
  • 114532a apparently you can't defer when using modal response

📊 Changes

44 files changed (+575 additions, -432 deletions)

View changed files

📝 Clients/CompatApiClient/Client.cs (+4 -3)
📝 CompatBot/Commands/Bot.Configuration.cs (+8 -8)
📝 CompatBot/Commands/Bot.cs (+23 -20)
📝 CompatBot/Commands/CompatList.Latest.cs (+18 -12)
📝 CompatBot/Commands/CompatList.cs (+13 -13)
📝 CompatBot/Commands/ContentFilters.cs (+107 -92)
📝 CompatBot/Commands/Events.cs (+12 -12)
📝 CompatBot/Commands/Explain.cs (+14 -14)
📝 CompatBot/Commands/ForcedNicknames.cs (+9 -9)
📝 CompatBot/Commands/Fortune.cs (+14 -11)
📝 CompatBot/Commands/Invites.cs (+3 -3)
📝 CompatBot/Commands/Psn.Check.cs (+4 -4)
📝 CompatBot/Commands/Psn.cs (+7 -7)
📝 CompatBot/Commands/Sudo.Fix.cs (+12 -12)
📝 CompatBot/Commands/Syscall.cs (+4 -4)
📝 CompatBot/Commands/Vision.cs (+0 -1)
📝 CompatBot/Commands/Warnings.cs (+40 -28)
📝 CompatBot/CompatBot.csproj (+0 -2)
📝 CompatBot/Database/BotDb.cs (+35 -6)
📝 CompatBot/Database/DbImporter.cs (+9 -9)

...and 24 more files

📄 Description

  • Updated all instances of opening sqlite databases for modification
  • Fixed some potential issues with overlapped open/close database contexts
  • Removed two windows native dependencies
  • Fixed editing explains

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/RPCS3/discord-bot/pull/989 **Author:** [@13xforever](https://github.com/13xforever) **Created:** 3/29/2025 **Status:** ✅ Merged **Merged:** 3/29/2025 **Merged by:** [@13xforever](https://github.com/13xforever) **Base:** `master` ← **Head:** `vnext` --- ### 📝 Commits (6) - [`67398ce`](https://github.com/RPCS3/discord-bot/commit/67398ce5804dd8d05959f255dfdee3af23b53e1a) more ValueTask updates - [`48fb3fc`](https://github.com/RPCS3/discord-bot/commit/48fb3fcd5bcc8025672d8a72cfc38ffde92beb53) fix all the places where database is actually open for modification - [`de504ea`](https://github.com/RPCS3/discord-bot/commit/de504ea9b482bc2133417354b6ceb71a8d81e902) add db open logs to debug build - [`d5683f3`](https://github.com/RPCS3/discord-bot/commit/d5683f3a3fef5045f9ed5cd976e251650d82fd7e) fix potential issues with overlapping database scopes - [`4f8e4c4`](https://github.com/RPCS3/discord-bot/commit/4f8e4c467b6324460d60de3c350b979f36c7e34b) replace windows-only dependencies with imagesharp code - [`114532a`](https://github.com/RPCS3/discord-bot/commit/114532a487dc9acbb3054b4f93d41a5517a795fd) apparently you can't defer when using modal response ### 📊 Changes **44 files changed** (+575 additions, -432 deletions) <details> <summary>View changed files</summary> 📝 `Clients/CompatApiClient/Client.cs` (+4 -3) 📝 `CompatBot/Commands/Bot.Configuration.cs` (+8 -8) 📝 `CompatBot/Commands/Bot.cs` (+23 -20) 📝 `CompatBot/Commands/CompatList.Latest.cs` (+18 -12) 📝 `CompatBot/Commands/CompatList.cs` (+13 -13) 📝 `CompatBot/Commands/ContentFilters.cs` (+107 -92) 📝 `CompatBot/Commands/Events.cs` (+12 -12) 📝 `CompatBot/Commands/Explain.cs` (+14 -14) 📝 `CompatBot/Commands/ForcedNicknames.cs` (+9 -9) 📝 `CompatBot/Commands/Fortune.cs` (+14 -11) 📝 `CompatBot/Commands/Invites.cs` (+3 -3) 📝 `CompatBot/Commands/Psn.Check.cs` (+4 -4) 📝 `CompatBot/Commands/Psn.cs` (+7 -7) 📝 `CompatBot/Commands/Sudo.Fix.cs` (+12 -12) 📝 `CompatBot/Commands/Syscall.cs` (+4 -4) 📝 `CompatBot/Commands/Vision.cs` (+0 -1) 📝 `CompatBot/Commands/Warnings.cs` (+40 -28) 📝 `CompatBot/CompatBot.csproj` (+0 -2) 📝 `CompatBot/Database/BotDb.cs` (+35 -6) 📝 `CompatBot/Database/DbImporter.cs` (+9 -9) _...and 24 more files_ </details> ### 📄 Description * Updated all instances of opening sqlite databases for modification * Fixed some potential issues with overlapped open/close database contexts * Removed two windows native dependencies * Fixed editing explains --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-15 15:57:26 -05:00
yindo closed this issue 2026-02-15 15:57:26 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Hacktoberfest
Hacktoberfest
bug
enhancement
enhancement
enhancement
fun stuff
good first issue
good first issue
help wanted
high priority
invalid
log analyzer
pull-request
Mirrored from GitHub Pull Request
 questionable
questionable
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: RPCS3/discord-bot#996
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?