From 591651da3dbfa9741252a1f0be72bf6799ae094a Mon Sep 17 00:00:00 2001 From: Ben Clayton Date: Tue, 23 Mar 2021 10:47:59 +0000 Subject: [PATCH] Fix warnings about int comparisons of different signness Warnings in public headers can trigger warnings-as-errors. --- glslang/Include/Types.h | 2 +- gtests/VkRelaxed.FromFile.cpp | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/glslang/Include/Types.h b/glslang/Include/Types.h index 04250843..202e6935 100644 --- a/glslang/Include/Types.h +++ b/glslang/Include/Types.h @@ -2376,7 +2376,7 @@ public: return false; // Compare the names and types of all the members, which have to match - for (int li = 0, ri = 0; li < structure->size() || ri < right.structure->size(); ++li, ++ri) { + for (size_t li = 0, ri = 0; li < structure->size() || ri < right.structure->size(); ++li, ++ri) { if (li < structure->size() && ri < right.structure->size()) { if ((*structure)[li].type->getFieldName() == (*right.structure)[ri].type->getFieldName()) { if (*(*structure)[li].type != *(*right.structure)[ri].type) diff --git a/gtests/VkRelaxed.FromFile.cpp b/gtests/VkRelaxed.FromFile.cpp index 32e3c29b..777134d9 100644 --- a/gtests/VkRelaxed.FromFile.cpp +++ b/gtests/VkRelaxed.FromFile.cpp @@ -234,7 +234,7 @@ TEST_P(VulkanRelaxedTest, FromFile) if (!resourceSetBindings.empty()) { assert(resourceSetBindings.size() == fileNames.size()); - for (int i = 0; i < shaders.size(); i++) + for (size_t i = 0; i < shaders.size(); i++) shaders[i]->setResourceSetBinding(resourceSetBindings[i]); } @@ -302,4 +302,4 @@ INSTANTIATE_TEST_SUITE_P( } // anonymous namespace } // namespace glslangtest -#endif \ No newline at end of file +#endif