Commit Graph

4679 Commits

Author SHA1 Message Date
sfricke-samsung
610fd6edf3
Prevent Push Constant blocks being an array (#2904)
* Prevent Push Constant blocks being an array

* Add push constant array error test

Co-authored-by: Greg Fischer <greg@lunarg.com>
2022-03-23 11:42:21 -06:00
Greg Fischer
c6f8e532dd
Merge pull request #2902 from ZhiqianXia/gl_FragCoord
The first redeclarations of gl_FragCoord must appear before any use.
2022-03-21 12:03:34 -06:00
Biswapriyo Nath
e80f2f8760
cmake: Install SPVRemapper runtime library
This installs SPVRemapper.dll file which was missing previously.
2022-03-15 19:26:57 +05:30
Alexey Panteleev
d44871ca08 Escape the characters that Make considers special in the dependency files. 2022-03-11 17:56:15 -08:00
ZhiqianXia
07f677028c The first redeclarations of gl_FragCoord must appear before any
use of gl_FragCoord.
2022-03-11 14:42:11 +08:00
Greg Fischer
538231d8b4
Merge pull request #2897 from ZhiqianXia/origin_upper_left
Fix the issue for GL_ARB_fragment_coord_conventions extension.
2022-03-01 14:50:55 -07:00
ZhiqianXia
438999d24f 1. refine the check for "origin_upper_left" and "pixel_center_integer"
2. gl_FragCoord can be used at ogl140 with extension "GL_ARB_fragment_coord_conventions".




Signed-off-by: ZhiqianXia <xzq0528@outlook.com>
2022-03-01 15:06:04 +08:00
Greg Fischer
43d585d863
Merge pull request #2895 from greg-lunarg/i2894
Don't do updatePrecision on float16_t operations
2022-02-24 17:57:22 -07:00
Greg Fischer
79a35ace7c Don't do updatePrecision on float16_t operations
float16_t does not take GLSL precisions and SPIR-V does not
support RelaxedPrecision on float16_t.

Fixes #2894
2022-02-24 15:03:13 -07:00
Greg Fischer
ac7f6a293e
Merge pull request #2892 from greg-lunarg/mb
Improve error message for image/sampler functions under enhanced-msgs
2022-02-23 16:34:36 -07:00
Greg Fischer
bbe692e731 Improve error message for image/sampler functions for enhanced-msgs
For recent GLSL versions, if texture2D function call appears, the error
message reports an unsupported type constructor. Change message to
unsupported function. Likewise for other removed texture* function calls.
2022-02-23 15:55:49 -07:00
Greg Fischer
d15deba1d8
Merge pull request #2891 from dneto0/hlsl-namespace
Fix Test/hlsl.namespace.frag test case
2022-02-16 16:15:20 -07:00
David Neto
63dbacaa94 Fix Test/hlsl.namespace.frag test case
Before this change, the example is rejected by DXC:

$ dxc -T ps_6_0 hlsl.namespace.frag
hlsl.namespace.frag:22:73: error: call to non-static member function
without an object argument
    return N1::getVec() + N2::getVec() + N2::N3::getVec() + N2::N3::C1::getVec() * N2::gf;
                                                                ~~~~~~~~~~~~^~~~~~

The call to the class member function requires an object, or we ned to
make the function static.  This update makes the function static.

This also fixes SPIR-V validation: without this change the call
to that getVec does not have enough arguments:

error: line 69: OpFunctionCall Function <id>'s parameter count does not
match the argument count.
  %43 = OpFunctionCall %v4float %N2__N3__C1__getVec_
2022-02-16 17:17:08 -05:00
Greg Fischer
90d4bd05cd
Merge pull request #2888 from mrpippy/python3
Explicitly use Python 3 for scripts
2022-02-10 14:16:44 -07:00
Greg Fischer
cf02eda7ca
Merge pull request #2887 from mbechard/master
avoid leaving decorations on auto-push-constants
2022-02-10 11:57:37 -07:00
Brendan Shanks
25555a7f62 Explicitly use Python 3 for scripts 2022-02-10 09:36:50 -08:00
Malcolm Bechard
be202ef9ba avoid leaving decorations on auto-push-constants
uniform blocks that are upgraded to push_constants shouldn't have
set/binding etc. decorations applied to them
2022-02-09 18:44:22 -05:00
Greg Fischer
b7ba87bcfe
Merge pull request #2886 from greg-lunarg/i2875
Fix sameElementShape test of sampler
2022-02-07 13:09:13 -07:00
Greg Fischer
c5072a8cab Fix sameElementShape test of sampler
There is apparently a hole in the initialization of sampler in TType
so that a simple comparison which should pass might fail. Until the
hole is found, also test that both types are samplers before comparing
the sampler field for equality.

Fixes #2875
2022-02-07 12:15:31 -07:00
Greg Fischer
2742e95934
Merge pull request #2885 from greg-lunarg/kg121
Update spirv-tools known good
2022-02-03 09:26:44 -07:00
Greg Fischer
acd4425a29 Update spirv-tools known good
Picking up some spirv-tools bug fixes
2022-02-02 18:37:43 -07:00
Greg Fischer
16e3b403aa
Merge pull request #2883 from greg-lunarg/link2
Enhance readability of error messages for GLSL
2022-02-01 15:47:19 -07:00
Greg Fischer
3005da6e6e
Merge pull request #2874 from mbechard/master
fix cases where symbols in the tree didn't get updated during block merging
2022-02-01 15:46:25 -07:00
Greg Fischer
ca0d54d51b Enhance readability of error messages for GLSL
Specifically, make GLSL link error messages more specific and output
only information relevant to the error.

Also change type printing to more closely reflect GLSL syntax. This
is the default for link error messages, but must me enabled with the
new option --enhanced-msgs for compilation error messages.

Also with --enhanced-msgs, only emit one error message per source
line.
2022-02-01 12:10:08 -07:00
Malcolm Bechard
b8338311ea fix cases where symbols in the tree didn't get updated during block merging
For GL_EXT_vulkan_glsl_relaxed. When merging the default uniform block,
there were cases where symbols in the tree wern't updated to match the
new block structure after merging blocks together.

This change traverses the symbol tree and updates any references to the
merged block.
2022-01-28 23:38:56 -05:00
Greg Fischer
c34bb3b6c5
Merge pull request #2879 from greg-lunarg/vulkan-1.3-B
Release 11.8.0
2022-01-27 13:21:18 -07:00
Greg Fischer
9448de56b3 Release 11.8.0 2022-01-27 12:23:47 -07:00
Greg Fischer
a7aae72ef4
Merge pull request #2878 from greg-lunarg/vulkan-1.3-A
Fix size_t to int warning
2022-01-27 12:13:43 -07:00
Greg Fischer
69565b1884 Fix size_t to int warning 2022-01-27 11:51:04 -07:00
Greg Fischer
1978f2b383
Merge pull request #2876 from greg-lunarg/vulkan-1.3
Add Vulkan 1.3 support
2022-01-27 10:09:36 -07:00
Greg Fischer
9ebd8ff6c1 Add Vulkan 1.3 support
Also update known goods to Vulkan 1.3 support
Also re-enable SPIR-V 1.6 tests with vulkan1.3 target
Also re-cache SPIRV 1.6 header which somehow regressed back to 1.5
2022-01-26 17:57:31 -07:00
Greg Fischer
81cc10a498
Merge pull request #2873 from greg-lunarg/i2872
Fix comment for setEnvInput()
2022-01-25 17:44:03 -07:00
Greg Fischer
ed5f33e6ac Fix comment for setEnvInput()
Specifically, add text to clarify dialect and dialectVersion

Fixes #2872
2022-01-25 13:40:07 -07:00
Greg Fischer
6624e13673
Merge pull request #2852 from gnoliyil/fuchsia
build: Make action targets hermetic
2022-01-13 14:36:29 -07:00
Greg Fischer
0108966b47
Merge pull request #2868 from ben-clayton/patch-1
Update LICENSE.txt
2022-01-13 14:35:16 -07:00
Ben Clayton
d465ac12dd
Update LICENSE.txt
Expand the GPL 3 with special bison exception to the fully expanded license.

Required for Google's updated license checker.
2022-01-13 12:14:34 +00:00
Greg Fischer
43d40e80ad
Merge pull request #2866 from greg-lunarg/i2858
Temporarily disable spirv1.6 tests
2022-01-11 14:36:01 -07:00
Greg Fischer
140a76a447 Temporarily disable spirv1.6 tests
These tests will be re-enabled when a Vulkan version is released that
supports spirv1.6.

Fixes #2858
2022-01-11 13:13:50 -07:00
Greg Fischer
109b31aaa2
Merge pull request #2862 from n-morales/2861-macos-gcc-build-failures
#2861 macos gcc build failures
2022-01-11 11:42:11 -07:00
Nicolas Morales
ab87ffe7cf #2861: If compiling with macOS and GCC, default ENABLE_PCH to false since CMake will generate incompatible Xarch flags for the precompiled headers 2022-01-11 11:41:44 +01:00
Nicolas Morales
66ac0df61b #2861: Check for macOS systems before adding "--no-undefined" to linker flags as it is not compatible with the default linker. 2022-01-11 11:41:44 +01:00
Greg Fischer
57e25195eb
Merge pull request #2853 from ZhiqianXia/EndStreamPrimitive
EndStreamPrimitive not supported when there is #extension GL_ARB_gpu_shader5
2022-01-10 13:04:15 -07:00
Greg Fischer
b886419027
Merge pull request #2864 from scribam/cmake-install-prefix
Override CMAKE_INSTALL_PREFIX only if ENABLE_GLSLANG_INSTALL is ON
2022-01-10 12:27:51 -07:00
Greg Fischer
364b169807
Merge branch 'master' into EndStreamPrimitive 2022-01-10 11:49:19 -07:00
Greg Fischer
bd6e3fb78e
Merge pull request #2865 from alan-baker/update-license
Add missing license to LICENSE.txt
2022-01-10 11:15:41 -07:00
Alan Baker
5944f672a8 Add missing license to LICENSE.txt
* This license is used by:
  * SPIRV/GLSL.ext.AMD.h
  * SPIRV/GLSL.ext.EXT.h
  * SPIRV/GLSL.ext.KHR.h
  * SPIRV/GLSL.ext.NV.h
2022-01-10 10:38:49 -05:00
Hai Nguyen
8f2c400a29 Added missing test result 2022-01-10 09:56:54 -05:00
Hai Nguyen
6a3aeb73cd Added initial tests for --glsl-version
- Added compilation tests for shader stages using a different
  version at each stage.
2022-01-10 09:43:44 -05:00
scribam
f1cc215e55 Override CMAKE_INSTALL_PREFIX only if ENABLE_GLSLANG_INSTALL is ON 2022-01-09 22:30:11 +01:00
Greg Fischer
c0a322f5f0
Merge pull request #2859 from ZhiqianXia/floatBitsToInt
Support the floatBitsToint function at GL_ARB_gpu_shader5 Extension.
2022-01-07 14:38:42 -07:00