RPCS3/libpng
1
0
Fork 0
mirror of https://github.com/RPCS3/libpng.git synced 2026-07-25 04:26:38 -04:00
Code Issues Packages Projects Releases Wiki Activity

[PR #1] [MERGED] Fixes zlib for Qt branch #1

New Issue
Closed
opened 2026-02-15 15:54:23 -05:00 by yindo · 0 comments
yindo commented 2026-02-15 15:54:23 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/RPCS3/libpng/pull/1
Author: @flash-fire
Created: 4/26/2017
Status: ✅ Merged
Merged: 4/28/2017
Merged by: @undefined

Base: master ← Head: FixZLibForQt

📝 Commits (1)

  • 0918c9f Fixes zlib for qt. The macro z_solo breaks everything. Remove it. Then, I also changed the output directories to be more consistent with rpcs3.

📊 Changes

1 file changed (+5 additions, -2 deletions)

View changed files

📝 projects/vstudio/zlib/zlib.vcxproj (+5 -2)

📄 Description

Removed the Z_SOLO macro. I also changed the output directory to be more consistent with the other projects. (Note the default configuration for this library is DEBUG LIBRARY and not DEBUG, similarly with release. I changed that on my Qt branch to be simply DEBUG and RELEASE. But, that's a solution setting.)

This is required to have zlib work properly with opensource downloaded instead of using wxwidgets.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/RPCS3/libpng/pull/1 **Author:** [@flash-fire](https://github.com/flash-fire) **Created:** 4/26/2017 **Status:** ✅ Merged **Merged:** 4/28/2017 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `FixZLibForQt` --- ### 📝 Commits (1) - [`0918c9f`](https://github.com/RPCS3/libpng/commit/0918c9fbc40ee5bb1f8aada90e975178d79a949a) Fixes zlib for qt. The macro z_solo breaks everything. Remove it. Then, I also changed the output directories to be more consistent with rpcs3. ### 📊 Changes **1 file changed** (+5 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `projects/vstudio/zlib/zlib.vcxproj` (+5 -2) </details> ### 📄 Description Removed the Z_SOLO macro. I also changed the output directory to be more consistent with the other projects. (Note the default configuration for this library is DEBUG LIBRARY and not DEBUG, similarly with release. I changed that on my Qt branch to be simply DEBUG and RELEASE. But, that's a solution setting.) This is required to have zlib work properly with opensource downloaded instead of using wxwidgets. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-15 15:54:23 -05:00
yindo closed this issue 2026-02-15 15:54:23 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: RPCS3/libpng#1
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?