mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2025-02-27 15:57:30 +00:00
[InstCombine] add FIXME comment to shuffle transform; NFC
Existing tests: rG5d04e008f708 rG2a191cf8500f ...should verify that the underlying analysis doesn't improve too much without updating this user code.
This commit is contained in:
parent
0e9ab3b9f6
commit
06f90b77ee
@ -1701,6 +1701,9 @@ Instruction *InstCombiner::foldVectorBinop(BinaryOperator &Inst) {
|
||||
BO->getOpcode() != Opcode)
|
||||
return nullptr;
|
||||
|
||||
// FIXME: This may not be safe if the analysis allows undef elements. By
|
||||
// moving 'Y' before the splat shuffle, we are implicitly assuming
|
||||
// that it is not undef/poison at the splat index.
|
||||
Value *Y, *OtherOp;
|
||||
if (isSplatValue(BO->getOperand(0), SplatIndex->getZExtValue())) {
|
||||
Y = BO->getOperand(0);
|
||||
|
Loading…
x
Reference in New Issue
Block a user