From 1018faa8e70c2237521aea579ff38b4d8e79ee96 Mon Sep 17 00:00:00 2001 From: David Blaikie Date: Mon, 16 Sep 2019 23:54:57 +0000 Subject: [PATCH] llvm-reduce: Remove some string copies llvm-svn: 372053 --- tools/llvm-reduce/TestRunner.cpp | 21 ++------------------- tools/llvm-reduce/TestRunner.h | 9 +++------ 2 files changed, 5 insertions(+), 25 deletions(-) diff --git a/tools/llvm-reduce/TestRunner.cpp b/tools/llvm-reduce/TestRunner.cpp index 62600392527..d0e195d5697 100644 --- a/tools/llvm-reduce/TestRunner.cpp +++ b/tools/llvm-reduce/TestRunner.cpp @@ -10,25 +10,8 @@ using namespace llvm; -/// Gets Current Working Directory and tries to create a Tmp Directory -static SmallString<128> initializeTmpDirectory() { - SmallString<128> CWD; - if (std::error_code EC = sys::fs::current_path(CWD)) { - errs() << "Error getting current directory: " << EC.message() << "!\n"; - exit(1); - } - - SmallString<128> TmpDirectory; - sys::path::append(TmpDirectory, CWD, "tmp"); - if (std::error_code EC = sys::fs::create_directory(TmpDirectory)) - errs() << "Error creating tmp directory: " << EC.message() << "!\n"; - - return TmpDirectory; -} - -TestRunner::TestRunner(StringRef TestName, std::vector TestArgs) - : TestName(TestName), TestArgs(std::move(TestArgs)) { - TmpDirectory = initializeTmpDirectory(); +TestRunner::TestRunner(StringRef TestName, const std::vector &TestArgs) + : TestName(TestName), TestArgs(TestArgs) { } /// Runs the interestingness test, passes file to be tested as first argument diff --git a/tools/llvm-reduce/TestRunner.h b/tools/llvm-reduce/TestRunner.h index 35235e2adeb..2270d6bd90b 100644 --- a/tools/llvm-reduce/TestRunner.h +++ b/tools/llvm-reduce/TestRunner.h @@ -24,23 +24,20 @@ namespace llvm { // respective filename. class TestRunner { public: - TestRunner(StringRef TestName, std::vector TestArgs); + TestRunner(StringRef TestName, const std::vector &TestArgs); /// Runs the interesting-ness test for the specified file /// @returns 0 if test was successful, 1 if otherwise int run(StringRef Filename); - /// Directory where tmp files are created - StringRef getTmpDir() const { return TmpDirectory; } /// Returns the most reduced version of the original testcase Module *getProgram() const { return Program.get(); } void setProgram(std::unique_ptr P) { Program = std::move(P); } private: - SmallString<128> TestName; - std::vector TestArgs; - SmallString<128> TmpDirectory; + StringRef TestName; + const std::vector &TestArgs; std::unique_ptr Program; };