diff --git a/lib/IR/ConstantFold.cpp b/lib/IR/ConstantFold.cpp index 0da027f56fd..dc78c5537be 100644 --- a/lib/IR/ConstantFold.cpp +++ b/lib/IR/ConstantFold.cpp @@ -1840,7 +1840,7 @@ Constant *llvm::ConstantFoldCompareInstruction(unsigned short pred, Type *ResultTy; if (VectorType *VT = dyn_cast(C1->getType())) ResultTy = VectorType::get(Type::getInt1Ty(C1->getContext()), - VT->getNumElements()); + VT->getElementCount()); else ResultTy = Type::getInt1Ty(C1->getContext()); @@ -1971,6 +1971,11 @@ Constant *llvm::ConstantFoldCompareInstruction(unsigned short pred, R==APFloat::cmpEqual); } } else if (C1->getType()->isVectorTy()) { + // Do not iterate on scalable vector. The number of elements is unknown at + // compile-time. + if (C1->getType()->getVectorIsScalable()) + return nullptr; + // If we can constant fold the comparison of each element, constant fold // the whole vector comparison. SmallVector ResElts; diff --git a/lib/IR/Constants.cpp b/lib/IR/Constants.cpp index eb0e5894ae5..c609add1f12 100644 --- a/lib/IR/Constants.cpp +++ b/lib/IR/Constants.cpp @@ -2175,7 +2175,7 @@ Constant *ConstantExpr::getICmp(unsigned short pred, Constant *LHS, Type *ResultTy = Type::getInt1Ty(LHS->getContext()); if (VectorType *VT = dyn_cast(LHS->getType())) - ResultTy = VectorType::get(ResultTy, VT->getNumElements()); + ResultTy = VectorType::get(ResultTy, VT->getElementCount()); LLVMContextImpl *pImpl = LHS->getType()->getContext().pImpl; return pImpl->ExprConstants.getOrCreate(ResultTy, Key); @@ -2200,7 +2200,7 @@ Constant *ConstantExpr::getFCmp(unsigned short pred, Constant *LHS, Type *ResultTy = Type::getInt1Ty(LHS->getContext()); if (VectorType *VT = dyn_cast(LHS->getType())) - ResultTy = VectorType::get(ResultTy, VT->getNumElements()); + ResultTy = VectorType::get(ResultTy, VT->getElementCount()); LLVMContextImpl *pImpl = LHS->getType()->getContext().pImpl; return pImpl->ExprConstants.getOrCreate(ResultTy, Key); diff --git a/test/Analysis/ConstantFolding/vscale.ll b/test/Analysis/ConstantFolding/vscale.ll index 1616c70f200..f00e74bd14a 100644 --- a/test/Analysis/ConstantFolding/vscale.ll +++ b/test/Analysis/ConstantFolding/vscale.ll @@ -235,3 +235,51 @@ define @call() { %r = call @llvm.sadd.sat.nxv16i8( undef, undef) ret %r } + +define @icmp_undef() { +; CHECK-LABEL: @icmp_undef( +; CHECK-NEXT: ret undef +; + %r = icmp eq undef, undef + ret %r +} + +define @icmp_zero() { +; CHECK-LABEL: @icmp_zero( +; CHECK-NEXT: ret icmp eq ( zeroinitializer, zeroinitializer) +; + %r = icmp eq zeroinitializer, zeroinitializer + ret %r +} + +define @fcmp_true() { +; CHECK-LABEL: @fcmp_true( +; CHECK-NEXT: ret shufflevector ( insertelement ( undef, i1 true, i32 0), undef, zeroinitializer) +; + %r = fcmp true undef, undef + ret %r +} + +define @fcmp_false() { +; CHECK-LABEL: @fcmp_false( +; CHECK-NEXT: ret zeroinitializer +; + %r = fcmp false undef, undef + ret %r +} + +define @fcmp_undef() { +; CHECK-LABEL: @fcmp_undef( +; CHECK-NEXT: ret undef +; + %r = icmp ne undef, undef + ret %r +} + +define @fcmp_not_equality() { +; CHECK-LABEL: @fcmp_not_equality( +; CHECK-NEXT: ret shufflevector ( insertelement ( undef, i1 true, i32 0), undef, zeroinitializer) +; + %r = icmp ule undef, zeroinitializer + ret %r +}