RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-12-14 07:09:08 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

A bit more of gnu as compatibility when handling relocations with aliases.

Browse Source 
llvm-svn: 119328
This commit is contained in:
Rafael Espindola 2010-11-16 04:11:46 +00:00
parent 655c05147e
commit 47e7ef8c8f
2 changed files with 13 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/MC/ELFObjectWriter.cpp
View File

@ -1080,8 +1080,8 @@ bool ELFObjectWriter::IsFixupFullyResolved(const MCAssembler &Asm,
const MCSection *SectionA = 0;
const MCSymbol *SymbolA = 0;
if (const MCSymbolRefExpr *A = Target.getSymA()) {
SymbolA = &A->getSymbol().AliasedSymbol();
SectionA = &SymbolA->getSection();
SymbolA = &A->getSymbol();
SectionA = &SymbolA->AliasedSymbol().getSection();
}
const MCSection *SectionB = 0;
@ -1092,6 +1092,9 @@ bool ELFObjectWriter::IsFixupFullyResolved(const MCAssembler &Asm,
if (!BaseSection)
return SectionA == SectionB;
// FIXME: This is in here just to match gnu as output. If the two ends
// are in the same section, there is nothing that the linker can do to
// break it.
const MCSymbolData &DataA = Asm.getSymbolData(*SymbolA);
if (DataA.isExternal())
return false;

13
test/MC/ELF/relax.s
View File

@ -1,6 +1,6 @@
// RUN: llvm-mc -filetype=obj -triple x86_64-pc-linux-gnu %s -o - | elf-dump --dump-section-data | FileCheck %s
// Test that we do a relaxation for foo but not for bar. Relaxing foo is
// Test that we do a relaxation for foo but not for bar or zed. Relaxing foo is
// probably not necessary, but matches what gnu as does.
// Also test that the relaxation done for foo uses the symbol, not section and
@ -9,29 +9,32 @@
bar:
.globl foo
foo:
.set zed,foo
jmp bar
jmp foo
jmp zed
// CHECK: ('sh_name', 0x00000001) # '.text'
// CHECK-NEXT: ('sh_type', 0x00000001)
// CHECK-NEXT: ('sh_flags', 0x00000006)
// CHECK-NEXT: ('sh_addr', 0x00000000)
// CHECK-NEXT: ('sh_offset', 0x00000040)
// CHECK-NEXT: ('sh_size', 0x00000007)
// CHECK-NEXT: ('sh_size', 0x00000009)
// CHECK-NEXT: ('sh_link', 0x00000000)
// CHECK-NEXT: ('sh_info', 0x00000000)
// CHECK-NEXT: ('sh_addralign', 0x00000004)
// CHECK-NEXT: ('sh_entsize', 0x00000000)
// CHECK-NEXT: ('_section_data', 'ebfee900 000000')
// CHECK-NEXT: ('_section_data', 'ebfee900 000000eb f7')
// CHECK: # Symbol 0x00000005
// CHECK: # Symbol 0x00000006
// CHECK-NEXT: (('st_name', 0x00000005) # 'foo'
// CHECK: .rela.text
// CHECK: ('_relocations', [
// CHECK-NEXT: Relocation 0x00000000
// CHECK-NEXT: (('r_offset', 0x00000003)
// CHECK-NEXT: ('r_sym', 0x00000005)
// CHECK-NEXT: ('r_sym', 0x00000006)
// CHECK-NEXT: ('r_type', 0x00000002)
// CHECK-NEXT: ('r_addend', 0xfffffffc)
// CHECK-NEXT: ),