Improvements to emacs packages for llvm and tablegen mode.

* Both files have valid package headers and footers (you can verify
with M-x checkdoc).
* Fixed style warnings generated by checkdoc.
* Fixed a byte-compiler warning in llvm-mode.el.
* Ensure that the modes are autoloaded, so users do not need to
(require 'llvm-mode) to use them.

Patch by Wilfred Hughes.

llvm-svn: 225356
This commit is contained in:
Rafael Espindola 2015-01-07 15:52:51 +00:00
parent 58509c4247
commit 53f1be3911
2 changed files with 65 additions and 51 deletions

View File

@ -1,8 +1,13 @@
;; Maintainer: The LLVM team, http://llvm.org/
;; Description: Major mode for the LLVM assembler language.
;; Updated: 2007-09-19
;;; llvm-mode.el --- Major mode for the LLVM assembler language.
;; Maintainer: The LLVM team, http://llvm.org/
;;; Commentary:
;; Major mode for editing LLVM IR files.
;;; Code:
;; Create mode-specific tables.
(defvar llvm-mode-syntax-table nil
"Syntax table used while in LLVM mode.")
(defvar llvm-font-lock-keywords
@ -52,7 +57,7 @@
`(,(regexp-opt '("uselistorder" "uselistorder_bb") 'words) . font-lock-keyword-face)
)
"Syntax highlighting for LLVM"
"Syntax highlighting for LLVM."
)
;; ---------------------- Syntax table ---------------------------
@ -62,40 +67,40 @@
(if (not llvm-mode-syntax-table)
(progn
(setq llvm-mode-syntax-table (make-syntax-table))
(mapcar (function (lambda (n)
(modify-syntax-entry (aref n 0)
(aref n 1)
llvm-mode-syntax-table)))
'(
;; whitespace (` ')
[?\^m " "]
[?\f " "]
[?\n " "]
[?\t " "]
[?\ " "]
;; word constituents (`w')
;;[?< "w"]
;;[?> "w"]
[?\% "w"]
;;[?_ "w "]
;; comments
[?\; "< "]
[?\n "> "]
;;[?\r "> "]
;;[?\^m "> "]
;; symbol constituents (`_')
;; punctuation (`.')
;; open paren (`(')
[?\( "("]
[?\[ "("]
[?\{ "("]
;; close paren (`)')
[?\) ")"]
[?\] ")"]
[?\} ")"]
;; string quote ('"')
[?\" "\""]
))))
(mapc (function (lambda (n)
(modify-syntax-entry (aref n 0)
(aref n 1)
llvm-mode-syntax-table)))
'(
;; whitespace (` ')
[?\^m " "]
[?\f " "]
[?\n " "]
[?\t " "]
[?\ " "]
;; word constituents (`w')
;;[?< "w"]
;;[?> "w"]
[?\% "w"]
;;[?_ "w "]
;; comments
[?\; "< "]
[?\n "> "]
;;[?\r "> "]
;;[?\^m "> "]
;; symbol constituents (`_')
;; punctuation (`.')
;; open paren (`(')
[?\( "("]
[?\[ "("]
[?\{ "("]
;; close paren (`)')
[?\) ")"]
[?\] ")"]
[?\} ")"]
;; string quote ('"')
[?\" "\""]
))))
;; --------------------- Abbrev table -----------------------------
@ -113,11 +118,11 @@
(define-key llvm-mode-map "\es" 'center-line)
(define-key llvm-mode-map "\eS" 'center-paragraph))
;;;###autoload
(defun llvm-mode ()
"Major mode for editing LLVM source files.
\\{llvm-mode-map}
Runs llvm-mode-hook on startup."
\\{llvm-mode-map}
Runs `llvm-mode-hook' on startup."
(interactive)
(kill-all-local-variables)
(use-local-map llvm-mode-map) ; Provides the local keymap.
@ -136,8 +141,9 @@
; customize the mode with a hook.
;; Associate .ll files with llvm-mode
(setq auto-mode-alist
(append '(("\\.ll$" . llvm-mode)) auto-mode-alist))
;;;###autoload
(add-to-list 'auto-mode-alist (cons (purecopy "\\.ll\\'") 'llvm-mode))
(provide 'llvm-mode)
;; end of llvm-mode.el
;;; llvm-mode.el ends here

View File

@ -1,12 +1,17 @@
;;; tablegen-mode.el --- Major mode for TableGen description files (part of LLVM project)
;; Maintainer: The LLVM team, http://llvm.org/
;; Description: Major mode for TableGen description files (part of LLVM project)
;; Updated: 2007-12-18
;;; Commentary:
;; A major mode for TableGen description files in LLVM.
(require 'comint)
(require 'custom)
(require 'ansi-color)
;; Create mode-specific tables.
;;; Code:
(defvar td-decorators-face 'td-decorators-face
"Face method decorators.")
(make-face 'td-decorators-face)
@ -93,10 +98,11 @@
(define-key tablegen-mode-map "\es" 'center-line)
(define-key tablegen-mode-map "\eS" 'center-paragraph))
;;;###autoload
(defun tablegen-mode ()
"Major mode for editing TableGen description files.
\\{tablegen-mode-map}
Runs tablegen-mode-hook on startup."
\\{tablegen-mode-map}
Runs `tablegen-mode-hook' on startup."
(interactive)
(kill-all-local-variables)
(use-local-map tablegen-mode-map) ; Provides the local keymap.
@ -117,7 +123,9 @@
; customize the mode with a hook.
;; Associate .td files with tablegen-mode
(setq auto-mode-alist (append '(("\\.td$" . tablegen-mode)) auto-mode-alist))
;;;###autoload
(add-to-list 'auto-mode-alist (cons (purecopy "\\.td\\'") 'tablegen-mode))
(provide 'tablegen-mode)
;; end of tablegen-mode.el
;;; tablegen-mode.el ends here