From 75db383edd4ab8752150597b710624bb0ef9f9ae Mon Sep 17 00:00:00 2001 From: Max Kazantsev Date: Tue, 22 Jan 2019 09:36:22 +0000 Subject: [PATCH] [NFC] Add detector for guards expressed as branch by widenable conditions This patch adds a function to detect guards expressed in explicit control flow form as branch by `and` with widenable condition intrinsic call: %wc = call i1 @llvm.experimental.widenable.condition() %guard_cond = and i1, %some_cond, %wc br i1 %guard_cond, label %guarded, label %deopt deopt: deoptimize() This form can be used as alternative to implicit control flow guard representation expressed by `experimental_guard` intrinsic. Differential Revision: https://reviews.llvm.org/D56074 Reviewed By: reames llvm-svn: 351791 --- include/llvm/Analysis/GuardUtils.h | 8 ++++++-- lib/Analysis/GuardUtils.cpp | 27 +++++++++++++++++++++++++++ 2 files changed, 33 insertions(+), 2 deletions(-) diff --git a/include/llvm/Analysis/GuardUtils.h b/include/llvm/Analysis/GuardUtils.h index 4c755eac824..62ae09a4f8f 100644 --- a/include/llvm/Analysis/GuardUtils.h +++ b/include/llvm/Analysis/GuardUtils.h @@ -16,10 +16,14 @@ namespace llvm { class User; -/// Returns true iff \p U has semantics of a guard. +/// Returns true iff \p U has semantics of a guard expressed in a form of call +/// of llvm.experimental.guard intrinsic. bool isGuard(const User *U); +/// Returns true iff \p U has semantics of a guard expressed in a form of a +/// widenable conditional branch to deopt block. +bool isGuardAsWidenableBranch(const User *U); + } // llvm #endif // LLVM_ANALYSIS_GUARDUTILS_H - diff --git a/lib/Analysis/GuardUtils.cpp b/lib/Analysis/GuardUtils.cpp index 2cee473e289..36ae954ed8b 100644 --- a/lib/Analysis/GuardUtils.cpp +++ b/lib/Analysis/GuardUtils.cpp @@ -18,3 +18,30 @@ bool llvm::isGuard(const User *U) { using namespace llvm::PatternMatch; return match(U, m_Intrinsic()); } + +bool llvm::isGuardAsWidenableBranch(const User *U) { + using namespace llvm::PatternMatch; + const BranchInst *BI = dyn_cast(U); + + // We are looking for the following pattern: + // br i1 %cond & widenable_condition(), label %guarded, label %deopt + // deopt: + // + // deoptimize() + if (!BI || !BI->isConditional()) + return false; + + if (!match(BI->getCondition(), + m_And(m_Value(), + m_Intrinsic()))) + return false; + + const BasicBlock *DeoptBlock = BI->getSuccessor(1); + for (auto &Insn : *DeoptBlock) { + if (match(&Insn, m_Intrinsic())) + return true; + if (Insn.mayHaveSideEffects()) + return false; + } + return false; +}