From a556fc183fab504c5622e8099609d3d79e202773 Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Mon, 11 Jul 2005 05:17:48 +0000 Subject: [PATCH] Refactor things a bit to allow the ELF code emitter to run the X86 machine code emitter after itself. llvm-svn: 22376 --- lib/Target/X86/X86.h | 17 +++++++++++------ lib/Target/X86/X86CodeEmitter.cpp | 16 ++++------------ lib/Target/X86/X86ELFWriter.cpp | 14 +++++++++----- lib/Target/X86/X86TargetMachine.cpp | 9 ++++++++- 4 files changed, 32 insertions(+), 24 deletions(-) diff --git a/lib/Target/X86/X86.h b/lib/Target/X86/X86.h index c89bb095e17..69f887afd8e 100644 --- a/lib/Target/X86/X86.h +++ b/lib/Target/X86/X86.h @@ -20,8 +20,10 @@ namespace llvm { class TargetMachine; +class PassManager; class FunctionPass; class IntrinsicLowering; +class MachineCodeEmitter; enum X86VectorEnum { NoSSE, SSE, SSE2, SSE3 @@ -59,16 +61,19 @@ FunctionPass *createX86FloatingPointStackifierPass(); /// createX86CodePrinterPass - Returns a pass that prints the X86 /// assembly code for a MachineFunction to the given output stream, -/// using the given target machine description. This should work -/// regardless of whether the function is in SSA form. +/// using the given target machine description. /// -FunctionPass *createX86CodePrinterPass(std::ostream &o,TargetMachine &tm); +FunctionPass *createX86CodePrinterPass(std::ostream &o, TargetMachine &tm); -/// createX86ELFObjectWriterPass - Returns a pass that outputs the generated +/// createX86CodeEmitterPass - Return a pass that emits the collected X86 code +/// to the specified MCE object. +FunctionPass *createX86CodeEmitterPass(MachineCodeEmitter &MCE); + +/// addX86ELFObjectWriterPass - Add passes to the FPM that output the generated /// code as an ELF object file. /// -FunctionPass *createX86ELFObjectWriterPass(std::ostream &o, TargetMachine &tm); - +void addX86ELFObjectWriterPass(PassManager &FPM, + std::ostream &o, TargetMachine &tm); /// createX86EmitCodeToMemory - Returns a pass that converts a register /// allocated function into raw machine code in a dynamically diff --git a/lib/Target/X86/X86CodeEmitter.cpp b/lib/Target/X86/X86CodeEmitter.cpp index 789b8e26cef..cafb175c520 100644 --- a/lib/Target/X86/X86CodeEmitter.cpp +++ b/lib/Target/X86/X86CodeEmitter.cpp @@ -68,18 +68,10 @@ namespace { }; } -/// addPassesToEmitMachineCode - Add passes to the specified pass manager to get -/// machine code emitted. This uses a MachineCodeEmitter object to handle -/// actually outputting the machine code and resolving things like the address -/// of functions. This method should returns true if machine code emission is -/// not supported. -/// -bool X86TargetMachine::addPassesToEmitMachineCode(FunctionPassManager &PM, - MachineCodeEmitter &MCE) { - PM.add(new Emitter(MCE)); - // Delete machine code for this function - PM.add(createMachineCodeDeleter()); - return false; +/// createX86CodeEmitterPass - Return a pass that emits the collected X86 code +/// to the specified MCE object. +FunctionPass *llvm::createX86CodeEmitterPass(MachineCodeEmitter &MCE) { + return new Emitter(MCE); } bool Emitter::runOnMachineFunction(MachineFunction &MF) { diff --git a/lib/Target/X86/X86ELFWriter.cpp b/lib/Target/X86/X86ELFWriter.cpp index 1617fac7cd5..8a6f1fc8982 100644 --- a/lib/Target/X86/X86ELFWriter.cpp +++ b/lib/Target/X86/X86ELFWriter.cpp @@ -13,7 +13,9 @@ //===----------------------------------------------------------------------===// #include "X86.h" +#include "llvm/PassManager.h" #include "llvm/CodeGen/ELFWriter.h" +#include "llvm/Target/TargetMachine.h" using namespace llvm; namespace { @@ -25,10 +27,12 @@ namespace { }; } -/// createX86ELFObjectWriterPass - Returns a pass that outputs the generated -/// code as an ELF object file. +/// addX86ELFObjectWriterPass - Returns a pass that outputs the generated code +/// as an ELF object file. /// -FunctionPass *llvm::createX86ELFObjectWriterPass(std::ostream &O, - TargetMachine &TM) { - return new X86ELFWriter(O, TM); +void llvm::addX86ELFObjectWriterPass(PassManager &FPM, + std::ostream &O, TargetMachine &TM) { + X86ELFWriter *EW = new X86ELFWriter(O, TM); + FPM.add(EW); + FPM.add(createX86CodeEmitterPass(EW->getMachineCodeEmitter())); } diff --git a/lib/Target/X86/X86TargetMachine.cpp b/lib/Target/X86/X86TargetMachine.cpp index def4f9cfa49..a0537f529c1 100644 --- a/lib/Target/X86/X86TargetMachine.cpp +++ b/lib/Target/X86/X86TargetMachine.cpp @@ -162,7 +162,7 @@ bool X86TargetMachine::addPassesToEmitFile(PassManager &PM, std::ostream &Out, // FIXME: We only support emission of ELF files for now, this should check // the target triple and decide on the format to write (e.g. COFF on // win32). - PM.add(createX86ELFObjectWriterPass(Out, *this)); + addX86ELFObjectWriterPass(PM, Out, *this); break; } @@ -225,3 +225,10 @@ void X86JITInfo::addPassesToJITCompile(FunctionPassManager &PM) { PM.add(createX86CodePrinterPass(std::cerr, TM)); } +bool X86TargetMachine::addPassesToEmitMachineCode(FunctionPassManager &PM, + MachineCodeEmitter &MCE) { + PM.add(createX86CodeEmitterPass(MCE)); + // Delete machine code for this function + PM.add(createMachineCodeDeleter()); + return false; +}