From b2f869ee43338551582dc0d2178154de1d799e1a Mon Sep 17 00:00:00 2001 From: Brian Gaeke Date: Thu, 4 Mar 2004 04:37:45 +0000 Subject: [PATCH] Subtract instructions; minor cleanups llvm-svn: 12111 --- lib/Target/SparcV8/InstSelectSimple.cpp | 10 ++++++---- lib/Target/SparcV8/SparcV8InstrInfo.td | 5 ++++- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/lib/Target/SparcV8/InstSelectSimple.cpp b/lib/Target/SparcV8/InstSelectSimple.cpp index 95ff31ec75b..5c145cb9399 100644 --- a/lib/Target/SparcV8/InstSelectSimple.cpp +++ b/lib/Target/SparcV8/InstSelectSimple.cpp @@ -165,9 +165,8 @@ static TypeClass getClass (const Type *T) { void V8ISel::copyConstantToRegister(MachineBasicBlock *MBB, MachineBasicBlock::iterator IP, Constant *C, unsigned R) { - if (C->getType()->isIntegral()) { + if (ConstantInt *CI = dyn_cast (C)) { unsigned Class = getClass(C->getType()); - ConstantInt *CI = cast(C); switch (Class) { case cByte: BuildMI (*MBB, IP, V8::ORri, 2, R).addReg (V8::G0).addImm ((uint8_t) CI->getRawValue ()); @@ -185,12 +184,12 @@ void V8ISel::copyConstantToRegister(MachineBasicBlock *MBB, return; } default: - assert (0 && "Can't move this kind of constant"); + assert (0 && "Can't copy this kind of constant into register yet"); return; } } - assert (0 && "Can't copy constants into registers yet"); + assert (0 && "Can't copy this kind of constant into register yet"); } bool V8ISel::runOnFunction(Function &Fn) { @@ -246,6 +245,9 @@ void V8ISel::visitBinaryOperator (BinaryOperator &I) { case Instruction::Add: BuildMI (BB, V8::ADDrr, 2, ResultReg).addReg (Op0Reg).addReg (Op1Reg); break; + case Instruction::Sub: + BuildMI (BB, V8::SUBrr, 2, ResultReg).addReg (Op0Reg).addReg (Op1Reg); + break; default: visitInstruction (I); return; diff --git a/lib/Target/SparcV8/SparcV8InstrInfo.td b/lib/Target/SparcV8/SparcV8InstrInfo.td index 7a544047d42..72ad34f25af 100644 --- a/lib/Target/SparcV8/SparcV8InstrInfo.td +++ b/lib/Target/SparcV8/SparcV8InstrInfo.td @@ -62,7 +62,7 @@ def CALL : InstV8 { let Name = "call"; } -// Section B.9 - SETHI Instruction, p. 102 +// Section B.9 - SETHI Instruction, p. 104 def SETHIi: F2_1<0b100, "sethi">; // Section B.11 - Logical Instructions, p. 106 @@ -78,6 +78,9 @@ def SRAri : F3_1<2, 0b100111, "sra">; // Section B.13 - Add Instructions, p. 108 def ADDrr : F3_1<2, 0b000000, "add">; +// Section B.15 - Subtract Instructions, p. 110 +def SUBrr : F3_1<2, 0b000100, "sub">; + // Section B.25 - Jump and Link, p. 126 def JMPLr : F3_1<2, 0b111000, "jmpl">; // jmpl [rs1+rs2], rd def JMPLi : F3_2<2, 0b111000, "jmpl">; // jmpl [rs1+imm], rd