RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-12-11 13:37:07 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

stylistic change to MCSectionCOFF::PrintSwitchToSection COMDAT handling

Browse Source 
Made a stylistic changed to the code/comments related to the unsupported COMDAT selection  type IMAGE_COMDAT_SELECT_LARGEST based on from Anton Korobeynikov.

llvm-svn: 103590
This commit is contained in:
Nathan Jeffords 2010-05-12 07:36:03 +00:00
parent bd83ac415f
commit b578f7106d
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
lib/MC/MCSectionCOFF.cpp
View File

@ -50,9 +50,6 @@ void MCSectionCOFF::PrintSwitchToSection(const MCAsmInfo &MAI,
if (getCharacteristics() & MCSectionCOFF::IMAGE_SCN_LNK_COMDAT) {
switch (Selection) {
default:
assert (0 && "unsupported COFF selection type");
break;
case IMAGE_COMDAT_SELECT_NODUPLICATES:
OS << "\t.linkonce one_only\n";
break;
@ -65,12 +62,15 @@ void MCSectionCOFF::PrintSwitchToSection(const MCAsmInfo &MAI,
case IMAGE_COMDAT_SELECT_EXACT_MATCH:
OS << "\t.linkonce same_contents\n";
break;
// ".linkonce largest" is not documented as being an option.
// It seems odd that a link attribute designed essentially for PE/COFF
// wouldn't support all the options (at least as of binutils 2.20)
//case IMAGE_COMDAT_SELECT_LARGEST:
//NOTE: as of binutils 2.20, there is no way to specifiy select largest
// with the .linkonce directive. For now, we treat it as an invalid
// comdat selection value.
case IMAGE_COMDAT_SELECT_LARGEST:
// OS << "\t.linkonce largest\n";
// break;
default:
assert (0 && "unsupported COFF selection type");
break;
}
}
}