RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-12-14 15:19:33 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

GlobalISel: Verify g_insert

Browse Source 
llvm-svn: 354342
This commit is contained in:
Matt Arsenault 2019-02-19 16:10:16 +00:00
parent 4bcafa3f7c
commit c68dc40179
2 changed files with 68 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
lib/CodeGen/MachineVerifier.cpp
View File

@ -1288,6 +1288,30 @@ void MachineVerifier::verifyPreISelGenericInstruction(const MachineInstr *MI) {
report("extract reads past end of register", MI);
break;
}
case TargetOpcode::G_INSERT: {
const MachineOperand &SrcOp = MI->getOperand(2);
if (!SrcOp.isReg()) {
report("insert source must be a register", MI);
break;
}
const MachineOperand &OffsetOp = MI->getOperand(3);
if (!OffsetOp.isImm()) {
report("insert offset must be a constant", MI);
break;
}
unsigned DstSize = MRI->getType(MI->getOperand(0).getReg()).getSizeInBits();
unsigned SrcSize = MRI->getType(SrcOp.getReg()).getSizeInBits();
if (DstSize <= SrcSize)
report("inserted size must be smaller than total register", MI);
if (SrcSize + OffsetOp.getImm() > DstSize)
report("insert writes past end of register", MI);
break;
}
default:
break;
}

44
test/MachineVerifier/test_g_insert.mir Normal file
View File

@ -0,0 +1,44 @@
# RUN: not llc -march=aarch64 -o /dev/null -run-pass=none -verify-machineinstrs %s 2>&1 | FileCheck %s
# REQUIRES: global-isel, aarch64-registered-target
---
name: test_insert
legalized: true
tracksRegLiveness: true
liveins:
body: |
bb.0:
; CHECK: Bad machine code: Too few operands
%0:_(s32) = G_INSERT
; CHECK: Bad machine code: Too few operands
; CHECK: Bad machine code: generic instruction must use register operands
%1:_(s32) = G_INSERT 0
; CHECK: Bad machine code: generic instruction must use register operands
; CHECK: Bad machine code: generic instruction must use register operands
; CHECK: Bad machine code: insert source must be a register
%2:_(s32) = G_INSERT 0, 0, 0
%3:_(s32) = G_IMPLICIT_DEF
%4:_(s1) = G_IMPLICIT_DEF
; CHECK: Bad machine code: insert writes past end of register
%5:_(s32) = G_INSERT %3, %4, 32
; CHECK: Bad machine code: insert offset must be a constant
%5:_(s32) = G_INSERT %3, %4, %3
; CHECK: Bad machine code: insert offset must be a constant
%6:_(s32) = G_INSERT %3, %4, i32 4
%7:_(s64) = G_IMPLICIT_DEF
; CHECK: Bad machine code: inserted size must be smaller than total register
%8:_(s32) = G_INSERT %3, %7, 0
; CHECK: Bad machine code: inserted size must be smaller than total register
%9:_(s32) = G_INSERT %3, %3, 0
...