From ea0ac8fafac36ee4cc17b08032b752fc24d6f66c Mon Sep 17 00:00:00 2001 From: Benjamin Kramer Date: Sun, 27 Mar 2011 15:04:38 +0000 Subject: [PATCH] Use APInt's umul_ov instead of rolling our own overflow detection. llvm-svn: 128380 --- lib/Transforms/InstCombine/InstCombineCalls.cpp | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/lib/Transforms/InstCombine/InstCombineCalls.cpp b/lib/Transforms/InstCombine/InstCombineCalls.cpp index b5fd0b9af40..875e9cae582 100644 --- a/lib/Transforms/InstCombine/InstCombineCalls.cpp +++ b/lib/Transforms/InstCombine/InstCombineCalls.cpp @@ -487,14 +487,15 @@ Instruction *InstCombiner::visitCallInst(CallInst &CI) { APInt RHSKnownOne(BitWidth, 0); ComputeMaskedBits(RHS, Mask, RHSKnownZero, RHSKnownOne); - // Get the largest possible values for each operand, extended to be large - // enough so that every possible product of two BitWidth-sized ints fits. - APInt LHSMax = (~LHSKnownZero).zext(BitWidth*2); - APInt RHSMax = (~RHSKnownZero).zext(BitWidth*2); + // Get the largest possible values for each operand. + APInt LHSMax = ~LHSKnownZero; + APInt RHSMax = ~RHSKnownZero; // If multiplying the maximum values does not overflow then we can turn // this into a plain NUW mul. - if ((LHSMax * RHSMax).getActiveBits() <= BitWidth) { + bool Overflow; + LHSMax.umul_ov(RHSMax, Overflow); + if (!Overflow) { Value *Mul = Builder->CreateNUWMul(LHS, RHS, "umul_with_overflow"); Constant *V[] = { UndefValue::get(LHS->getType()),