From f91794309e06db8b655b8ccbe5f6775e5ec1b11b Mon Sep 17 00:00:00 2001 From: Sanjay Patel Date: Sat, 16 Apr 2016 23:26:16 +0000 Subject: [PATCH] use range loop, try to make comments more meaningful; NFCI llvm-svn: 266541 --- lib/IR/AutoUpgrade.cpp | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/lib/IR/AutoUpgrade.cpp b/lib/IR/AutoUpgrade.cpp index 121b43b7964..9ddfc91978e 100644 --- a/lib/IR/AutoUpgrade.cpp +++ b/lib/IR/AutoUpgrade.cpp @@ -802,21 +802,18 @@ void llvm::UpgradeIntrinsicCall(CallInst *CI, Function *NewFn) { } } -// This tests each Function to determine if it needs upgrading. When we find -// one we are interested in, we then upgrade all calls to reflect the new -// function. -void llvm::UpgradeCallsToIntrinsic(Function* F) { +void llvm::UpgradeCallsToIntrinsic(Function *F) { assert(F && "Illegal attempt to upgrade a non-existent intrinsic."); - // Upgrade the function and check if it is a totaly new function. + // Check if this function should be upgraded and get the replacement function + // if there is one. Function *NewFn; if (UpgradeIntrinsicFunction(F, NewFn)) { - // Replace all uses to the old function with the new one if necessary. - for (Value::user_iterator UI = F->user_begin(), UE = F->user_end(); - UI != UE;) { - if (CallInst *CI = dyn_cast(*UI++)) + // Replace all users of the old function with the new function or new IR. + for (User *U : F->users()) + if (CallInst *CI = dyn_cast(U)) UpgradeIntrinsicCall(CI, NewFn); - } + // Remove old function, no longer used, from the module. F->eraseFromParent(); }