mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-12-11 13:37:07 +00:00
a92f4c62f1
two fixes with one about error verify-regalloc reported, and another about live range update of phi after rematerialization. r265547: Replace analyzeSiblingValues with new algorithm to fix its compile time issue. The patch is to solve PR17409 and its duplicates. analyzeSiblingValues is a N x N complexity algorithm where N is the number of siblings generated by reg splitting. Although it causes siginificant compile time issue when N is large, it is also important for performance since it removes redundent spills and enables rematerialization. To solve the compile time issue, the patch removes analyzeSiblingValues and replaces it with lower cost alternatives containing two parts. The first part creates a new spill hoisting method in postOptimization of register allocation. It does spill hoisting at once after all the spills are generated instead of inside every instance of selectOrSplit. The second part queries the define expr of the original register for rematerializaiton and keep it always available during register allocation even if it is already dead. It deletes those dead instructions only in postOptimization. With the two parts in the patch, it can remove analyzeSiblingValues without sacrificing performance. Patches on top of r265547: r265610 "Fix the compare-clang diff error introduced by r265547." r265639 "Fix the sanitizer bootstrap error in r265547." r265657 "InlineSpiller.cpp: Escap \@ in r265547. [-Wdocumentation]" Differential Revision: http://reviews.llvm.org/D15302 Differential Revision: http://reviews.llvm.org/D18934 Differential Revision: http://reviews.llvm.org/D18935 Differential Revision: http://reviews.llvm.org/D18936 llvm-svn: 266162
123 lines
4.5 KiB
C++
123 lines
4.5 KiB
C++
//===-- RegAllocBase.h - basic regalloc interface and driver --*- C++ -*---===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This file defines the RegAllocBase class, which is the skeleton of a basic
|
|
// register allocation algorithm and interface for extending it. It provides the
|
|
// building blocks on which to construct other experimental allocators and test
|
|
// the validity of two principles:
|
|
//
|
|
// - If virtual and physical register liveness is modeled using intervals, then
|
|
// on-the-fly interference checking is cheap. Furthermore, interferences can be
|
|
// lazily cached and reused.
|
|
//
|
|
// - Register allocation complexity, and generated code performance is
|
|
// determined by the effectiveness of live range splitting rather than optimal
|
|
// coloring.
|
|
//
|
|
// Following the first principle, interfering checking revolves around the
|
|
// LiveIntervalUnion data structure.
|
|
//
|
|
// To fulfill the second principle, the basic allocator provides a driver for
|
|
// incremental splitting. It essentially punts on the problem of register
|
|
// coloring, instead driving the assignment of virtual to physical registers by
|
|
// the cost of splitting. The basic allocator allows for heuristic reassignment
|
|
// of registers, if a more sophisticated allocator chooses to do that.
|
|
//
|
|
// This framework provides a way to engineer the compile time vs. code
|
|
// quality trade-off without relying on a particular theoretical solver.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#ifndef LLVM_LIB_CODEGEN_REGALLOCBASE_H
|
|
#define LLVM_LIB_CODEGEN_REGALLOCBASE_H
|
|
|
|
#include "llvm/CodeGen/LiveInterval.h"
|
|
#include "llvm/CodeGen/RegisterClassInfo.h"
|
|
|
|
namespace llvm {
|
|
|
|
template<typename T> class SmallVectorImpl;
|
|
class TargetRegisterInfo;
|
|
class VirtRegMap;
|
|
class LiveIntervals;
|
|
class LiveRegMatrix;
|
|
class Spiller;
|
|
|
|
/// RegAllocBase provides the register allocation driver and interface that can
|
|
/// be extended to add interesting heuristics.
|
|
///
|
|
/// Register allocators must override the selectOrSplit() method to implement
|
|
/// live range splitting. They must also override enqueue/dequeue to provide an
|
|
/// assignment order.
|
|
class RegAllocBase {
|
|
virtual void anchor();
|
|
protected:
|
|
const TargetRegisterInfo *TRI;
|
|
MachineRegisterInfo *MRI;
|
|
VirtRegMap *VRM;
|
|
LiveIntervals *LIS;
|
|
LiveRegMatrix *Matrix;
|
|
RegisterClassInfo RegClassInfo;
|
|
|
|
/// Inst which is a def of an original reg and whose defs are already all
|
|
/// dead after remat is saved in DeadRemats. The deletion of such inst is
|
|
/// postponed till all the allocations are done, so its remat expr is
|
|
/// always available for the remat of all the siblings of the original reg.
|
|
SmallPtrSet<MachineInstr *, 32> DeadRemats;
|
|
|
|
RegAllocBase()
|
|
: TRI(nullptr), MRI(nullptr), VRM(nullptr), LIS(nullptr), Matrix(nullptr) {}
|
|
|
|
virtual ~RegAllocBase() {}
|
|
|
|
// A RegAlloc pass should call this before allocatePhysRegs.
|
|
void init(VirtRegMap &vrm, LiveIntervals &lis, LiveRegMatrix &mat);
|
|
|
|
// The top-level driver. The output is a VirtRegMap that us updated with
|
|
// physical register assignments.
|
|
void allocatePhysRegs();
|
|
|
|
// Include spiller post optimization and removing dead defs left because of
|
|
// rematerialization.
|
|
virtual void postOptimization();
|
|
|
|
// Get a temporary reference to a Spiller instance.
|
|
virtual Spiller &spiller() = 0;
|
|
|
|
/// enqueue - Add VirtReg to the priority queue of unassigned registers.
|
|
virtual void enqueue(LiveInterval *LI) = 0;
|
|
|
|
/// dequeue - Return the next unassigned register, or NULL.
|
|
virtual LiveInterval *dequeue() = 0;
|
|
|
|
// A RegAlloc pass should override this to provide the allocation heuristics.
|
|
// Each call must guarantee forward progess by returning an available PhysReg
|
|
// or new set of split live virtual registers. It is up to the splitter to
|
|
// converge quickly toward fully spilled live ranges.
|
|
virtual unsigned selectOrSplit(LiveInterval &VirtReg,
|
|
SmallVectorImpl<unsigned> &splitLVRs) = 0;
|
|
|
|
// Use this group name for NamedRegionTimer.
|
|
static const char TimerGroupName[];
|
|
|
|
/// Method called when the allocator is about to remove a LiveInterval.
|
|
virtual void aboutToRemoveInterval(LiveInterval &LI) {}
|
|
|
|
public:
|
|
/// VerifyEnabled - True when -verify-regalloc is given.
|
|
static bool VerifyEnabled;
|
|
|
|
private:
|
|
void seedLiveRegs();
|
|
};
|
|
|
|
} // end namespace llvm
|
|
|
|
#endif
|