mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-12-11 13:37:07 +00:00
e3e064f30d
This is an AVR-specific workaround for a limitation of the register
allocator that only exposes itself on targets with high register
contention like AVR, which only has three pointer registers.
The three pointer registers are X, Y, and Z.
In most nontrivial functions, Y is reserved for the frame pointer,
as per the calling convention. This leaves X and Z. Some instructions,
such as LPM ("load program memory"), are only defined for the Z
register. Sometimes this just leaves X.
When the backend generates a LDDWRdPtrQ instruction with Z as the
destination pointer, it usually trips up the register allocator
with this error message:
LLVM ERROR: ran out of registers during register allocation
This patch is a hacky workaround. We ban the LDDWRdPtrQ instruction
from ever using the Z register as an operand. This gives the
register allocator a bit more space to allocate, fixing the
regalloc exhaustion error.
Here is a description from the patch author Peter Nimmervoll
As far as I understand the problem occurs when LDDWRdPtrQ uses
the ptrdispregs register class as target register. This should work, but
the allocator can't deal with this for some reason. So from my testing,
it seams like (and I might be totally wrong on this) the allocator reserves
the Z register for the ICALL instruction and then the register class
ptrdispregs only has 1 register left and we can't use Y for source and
destination. Removing the Z register from DREGS fixes the problem but
removing Y register does not.
More information about the bug can be found on the avr-rust issue
tracker at https://github.com/avr-rust/rust/issues/37.
A bug has raised to track the removal of this workaround and a proper
fix; PR39553 at https://bugs.llvm.org/show_bug.cgi?id=39553.
Patch by Peter Nimmervoll
llvm-svn: 346114
25 lines
1.1 KiB
LLVM
25 lines
1.1 KiB
LLVM
; RUN: llc < %s -march=avr | FileCheck %s
|
|
|
|
%"fmt::Formatter" = type { i32, { i8*, void (i8*)** } }
|
|
|
|
@str.1b = external constant [0 x i8]
|
|
|
|
define void @"TryFromIntError::Debug"(%"fmt::Formatter"* dereferenceable(32)) unnamed_addr #0 personality i32 (...)* @rust_eh_personality {
|
|
; CHECK-LABEL: "TryFromIntError::Debug"
|
|
start:
|
|
%builder = alloca i8, align 8
|
|
%1 = getelementptr inbounds %"fmt::Formatter", %"fmt::Formatter"* %0, i16 0, i32 1
|
|
%2 = bitcast { i8*, void (i8*)** }* %1 to {}**
|
|
%3 = load {}*, {}** %2, align 2
|
|
%4 = getelementptr inbounds %"fmt::Formatter", %"fmt::Formatter"* %0, i16 0, i32 1, i32 1
|
|
%5 = load void (i8*)**, void (i8*)*** %4, align 2
|
|
%6 = getelementptr inbounds void (i8*)*, void (i8*)** %5, i16 3
|
|
%7 = bitcast void (i8*)** %6 to i8 ({}*, i8*, i16)**
|
|
%8 = load i8 ({}*, i8*, i16)*, i8 ({}*, i8*, i16)** %7, align 2
|
|
%9 = tail call i8 %8({}* nonnull %3, i8* noalias nonnull readonly getelementptr inbounds ([0 x i8], [0 x i8]* @str.1b, i16 0, i16 0), i16 15)
|
|
unreachable
|
|
}
|
|
|
|
declare i32 @rust_eh_personality(...) unnamed_addr
|
|
|
|
attributes #0 = { uwtable } |