2010-11-17 21:57:32 +00:00
|
|
|
; RUN: llc < %s -mtriple=arm-apple-darwin | FileCheck %s
|
2009-10-09 17:20:46 +00:00
|
|
|
; RUN: llc < %s -march=arm -mattr=+vfp2 | FileCheck %s --check-prefix=CHECK-VFP
|
Consider this code snippet:
float t1(int argc) {
return (argc == 1123) ? 1.234f : 2.38213f;
}
We would generate truly awful code on ARM (those with a weak stomach should look
away):
_t1:
movw r1, #1123
movs r2, #1
movs r3, #0
cmp r0, r1
mov.w r0, #0
it eq
moveq r0, r2
movs r1, #4
cmp r0, #0
it ne
movne r3, r1
adr r0, #LCPI1_0
ldr r0, [r0, r3]
bx lr
The problem was that legalization was creating a cascade of SELECT_CC nodes, for
for the comparison of "argc == 1123" which was fed into a SELECT node for the ?:
statement which was itself converted to a SELECT_CC node. This is because the
ARM back-end doesn't have custom lowering for SELECT nodes, so it used the
default "Expand".
I added a fairly simple "LowerSELECT" to the ARM back-end. It takes care of this
testcase, but can obviously be expanded to include more cases.
Now we generate this, which looks optimal to me:
_t1:
movw r1, #1123
movs r2, #0
cmp r0, r1
adr r0, #LCPI0_0
it eq
moveq r2, #4
ldr r0, [r0, r2]
bx lr
.align 2
LCPI0_0:
.long 1075344593 @ float 2.382130e+00
.long 1067316150 @ float 1.234000e+00
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@110799 91177308-0d34-0410-b5e6-96231b3b80d8
2010-08-11 08:43:16 +00:00
|
|
|
; RUN: llc < %s -mattr=+neon,+thumb2 -mtriple=thumbv7-apple-darwin | FileCheck %s --check-prefix=CHECK-NEON
|
2006-08-22 06:43:24 +00:00
|
|
|
|
2007-01-26 08:25:06 +00:00
|
|
|
define i32 @f1(i32 %a.s) {
|
2009-10-09 17:20:46 +00:00
|
|
|
;CHECK: f1:
|
|
|
|
;CHECK: moveq
|
2006-08-21 22:00:32 +00:00
|
|
|
entry:
|
2007-01-19 09:20:23 +00:00
|
|
|
%tmp = icmp eq i32 %a.s, 4
|
|
|
|
%tmp1.s = select i1 %tmp, i32 2, i32 3
|
|
|
|
ret i32 %tmp1.s
|
2006-08-21 22:00:32 +00:00
|
|
|
}
|
2006-09-21 13:06:26 +00:00
|
|
|
|
2007-01-26 08:25:06 +00:00
|
|
|
define i32 @f2(i32 %a.s) {
|
2009-10-09 17:20:46 +00:00
|
|
|
;CHECK: f2:
|
|
|
|
;CHECK: movgt
|
2006-09-21 13:06:26 +00:00
|
|
|
entry:
|
2007-01-19 09:20:23 +00:00
|
|
|
%tmp = icmp sgt i32 %a.s, 4
|
|
|
|
%tmp1.s = select i1 %tmp, i32 2, i32 3
|
|
|
|
ret i32 %tmp1.s
|
2006-09-21 13:06:26 +00:00
|
|
|
}
|
|
|
|
|
2007-01-26 08:25:06 +00:00
|
|
|
define i32 @f3(i32 %a.s, i32 %b.s) {
|
2009-10-09 17:20:46 +00:00
|
|
|
;CHECK: f3:
|
|
|
|
;CHECK: movlt
|
2006-09-21 13:06:26 +00:00
|
|
|
entry:
|
2007-01-19 09:20:23 +00:00
|
|
|
%tmp = icmp slt i32 %a.s, %b.s
|
|
|
|
%tmp1.s = select i1 %tmp, i32 2, i32 3
|
|
|
|
ret i32 %tmp1.s
|
2006-09-21 13:06:26 +00:00
|
|
|
}
|
|
|
|
|
2007-01-26 08:25:06 +00:00
|
|
|
define i32 @f4(i32 %a.s, i32 %b.s) {
|
2009-10-09 17:20:46 +00:00
|
|
|
;CHECK: f4:
|
|
|
|
;CHECK: movle
|
2006-09-21 13:06:26 +00:00
|
|
|
entry:
|
2007-01-19 09:20:23 +00:00
|
|
|
%tmp = icmp sle i32 %a.s, %b.s
|
|
|
|
%tmp1.s = select i1 %tmp, i32 2, i32 3
|
|
|
|
ret i32 %tmp1.s
|
2006-09-21 13:06:26 +00:00
|
|
|
}
|
|
|
|
|
2007-01-26 08:25:06 +00:00
|
|
|
define i32 @f5(i32 %a.u, i32 %b.u) {
|
2009-10-09 17:20:46 +00:00
|
|
|
;CHECK: f5:
|
|
|
|
;CHECK: movls
|
2006-09-21 13:06:26 +00:00
|
|
|
entry:
|
2007-01-19 09:20:23 +00:00
|
|
|
%tmp = icmp ule i32 %a.u, %b.u
|
|
|
|
%tmp1.s = select i1 %tmp, i32 2, i32 3
|
|
|
|
ret i32 %tmp1.s
|
2006-09-21 13:06:26 +00:00
|
|
|
}
|
|
|
|
|
2007-01-26 08:25:06 +00:00
|
|
|
define i32 @f6(i32 %a.u, i32 %b.u) {
|
2009-10-09 17:20:46 +00:00
|
|
|
;CHECK: f6:
|
|
|
|
;CHECK: movhi
|
2006-09-21 13:06:26 +00:00
|
|
|
entry:
|
2007-01-19 09:20:23 +00:00
|
|
|
%tmp = icmp ugt i32 %a.u, %b.u
|
|
|
|
%tmp1.s = select i1 %tmp, i32 2, i32 3
|
|
|
|
ret i32 %tmp1.s
|
|
|
|
}
|
|
|
|
|
2007-01-26 08:25:06 +00:00
|
|
|
define double @f7(double %a, double %b) {
|
2009-10-09 17:20:46 +00:00
|
|
|
;CHECK: f7:
|
|
|
|
;CHECK: movlt
|
|
|
|
;CHECK: movlt
|
|
|
|
;CHECK-VFP: f7:
|
2009-11-09 00:11:35 +00:00
|
|
|
;CHECK-VFP: vmovmi
|
2007-01-19 09:20:23 +00:00
|
|
|
%tmp = fcmp olt double %a, 1.234e+00
|
|
|
|
%tmp1 = select i1 %tmp, double -1.000e+00, double %b
|
|
|
|
ret double %tmp1
|
2006-09-21 13:06:26 +00:00
|
|
|
}
|
Consider this code snippet:
float t1(int argc) {
return (argc == 1123) ? 1.234f : 2.38213f;
}
We would generate truly awful code on ARM (those with a weak stomach should look
away):
_t1:
movw r1, #1123
movs r2, #1
movs r3, #0
cmp r0, r1
mov.w r0, #0
it eq
moveq r0, r2
movs r1, #4
cmp r0, #0
it ne
movne r3, r1
adr r0, #LCPI1_0
ldr r0, [r0, r3]
bx lr
The problem was that legalization was creating a cascade of SELECT_CC nodes, for
for the comparison of "argc == 1123" which was fed into a SELECT node for the ?:
statement which was itself converted to a SELECT_CC node. This is because the
ARM back-end doesn't have custom lowering for SELECT nodes, so it used the
default "Expand".
I added a fairly simple "LowerSELECT" to the ARM back-end. It takes care of this
testcase, but can obviously be expanded to include more cases.
Now we generate this, which looks optimal to me:
_t1:
movw r1, #1123
movs r2, #0
cmp r0, r1
adr r0, #LCPI0_0
it eq
moveq r2, #4
ldr r0, [r0, r2]
bx lr
.align 2
LCPI0_0:
.long 1075344593 @ float 2.382130e+00
.long 1067316150 @ float 1.234000e+00
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@110799 91177308-0d34-0410-b5e6-96231b3b80d8
2010-08-11 08:43:16 +00:00
|
|
|
|
|
|
|
; <rdar://problem/7260094>
|
|
|
|
;
|
|
|
|
; We used to generate really horrible code for this function. The main cause was
|
|
|
|
; a lack of a custom lowering routine for an ISD::SELECT. This would result in
|
|
|
|
; two "it" blocks in the code: one for the "icmp" and another to move the index
|
|
|
|
; into the constant pool based on the value of the "icmp". If we have one "it"
|
|
|
|
; block generated, odds are good that we have close to the ideal code for this:
|
|
|
|
;
|
|
|
|
; CHECK-NEON: _f8:
|
2012-04-02 22:30:39 +00:00
|
|
|
; CHECK-NEON: adr [[R2:r[0-9]+]], LCPI7_0
|
|
|
|
; CHECK-NEON-NEXT: movw [[R3:r[0-9]+]], #1123
|
|
|
|
; CHECK-NEON-NEXT: adds {{r.*}}, [[R2]], #4
|
|
|
|
; CHECK-NEON-NEXT: cmp r0, [[R3]]
|
2011-09-22 23:01:29 +00:00
|
|
|
; CHECK-NEON-NEXT: it ne
|
2012-04-02 22:30:39 +00:00
|
|
|
; CHECK-NEON-NEXT: movne {{r.*}}, [[R2]]
|
Consider this code snippet:
float t1(int argc) {
return (argc == 1123) ? 1.234f : 2.38213f;
}
We would generate truly awful code on ARM (those with a weak stomach should look
away):
_t1:
movw r1, #1123
movs r2, #1
movs r3, #0
cmp r0, r1
mov.w r0, #0
it eq
moveq r0, r2
movs r1, #4
cmp r0, #0
it ne
movne r3, r1
adr r0, #LCPI1_0
ldr r0, [r0, r3]
bx lr
The problem was that legalization was creating a cascade of SELECT_CC nodes, for
for the comparison of "argc == 1123" which was fed into a SELECT node for the ?:
statement which was itself converted to a SELECT_CC node. This is because the
ARM back-end doesn't have custom lowering for SELECT nodes, so it used the
default "Expand".
I added a fairly simple "LowerSELECT" to the ARM back-end. It takes care of this
testcase, but can obviously be expanded to include more cases.
Now we generate this, which looks optimal to me:
_t1:
movw r1, #1123
movs r2, #0
cmp r0, r1
adr r0, #LCPI0_0
it eq
moveq r2, #4
ldr r0, [r0, r2]
bx lr
.align 2
LCPI0_0:
.long 1075344593 @ float 2.382130e+00
.long 1067316150 @ float 1.234000e+00
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@110799 91177308-0d34-0410-b5e6-96231b3b80d8
2010-08-11 08:43:16 +00:00
|
|
|
; CHECK-NEON-NEXT: ldr
|
|
|
|
; CHECK-NEON: bx
|
|
|
|
|
|
|
|
define arm_apcscc float @f8(i32 %a) nounwind {
|
|
|
|
%tmp = icmp eq i32 %a, 1123
|
|
|
|
%tmp1 = select i1 %tmp, float 0x3FF3BE76C0000000, float 0x40030E9A20000000
|
|
|
|
ret float %tmp1
|
|
|
|
}
|
2011-03-08 01:17:20 +00:00
|
|
|
|
|
|
|
; <rdar://problem/9049552>
|
|
|
|
; Glue values can only have a single use, but the following test exposed a
|
|
|
|
; case where a SELECT was lowered with 2 uses of a comparison, causing the
|
|
|
|
; scheduler to assert.
|
|
|
|
; CHECK-VFP: f9:
|
|
|
|
|
|
|
|
declare i8* @objc_msgSend(i8*, i8*, ...)
|
|
|
|
define void @f9() optsize {
|
|
|
|
entry:
|
|
|
|
%cmp = icmp eq i8* undef, inttoptr (i32 4 to i8*)
|
|
|
|
%conv191 = select i1 %cmp, float -3.000000e+00, float 0.000000e+00
|
|
|
|
%conv195 = select i1 %cmp, double -1.000000e+00, double 0.000000e+00
|
|
|
|
%add = fadd double %conv195, 1.100000e+01
|
|
|
|
%conv196 = fptrunc double %add to float
|
|
|
|
%add201 = fadd float undef, %conv191
|
|
|
|
%tmp484 = bitcast float %conv196 to i32
|
|
|
|
%tmp478 = bitcast float %add201 to i32
|
|
|
|
%tmp490 = insertvalue [2 x i32] undef, i32 %tmp484, 0
|
|
|
|
%tmp493 = insertvalue [2 x i32] %tmp490, i32 %tmp478, 1
|
|
|
|
call void bitcast (i8* (i8*, i8*, ...)* @objc_msgSend to void (i8*, i8*, [2 x i32], i32, float)*)(i8* undef, i8* undef, [2 x i32] %tmp493, i32 0, float 1.000000e+00) optsize
|
|
|
|
ret void
|
|
|
|
}
|