RPCS3/llvm
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm.git synced 2024-12-26 14:15:53 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Rearrange the comments, control flow, and variable names; no

Browse Source 
functionality changed.

Evan's commit r168970 moved the code that the primary comment in this
function referred to to the other end of the function without moving the
comment, and there has been a steady creep of "boolean" logic in it that
is simpler if handled via early exit. That way each special case can
have its own comments. I've also made the variable name a bit more
explanatory than "AllFit". This is in preparation to fix the
non-deterministic output of this function.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@168988 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Chandler Carruth 2012-11-30 09:26:25 +00:00
parent 67587f462e
commit 06ec7211c1
1 changed files with 14 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
lib/Transforms/Utils/SimplifyCFG.cpp
View File

@ -3513,14 +3513,10 @@ static bool ShouldBuildLookupTable(SwitchInst *SI,
const DataLayout *TD,
const TargetTransformInfo *TTI,
const SmallDenseMap<PHINode*, Type*>& ResultTypes) {
// The table density should be at least 40%. This is the same criterion as for
// jump tables, see SelectionDAGBuilder::handleJTSwitchCase.
// FIXME: Find the best cut-off.
if (SI->getNumCases() > TableSize || TableSize >= UINT64_MAX / 10)
return false; // TableSize overflowed, or mul below might overflow.
// If each table would fit in a register, we should build it anyway.
bool AllFit = true;
bool AllTablesFitInRegister = true;
bool HasIllegalType = false;
for (SmallDenseMap<PHINode*, Type*>::const_iterator I = ResultTypes.begin(),
E = ResultTypes.end(); I != E; ++I) {
@ -3528,12 +3524,23 @@ static bool ShouldBuildLookupTable(SwitchInst *SI,
if (!TTI->getScalarTargetTransformInfo()->isTypeLegal(Ty))
HasIllegalType = true;
if (!SwitchLookupTable::WouldFitInRegister(TD, TableSize, Ty)) {
AllFit = false;
AllTablesFitInRegister = false;
break;
}
}
return AllFit || (!HasIllegalType && (SI->getNumCases() * 10 >= TableSize * 4));
// If each table would fit in a register, we should build it anyway.
if (AllTablesFitInRegister)
return true;
// Don't build a table that doesn't fit in-register if it has illegal types.
if (HasIllegalType)
return false;
// The table density should be at least 40%. This is the same criterion as for
// jump tables, see SelectionDAGBuilder::handleJTSwitchCase.
// FIXME: Find the best cut-off.
return SI->getNumCases() * 10 >= TableSize * 4;
}
/// SwitchToLookupTable - If the switch is only used to initialize one or more