RPCS3/llvm
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm.git synced 2025-02-09 03:56:28 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Revert "For disassembly when adding a symbolic operand that is a C++ symbol name, also put the human readable name in a comment."

Browse Source 
This reverts commit r198441.

This change doesn't build on Windows, and doesn't do the right thing on
Linux and other platforms that don't use a _Z prefix instead of __Z for
C++ names.

It also had no tests, so it wasn't clear how to fix it forward.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198445 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Reid Kleckner 2014-01-03 19:56:20 +00:00
parent 4432a618e5
commit 077b7b1472
2 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lib/MC/MCDisassembler/Disassembler.cpp
View File

@ -298,7 +298,6 @@ size_t LLVMDisasmInstruction(LLVMDisasmContextRef DCR, uint8_t *Bytes,
emitLatency(DC, Inst); emitLatency(DC, Inst);
emitComments(DC, FormattedOS); emitComments(DC, FormattedOS);
OS.flush();
assert(OutStringSize != 0 && "Output buffer cannot be zero size"); assert(OutStringSize != 0 && "Output buffer cannot be zero size");
size_t OutputSize = std::min(OutStringSize-1, InsnStr.size()); size_t OutputSize = std::min(OutStringSize-1, InsnStr.size());

9
lib/MC/MCExternalSymbolizer.cpp
View File

@ -13,7 +13,6 @@
#include "llvm/MC/MCInst.h" #include "llvm/MC/MCInst.h"
#include "llvm/Support/raw_ostream.h" #include "llvm/Support/raw_ostream.h"
#include <cstring> #include <cstring>
#include <cxxabi.h>
using namespace llvm; using namespace llvm;
@ -57,14 +56,6 @@ bool MCExternalSymbolizer::tryAddingSymbolicOperand(MCInst &MI,
if (Name) { if (Name) {
SymbolicOp.AddSymbol.Name = Name; SymbolicOp.AddSymbol.Name = Name;
SymbolicOp.AddSymbol.Present = true; SymbolicOp.AddSymbol.Present = true;
// If Name is a C++ symbol name put the human readable name in a comment.
if (strncmp(Name, "__Z", 3) == 0) {
char *demangled = abi::__cxa_demangle(Name + 1, 0, 0, 0);
if (demangled) {
cStream << demangled;
free(demangled);
}
}
} }
// For branches always create an MCExpr so it gets printed as hex address. // For branches always create an MCExpr so it gets printed as hex address.
else if (IsBranch) { else if (IsBranch) {