[MCJIT] Respect target endianness in RuntimeDyldMachO and RuntimeDyldChecker.

This patch may address some of the issues described in http://llvm.org/PR20640.



git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@215938 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Lang Hames 2014-08-18 21:43:16 +00:00
parent f759032ccd
commit 08f77a9f42
3 changed files with 22 additions and 6 deletions

View File

@ -705,7 +705,16 @@ uint64_t RuntimeDyldCheckerImpl::readMemoryAtAddr(uint64_t SrcAddr,
assert(PtrSizedAddr == SrcAddr && "Linker memory pointer out-of-range.");
uint8_t *Src = reinterpret_cast<uint8_t *>(PtrSizedAddr);
uint64_t Result = 0;
memcpy(&Result, Src, Size);
// If host and target endianness match use memcpy, otherwise copy in reverse
// order.
if (getRTDyld().IsTargetLittleEndian == sys::IsLittleEndianHost)
memcpy(&Result, Src, Size);
else {
uint8_t *Dst = reinterpret_cast<uint8_t*>(&Result) + Size - 1;
for (unsigned i = 0; i < Size; ++i)
*Dst-- = *Src++;
}
return Result;
}

View File

@ -110,11 +110,18 @@ void RuntimeDyldMachO::dumpRelocationToResolve(const RelocationEntry &RE,
<< " Size: " << (1 << RE.Size) << "\n";
}
bool RuntimeDyldMachO::writeBytesUnaligned(uint8_t *Addr, uint64_t Value,
bool RuntimeDyldMachO::writeBytesUnaligned(uint8_t *Dst, uint64_t Value,
unsigned Size) {
for (unsigned i = 0; i < Size; ++i) {
*Addr++ = (uint8_t)Value;
Value >>= 8;
// If host and target endianness match use memcpy, otherwise copy in reverse
// order.
if (IsTargetLittleEndian == sys::IsLittleEndianHost)
memcpy(Dst, &Value, Size);
else {
uint8_t *Src = reinterpret_cast<uint8_t*>(&Value) + Size - 1;
for (unsigned i = 0; i < Size; ++i)
*Dst++ = *Src--;
}
return false;

View File

@ -119,7 +119,7 @@ public:
/// Write the least significant 'Size' bytes in 'Value' out at the address
/// pointed to by Addr. Check for overflow.
bool writeBytesUnaligned(uint8_t *Addr, uint64_t Value, unsigned Size);
bool writeBytesUnaligned(uint8_t *Dst, uint64_t Value, unsigned Size);
SectionEntry &getSection(unsigned SectionID) { return Sections[SectionID]; }