RPCS3/llvm
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm.git synced 2024-11-27 21:50:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[IR] Add DISuprogram and DIE for a func decl

Browse Source 
A unique DISubprogram may be attached to a function declaration used for
call site debug info.

([6/13] Introduce the debug entry values.)

Co-authored-by: Ananth Sowda <asowda@cisco.com>
Co-authored-by: Nikola Prica <nikola.prica@rt-rk.com>
Co-authored-by: Ivan Baev <ibaev@cisco.com>

Differential Revision: https://reviews.llvm.org/D60713

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@364500 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Djordje Todorovic 2019-06-27 06:07:41 +00:00
parent d42372792d
commit 0bbea12560
4 changed files with 23 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
docs/LangRef.rst
View File

@ -4597,10 +4597,12 @@ DISubprogram
""""""""""""
``DISubprogram`` nodes represent functions from the source language. A
``DISubprogram`` may be attached to a function definition using ``!dbg``
metadata. The ``variables:`` field points at :ref:`variables <DILocalVariable>`
that must be retained, even if their IR counterparts are optimized out of
the IR. The ``type:`` field must point at an :ref:`DISubroutineType`.
distinct ``DISubprogram`` may be attached to a function definition using
``!dbg`` metadata. A unique ``DISubprogram`` may be attached to a function
declaration used for call site debug info. The ``variables:`` field points at
:ref:`variables <DILocalVariable>` that must be retained, even if their IR
counterparts are optimized out of the IR. The ``type:`` field must point at an
:ref:`DISubroutineType`.
.. _DISubprogramDeclaration:

5
lib/CodeGen/AsmPrinter/DwarfDebug.cpp
View File

@ -706,6 +706,11 @@ DwarfDebug::getOrCreateDwarfCompileUnit(const DICompileUnit *DIUnit) {
NewCU.setSection(Asm->getObjFileLowering().getDwarfInfoSection());
}
// Create DIEs for function declarations used for call site debug info.
for (auto Scope : DIUnit->getRetainedTypes())
if (auto *SP = dyn_cast_or_null<DISubprogram>(Scope))
NewCU.getOrCreateSubprogramDIE(SP);
CUMap.insert({DIUnit, &NewCU});
CUDieMap.insert({&NewCU.getUnitDie(), &NewCU});
return NewCU;

7
lib/IR/Verifier.cpp
View File

@ -2263,8 +2263,11 @@ void Verifier::visitFunction(const Function &F) {
MDs.empty() ? nullptr : MDs.front().second);
} else if (F.isDeclaration()) {
for (const auto &I : MDs) {
AssertDI(I.first != LLVMContext::MD_dbg,
"function declaration may not have a !dbg attachment", &F);
// This is used for call site debug information.
AssertDI(I.first != LLVMContext::MD_dbg ||
!cast<DISubprogram>(I.second)->isDistinct(),
"function declaration may only have a unique !dbg attachment",
&F);
Assert(I.first != LLVMContext::MD_prof,
"function declaration may not have a !prof attachment", &F);

9
test/Verifier/metadata-function-dbg.ll
View File

@ -1,8 +1,11 @@
; RUN: llvm-as %s -disable-output 2>&1 | FileCheck %s
; CHECK: function declaration may not have a !dbg attachment
; CHECK: function declaration may only have a unique !dbg attachment
declare !dbg !4 void @f1()
; CHECK-NOT: function declaration may only have a unique !dbg attachment
declare !dbg !6 void @f5()
; CHECK: function must have a single !dbg attachment
define void @f2() !dbg !4 !dbg !4 {
unreachable
@ -31,7 +34,9 @@ define void @bar() !dbg !3 {
!0 = !{i32 2, !"Debug Info Version", i32 3}
!llvm.dbg.cu = !{!1}
!1 = distinct !DICompileUnit(language: DW_LANG_C99, file: !2)
!1 = distinct !DICompileUnit(language: DW_LANG_C99, file: !2, retainedTypes: !5)
!2 = !DIFile(filename: "t.c", directory: "/path/to/dir")
!3 = !{}
!4 = distinct !DISubprogram(name: "foo", scope: !1, file: !2, unit: !1)
!5 = !{!6}
!6 = !DISubprogram(name: "f5", scope: !1, file: !2, unit: !1, flags: DIFlagPrototyped, spFlags: DISPFlagOptimized)