From 12ca5fd71168c549414c3ba7320b0d70084232ea Mon Sep 17 00:00:00 2001 From: Mandeep Singh Grang Date: Fri, 10 Nov 2017 19:09:28 +0000 Subject: [PATCH] [RISCV] Silence an unused variable warning in release builds [NFC] Summary: Also minor cleanups: 1. Avoided multiple calls to Fixup.getKind() 2. Avoided multiple calls to getFixupKindInfo() 3. Removed a redundant return. Reviewers: asb, apazos Reviewed By: asb Subscribers: rbar, johnrusso, llvm-commits Differential Revision: https://reviews.llvm.org/D39881 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@317908 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Target/RISCV/MCTargetDesc/RISCVAsmBackend.cpp | 9 +++++---- lib/Target/RISCV/RISCVRegisterInfo.cpp | 1 - 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/Target/RISCV/MCTargetDesc/RISCVAsmBackend.cpp b/lib/Target/RISCV/MCTargetDesc/RISCVAsmBackend.cpp index add63b6e77f..e4e17bed5af 100644 --- a/lib/Target/RISCV/MCTargetDesc/RISCVAsmBackend.cpp +++ b/lib/Target/RISCV/MCTargetDesc/RISCVAsmBackend.cpp @@ -161,11 +161,9 @@ void RISCVAsmBackend::applyFixup(const MCAssembler &Asm, const MCFixup &Fixup, MutableArrayRef Data, uint64_t Value, bool IsResolved) const { MCContext &Ctx = Asm.getContext(); - MCFixupKind Kind = Fixup.getKind(); - unsigned NumBytes = (getFixupKindInfo(Kind).TargetSize + 7) / 8; + MCFixupKindInfo Info = getFixupKindInfo(Fixup.getKind()); if (!Value) return; // Doesn't change encoding. - MCFixupKindInfo Info = getFixupKindInfo(Fixup.getKind()); // Apply any target-specific value adjustments. Value = adjustFixupValue(Fixup, Value, Ctx); @@ -173,14 +171,17 @@ void RISCVAsmBackend::applyFixup(const MCAssembler &Asm, const MCFixup &Fixup, Value <<= Info.TargetOffset; unsigned Offset = Fixup.getOffset(); + +#ifndef NDEBUG + unsigned NumBytes = (Info.TargetSize + 7) / 8; assert(Offset + NumBytes <= Data.size() && "Invalid fixup offset!"); +#endif // For each byte of the fragment that the fixup touches, mask in the // bits from the fixup value. for (unsigned i = 0; i != 4; ++i) { Data[Offset + i] |= uint8_t((Value >> (i * 8)) & 0xff); } - return; } std::unique_ptr diff --git a/lib/Target/RISCV/RISCVRegisterInfo.cpp b/lib/Target/RISCV/RISCVRegisterInfo.cpp index cd658d7e2d9..75b277531ce 100644 --- a/lib/Target/RISCV/RISCVRegisterInfo.cpp +++ b/lib/Target/RISCV/RISCVRegisterInfo.cpp @@ -82,7 +82,6 @@ void RISCVRegisterInfo::eliminateFrameIndex(MachineBasicBlock::iterator II, MI.getOperand(FIOperandNum).ChangeToRegister(FrameReg, false); MI.getOperand(FIOperandNum + 1).ChangeToImmediate(Offset); - return; } unsigned RISCVRegisterInfo::getFrameRegister(const MachineFunction &MF) const {