RPCS3/llvm
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm.git synced 2025-02-22 11:42:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[llvm-nm] Remove redundant check for file validity.

Browse Source 
We already perform it at the beginning of the function so we can't
arrive here with an invalid object. Also, add a test so that bugs
won't sneak in the future.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@258982 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Davide Italiano 2016-01-27 20:27:44 +00:00
parent 8362c240ca
commit 1db4cdc3b1
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/tools/llvm-nm/invalid-input.test Normal file
View File

@ -0,0 +1,2 @@
RUN: not llvm-nm %s 2>&1 | FileCheck %s -check-prefix=UNKNOWN_FILE_TYPE
UNKNOWN_FILE_TYPE: {{.*}}invalid-input.test: The file was not recognized as a valid object file

2
tools/llvm-nm/llvm-nm.cpp
View File

@ -1240,9 +1240,7 @@ static void dumpSymbolNamesFromFile(std::string &Filename) {
if (!checkMachOAndArchFlags(O, Filename))
return;
dumpSymbolNamesFromObject(*O, true);
return;
}
error("unrecognizable file type", Filename);
}
int main(int argc, char **argv) {