RPCS3/llvm
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm.git synced 2025-03-05 00:59:19 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[FastISel] Local values shouldn't be alive across an inline asm call with side effects.

Browse Source 
This fixes an issue where a local value is defined before and used after an
inline asm call with side effects.

This fix simply flushes the local value map, which updates the insertion point
for the inline asm call to be above any previously defined local values.

This fixes <rdar://problem/17694203>

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@213203 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Juergen Ributzka 2014-07-16 22:20:51 +00:00
parent 04fc9aeda3
commit 22441c3a0d
2 changed files with 23 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/CodeGen/SelectionDAG/FastISel.cpp
View File

@ -1038,6 +1038,11 @@ bool FastISel::SelectCall(const User *I) {
// Handle simple inline asms.
if (const InlineAsm *IA = dyn_cast<InlineAsm>(Call->getCalledValue())) {
// If the inline asm has side effects, then make sure that no local value
// lives across by flushing the local value map.
if (IA->hasSideEffects())
flushLocalValueMap();
// Don't attempt to handle constraints.
if (!IA->getConstraintString().empty())
return false;

18
test/CodeGen/ARM/fast-isel-inline-asm.ll Normal file
View File

@ -0,0 +1,18 @@
; RUN: llc -fast-isel < %s | FileCheck %s
target datalayout = "e-m:o-p:32:32-i1:8:32-i8:8:32-i16:16:32-f64:32:64-v64:32:64-v128:32:128-a:0:32-n32-S32"
target triple = "thumbv7-apple-ios5.0.0"
%0 = type opaque
; Make sure that the inline asm starts right after the call to bar.
define void @test_inline_asm_sideeffect(%0* %call) {
; CHECK: bl _bar
; CHECK-NEXT: InlineAsm Start
call void @bar()
call void asm sideeffect "mov\09r7, r7\09\09@ marker", ""()
%1 = call %0* bitcast (i8* (i8*)* @foo to %0* (%0*)*)(%0* %call)
ret void
}
declare i8* @foo(i8*)
declare void @bar()