RPCS3/llvm
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm.git synced 2025-02-11 05:17:36 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[ValueTracking] remove a FIXME for something we don't want to do; NFC

Browse Source 
The comment was added with:
https://reviews.llvm.org/rL293773
...but there would be a cost to implement this and possibly no payoff.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@293823 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Sanjay Patel 2017-02-01 22:27:34 +00:00
parent 7aa802198b
commit 24d35c93d6
2 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/Analysis/ValueTracking.cpp
View File

@ -797,10 +797,6 @@ static void computeKnownBitsFromAssume(const Value *V, APInt &KnownZero,
// FIXME: Publish a warning/remark that we have encountered UB or the compiler
// is broken.
// FIXME: Implement a stronger version of "I give up" by invalidating/clearing
// the assumption cache. This should indicate that the cache is corrupted so
// future callers will not waste time repopulating it with faulty assumptions.
if ((KnownZero & KnownOne) != 0) {
KnownZero.clearAllBits();
KnownOne.clearAllBits();

3
test/Transforms/InstSimplify/assume.ll
View File

@ -28,8 +28,7 @@ define i64 @PR31809() {
; Similar to above: there's no way to know which assumption is truthful,
; so just don't crash. The second icmp+assume gets processed later, so that
; determines the return value. This can be improved by permanently invalidating
; the cached assumptions for this function.
; determines the return value.
define i8 @conflicting_assumptions(i8 %x) {
; CHECK-LABEL: @conflicting_assumptions(