From 24f5fddbdff3d54d822555ae792a7f3bb22e342f Mon Sep 17 00:00:00 2001 From: Chad Rosier Date: Mon, 10 Sep 2012 21:36:05 +0000 Subject: [PATCH] [ms-inline asm] Properly emit the asm directives when the AsmPrinterVariant and InlineAsmVariant don't match. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@163550 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp | 18 +++++++++++++++++- test/CodeGen/X86/ms-inline-asm.ll | 4 ++-- 2 files changed, 19 insertions(+), 3 deletions(-) diff --git a/lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp b/lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp index 2dfb73e300e..260871d33b0 100644 --- a/lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp +++ b/lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp @@ -200,7 +200,15 @@ void AsmPrinter::EmitInlineAsm(const MachineInstr *MI) const { // The variant of the current asmprinter. int AsmPrinterVariant = MAI->getAssemblerDialect(); int InlineAsmVariant = MI->getInlineAsmDialect(); - + + // Switch to the inline assembly variant. + if (AsmPrinterVariant != InlineAsmVariant) { + if (InlineAsmVariant == 0) + OS << ".att_syntax\n\t"; + else + OS << ".intel_syntax\n\t"; + } + int CurVariant = -1; // The number of the {.|.|.} region we are in. const char *LastEmitted = AsmStr; // One past the last character emitted. @@ -365,6 +373,14 @@ void AsmPrinter::EmitInlineAsm(const MachineInstr *MI) const { } } } + // Switch to the AsmPrinter variant. + if (AsmPrinterVariant != InlineAsmVariant) { + if (AsmPrinterVariant == 0) + OS << "\n\t.att_syntax"; + else + OS << "\n\t.intel_syntax"; + } + OS << '\n' << (char)0; // null terminate string. EmitInlineAsm(OS.str(), LocMD, MI->getInlineAsmDialect()); diff --git a/test/CodeGen/X86/ms-inline-asm.ll b/test/CodeGen/X86/ms-inline-asm.ll index ea096c7db4d..9bebcbde43e 100644 --- a/test/CodeGen/X86/ms-inline-asm.ll +++ b/test/CodeGen/X86/ms-inline-asm.ll @@ -6,9 +6,9 @@ entry: ret i32 %0 ; CHECK: t1 ; CHECK: ## InlineAsm Start -; FIXME: .intel_syntax +; CHECK: .intel_syntax ; CHECK: mov eax, ecx ; CHECK: mov ecx, eax -; FIXME: .att_syntax +; CHECK: .att_syntax ; CHECK: ## InlineAsm End }