RPCS3/llvm
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm.git synced 2025-04-14 03:50:48 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

GlobalOpt: Don't optimize thread_local for initializers

Browse Source 
Folding a reference to a thread_local variable into another global
variable's initializer is very problematic, there is no relocation that
exists to represent such an access.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@211762 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
David Majnemer 2014-06-26 03:02:19 +00:00
parent b0f5a0e7e7
commit 29640bcb7d
2 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/Transforms/IPO/GlobalOpt.cpp
View File

@ -1980,9 +1980,10 @@ isSimpleEnoughValueToCommit(Constant *C,
static bool isSimpleEnoughValueToCommitHelper(Constant *C, static bool isSimpleEnoughValueToCommitHelper(Constant *C,
SmallPtrSet<Constant*, 8> &SimpleConstants, SmallPtrSet<Constant*, 8> &SimpleConstants,
const DataLayout *DL) { const DataLayout *DL) {
// Simple global addresses are supported, do not allow dllimport globals. // Simple global addresses are supported, do not allow dllimport or
// thread-local globals.
if (auto *GV = dyn_cast<GlobalValue>(C)) if (auto *GV = dyn_cast<GlobalValue>(C))
return !GV->hasDLLImportStorageClass(); return !GV->hasDLLImportStorageClass() && !GV->isThreadLocal();
// Simple integer, undef, constant aggregate zero, etc are all supported. // Simple integer, undef, constant aggregate zero, etc are all supported.
if (C->getNumOperands() == 0 || isa<BlockAddress>(C)) if (C->getNumOperands() == 0 || isa<BlockAddress>(C))

12
test/Transforms/GlobalOpt/constantfold-initializers.ll
View File

@ -72,9 +72,19 @@ entry:
ret void ret void
} }
@threadlocalptr = global i32* null, align 4
; CHECK: @threadlocalptr = global i32* null, align 4
@threadlocalvar = external thread_local global i32
define internal void @test5() {
entry:
store i32* @threadlocalvar, i32** @threadlocalptr, align 4
ret void
}
@llvm.global_ctors = appending constant @llvm.global_ctors = appending constant
[4 x { i32, void ()* }] [5 x { i32, void ()* }]
[{ i32, void ()* } { i32 65535, void ()* @test1 }, [{ i32, void ()* } { i32 65535, void ()* @test1 },
{ i32, void ()* } { i32 65535, void ()* @test2 }, { i32, void ()* } { i32 65535, void ()* @test2 },
{ i32, void ()* } { i32 65535, void ()* @test3 }, { i32, void ()* } { i32 65535, void ()* @test3 },
{ i32, void ()* } { i32 65535, void ()* @test4 },
{ i32, void ()* } { i32 65535, void ()* @test4 }] { i32, void ()* } { i32 65535, void ()* @test4 }]