RPCS3/llvm
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm.git synced 2025-04-03 22:01:56 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

signficant cleanups to EmitGlobalConstant (including streamerization

Browse Source 
of int initializers), change some methods to be static functions,
use raw_ostream::write_hex instead of a smallstring dance with 
APValue::toStringUnsigned(S, 16).


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@93991 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Chris Lattner 2010-01-20 07:11:32 +00:00
parent 3bcda49b35
commit 2dd245c469
3 changed files with 68 additions and 106 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/llvm/CodeGen/AsmPrinter.h
View File

@ -427,8 +427,6 @@ namespace llvm {
private: private:
void EmitLLVMUsedList(Constant *List); void EmitLLVMUsedList(Constant *List);
void EmitXXStructorList(Constant *List); void EmitXXStructorList(Constant *List);
void EmitGlobalConstantLargeInt(const ConstantInt* CI, unsigned AddrSpace);
void EmitGlobalConstantFP(const ConstantFP *CFP, unsigned AddrSpace);
GCMetadataPrinter *GetOrCreateGCPrinter(GCStrategy *C); GCMetadataPrinter *GetOrCreateGCPrinter(GCStrategy *C);
}; };
} }

170
lib/CodeGen/AsmPrinter/AsmPrinter.cpp
View File

@ -1098,16 +1098,16 @@ static void EmitGlobalConstantStruct(const ConstantStruct *CS,
// Print the fields in successive locations. Pad to align if needed! // Print the fields in successive locations. Pad to align if needed!
const TargetData *TD = AP.TM.getTargetData(); const TargetData *TD = AP.TM.getTargetData();
unsigned Size = TD->getTypeAllocSize(CS->getType()); unsigned Size = TD->getTypeAllocSize(CS->getType());
const StructLayout *cvsLayout = TD->getStructLayout(CS->getType()); const StructLayout *Layout = TD->getStructLayout(CS->getType());
uint64_t SizeSoFar = 0; uint64_t SizeSoFar = 0;
for (unsigned i = 0, e = CS->getNumOperands(); i != e; ++i) { for (unsigned i = 0, e = CS->getNumOperands(); i != e; ++i) {
const Constant *field = CS->getOperand(i); const Constant *field = CS->getOperand(i);
// Check if padding is needed and insert one or more 0s. // Check if padding is needed and insert one or more 0s.
uint64_t fieldSize = TD->getTypeAllocSize(field->getType()); uint64_t FieldSize = TD->getTypeAllocSize(field->getType());
uint64_t padSize = ((i == e-1 ? Size : cvsLayout->getElementOffset(i+1)) uint64_t PadSize = ((i == e-1 ? Size : Layout->getElementOffset(i+1))
- cvsLayout->getElementOffset(i)) - fieldSize; - Layout->getElementOffset(i)) - FieldSize;
SizeSoFar += fieldSize + padSize; SizeSoFar += FieldSize + PadSize;
// Now print the actual field value. // Now print the actual field value.
AP.EmitGlobalConstant(field, AddrSpace); AP.EmitGlobalConstant(field, AddrSpace);
@ -1115,36 +1115,36 @@ static void EmitGlobalConstantStruct(const ConstantStruct *CS,
// Insert padding - this may include padding to increase the size of the // Insert padding - this may include padding to increase the size of the
// current field up to the ABI size (if the struct is not packed) as well // current field up to the ABI size (if the struct is not packed) as well
// as padding to ensure that the next field starts at the right offset. // as padding to ensure that the next field starts at the right offset.
AP.OutStreamer.EmitZeros(padSize, AddrSpace); AP.OutStreamer.EmitZeros(PadSize, AddrSpace);
} }
assert(SizeSoFar == cvsLayout->getSizeInBytes() && assert(SizeSoFar == Layout->getSizeInBytes() &&
"Layout of constant struct may be incorrect!"); "Layout of constant struct may be incorrect!");
} }
void AsmPrinter::EmitGlobalConstantFP(const ConstantFP *CFP, static void EmitGlobalConstantFP(const ConstantFP *CFP, unsigned AddrSpace,
unsigned AddrSpace) { AsmPrinter &AP) {
// FP Constants are printed as integer constants to avoid losing // FP Constants are printed as integer constants to avoid losing
// precision. // precision.
if (CFP->getType()->isDoubleTy()) { if (CFP->getType()->isDoubleTy()) {
if (VerboseAsm) { if (AP.VerboseAsm) {
double Val = CFP->getValueAPF().convertToDouble(); // for comment only double Val = CFP->getValueAPF().convertToDouble(); // for comment only
O.PadToColumn(MAI->getCommentColumn()); AP.O.PadToColumn(AP.MAI->getCommentColumn());
O << MAI->getCommentString() << " double " << Val << '\n'; AP.O << AP.MAI->getCommentString() << " double " << Val << '\n';
} }
uint64_t i = CFP->getValueAPF().bitcastToAPInt().getZExtValue(); uint64_t Val = CFP->getValueAPF().bitcastToAPInt().getZExtValue();
OutStreamer.EmitIntValue(i, 8, AddrSpace); AP.OutStreamer.EmitIntValue(Val, 8, AddrSpace);
return; return;
} }
if (CFP->getType()->isFloatTy()) { if (CFP->getType()->isFloatTy()) {
if (VerboseAsm) { if (AP.VerboseAsm) {
float Val = CFP->getValueAPF().convertToFloat(); // for comment only float Val = CFP->getValueAPF().convertToFloat(); // for comment only
O.PadToColumn(MAI->getCommentColumn()); AP.O.PadToColumn(AP.MAI->getCommentColumn());
O << MAI->getCommentString() << " float " << Val << '\n'; AP.O << AP.MAI->getCommentString() << " float " << Val << '\n';
} }
OutStreamer.EmitIntValue(CFP->getValueAPF().bitcastToAPInt().getZExtValue(), uint64_t Val = CFP->getValueAPF().bitcastToAPInt().getZExtValue();
4, AddrSpace); AP.OutStreamer.EmitIntValue(Val, 4, AddrSpace);
return; return;
} }
@ -1153,29 +1153,29 @@ void AsmPrinter::EmitGlobalConstantFP(const ConstantFP *CFP,
// api needed to prevent premature destruction // api needed to prevent premature destruction
APInt API = CFP->getValueAPF().bitcastToAPInt(); APInt API = CFP->getValueAPF().bitcastToAPInt();
const uint64_t *p = API.getRawData(); const uint64_t *p = API.getRawData();
if (VerboseAsm) { if (AP.VerboseAsm) {
// Convert to double so we can print the approximate val as a comment. // Convert to double so we can print the approximate val as a comment.
APFloat DoubleVal = CFP->getValueAPF(); APFloat DoubleVal = CFP->getValueAPF();
bool ignored; bool ignored;
DoubleVal.convert(APFloat::IEEEdouble, APFloat::rmNearestTiesToEven, DoubleVal.convert(APFloat::IEEEdouble, APFloat::rmNearestTiesToEven,
&ignored); &ignored);
O.PadToColumn(MAI->getCommentColumn()); AP.O.PadToColumn(AP.MAI->getCommentColumn());
O << MAI->getCommentString() << " x86_fp80 ~= " AP.O << AP.MAI->getCommentString() << " x86_fp80 ~= "
<< DoubleVal.convertToDouble() << '\n'; << DoubleVal.convertToDouble() << '\n';
} }
if (TM.getTargetData()->isBigEndian()) { if (AP.TM.getTargetData()->isBigEndian()) {
OutStreamer.EmitIntValue(p[1], 2, AddrSpace); AP.OutStreamer.EmitIntValue(p[1], 2, AddrSpace);
OutStreamer.EmitIntValue(p[0], 8, AddrSpace); AP.OutStreamer.EmitIntValue(p[0], 8, AddrSpace);
} else { } else {
OutStreamer.EmitIntValue(p[0], 8, AddrSpace); AP.OutStreamer.EmitIntValue(p[0], 8, AddrSpace);
OutStreamer.EmitIntValue(p[1], 2, AddrSpace); AP.OutStreamer.EmitIntValue(p[1], 2, AddrSpace);
} }
// Emit the tail padding for the long double. // Emit the tail padding for the long double.
const TargetData &TD = *TM.getTargetData(); const TargetData &TD = *AP.TM.getTargetData();
OutStreamer.EmitZeros(TD.getTypeAllocSize(CFP->getType()) - AP.OutStreamer.EmitZeros(TD.getTypeAllocSize(CFP->getType()) -
TD.getTypeStoreSize(CFP->getType()), AddrSpace); TD.getTypeStoreSize(CFP->getType()), AddrSpace);
return; return;
} }
@ -1185,18 +1185,18 @@ void AsmPrinter::EmitGlobalConstantFP(const ConstantFP *CFP,
// premature destruction. // premature destruction.
APInt API = CFP->getValueAPF().bitcastToAPInt(); APInt API = CFP->getValueAPF().bitcastToAPInt();
const uint64_t *p = API.getRawData(); const uint64_t *p = API.getRawData();
if (TM.getTargetData()->isBigEndian()) { if (AP.TM.getTargetData()->isBigEndian()) {
OutStreamer.EmitIntValue(p[0], 8, AddrSpace); AP.OutStreamer.EmitIntValue(p[0], 8, AddrSpace);
OutStreamer.EmitIntValue(p[1], 8, AddrSpace); AP.OutStreamer.EmitIntValue(p[1], 8, AddrSpace);
} else { } else {
OutStreamer.EmitIntValue(p[1], 8, AddrSpace); AP.OutStreamer.EmitIntValue(p[1], 8, AddrSpace);
OutStreamer.EmitIntValue(p[0], 8, AddrSpace); AP.OutStreamer.EmitIntValue(p[0], 8, AddrSpace);
} }
} }
void AsmPrinter::EmitGlobalConstantLargeInt(const ConstantInt *CI, static void EmitGlobalConstantLargeInt(const ConstantInt *CI,
unsigned AddrSpace) { unsigned AddrSpace, AsmPrinter &AP) {
const TargetData *TD = TM.getTargetData(); const TargetData *TD = AP.TM.getTargetData();
unsigned BitWidth = CI->getBitWidth(); unsigned BitWidth = CI->getBitWidth();
assert((BitWidth & 63) == 0 && "only support multiples of 64-bits"); assert((BitWidth & 63) == 0 && "only support multiples of 64-bits");
@ -1205,51 +1205,38 @@ void AsmPrinter::EmitGlobalConstantLargeInt(const ConstantInt *CI,
// quantities at a time. // quantities at a time.
const uint64_t *RawData = CI->getValue().getRawData(); const uint64_t *RawData = CI->getValue().getRawData();
for (unsigned i = 0, e = BitWidth / 64; i != e; ++i) { for (unsigned i = 0, e = BitWidth / 64; i != e; ++i) {
uint64_t Val; uint64_t Val = TD->isBigEndian() ? RawData[e - i - 1] : RawData[i];
if (TD->isBigEndian()) AP.OutStreamer.EmitIntValue(Val, 8, AddrSpace);
Val = RawData[e - i - 1];
else
Val = RawData[i];
if (MAI->getData64bitsDirective(AddrSpace)) {
O << MAI->getData64bitsDirective(AddrSpace) << Val << '\n';
continue;
}
// Emit two 32-bit chunks, order depends on endianness.
unsigned FirstChunk = unsigned(Val), SecondChunk = unsigned(Val >> 32);
const char *FirstName = " least", *SecondName = " most";
if (TD->isBigEndian()) {
std::swap(FirstChunk, SecondChunk);
std::swap(FirstName, SecondName);
}
O << MAI->getData32bitsDirective(AddrSpace) << FirstChunk;
if (VerboseAsm) {
O.PadToColumn(MAI->getCommentColumn());
O << MAI->getCommentString()
<< FirstName << " significant half of i64 " << Val;
}
O << '\n';
O << MAI->getData32bitsDirective(AddrSpace) << SecondChunk;
if (VerboseAsm) {
O.PadToColumn(MAI->getCommentColumn());
O << MAI->getCommentString()
<< SecondName << " significant half of i64 " << Val;
}
O << '\n';
} }
} }
/// EmitGlobalConstant - Print a general LLVM constant to the .s file. /// EmitGlobalConstant - Print a general LLVM constant to the .s file.
void AsmPrinter::EmitGlobalConstant(const Constant *CV, unsigned AddrSpace) { void AsmPrinter::EmitGlobalConstant(const Constant *CV, unsigned AddrSpace) {
const TargetData *TD = TM.getTargetData(); if (CV->isNullValue() || isa<UndefValue>(CV)) {
const Type *type = CV->getType(); uint64_t Size = TM.getTargetData()->getTypeAllocSize(CV->getType());
unsigned Size = TD->getTypeAllocSize(type);
if (CV->isNullValue() || isa<UndefValue>(CV))
return OutStreamer.EmitZeros(Size, AddrSpace); return OutStreamer.EmitZeros(Size, AddrSpace);
}
if (const ConstantInt *CI = dyn_cast<ConstantInt>(CV)) {
unsigned Size = TM.getTargetData()->getTypeAllocSize(CV->getType());
switch (Size) {
case 1:
case 2:
case 4:
case 8:
if (VerboseAsm) {
O.PadToColumn(MAI->getCommentColumn());
O << MAI->getCommentString() << " 0x";
O.write_hex(CI->getZExtValue());
O << '\n';
}
OutStreamer.EmitIntValue(CI->getZExtValue(), Size, AddrSpace);
return;
default:
EmitGlobalConstantLargeInt(CI, AddrSpace, *this);
return;
}
}
if (const ConstantArray *CVA = dyn_cast<ConstantArray>(CV)) if (const ConstantArray *CVA = dyn_cast<ConstantArray>(CV))
return EmitGlobalConstantArray(CVA, AddrSpace, *this); return EmitGlobalConstantArray(CVA, AddrSpace, *this);
@ -1258,36 +1245,13 @@ void AsmPrinter::EmitGlobalConstant(const Constant *CV, unsigned AddrSpace) {
return EmitGlobalConstantStruct(CVS, AddrSpace, *this); return EmitGlobalConstantStruct(CVS, AddrSpace, *this);
if (const ConstantFP *CFP = dyn_cast<ConstantFP>(CV)) if (const ConstantFP *CFP = dyn_cast<ConstantFP>(CV))
return EmitGlobalConstantFP(CFP, AddrSpace); return EmitGlobalConstantFP(CFP, AddrSpace, *this);
if (const ConstantInt *CI = dyn_cast<ConstantInt>(CV)) {
// If we can directly emit an 8-byte constant, do it.
if (Size == 8)
if (const char *Data64Dir = MAI->getData64bitsDirective(AddrSpace)) {
O << Data64Dir << CI->getZExtValue() << '\n';
return;
}
// Small integers are handled below; large integers are handled here.
if (Size > 4) {
EmitGlobalConstantLargeInt(CI, AddrSpace);
return;
}
}
if (const ConstantVector *V = dyn_cast<ConstantVector>(CV)) if (const ConstantVector *V = dyn_cast<ConstantVector>(CV))
return EmitGlobalConstantVector(V, AddrSpace, *this); return EmitGlobalConstantVector(V, AddrSpace, *this);
printDataDirective(type, AddrSpace); printDataDirective(CV->getType(), AddrSpace);
EmitConstantValueOnly(CV); EmitConstantValueOnly(CV);
if (VerboseAsm) {
if (const ConstantInt *CI = dyn_cast<ConstantInt>(CV)) {
SmallString<40> S;
CI->getValue().toStringUnsigned(S, 16);
O.PadToColumn(MAI->getCommentColumn());
O << MAI->getCommentString() << " 0x" << S.str();
}
}
O << '\n'; O << '\n';
} }

2
test/CodeGen/X86/i128-and-beyond.ll
View File

@ -1,4 +1,4 @@
; RUN: llc < %s -march=x86 -mtriple=i686-pc-linux-gnu | grep 18446744073709551615 | count 14 ; RUN: llc < %s -march=x86 -mtriple=i686-pc-linux-gnu | grep -- -1 | count 14
; These static initializers are too big to hand off to assemblers ; These static initializers are too big to hand off to assemblers
; as monolithic blobs. ; as monolithic blobs.